Jump to content

[1.16.1] Trouble with displaying particles


Tavi007

Recommended Posts

Hello,

I'm currently working on my first particle by following TheGreyGhosts tutorial mod (MinecraftByExample). For now I copied most of the code and changed some lines from 'World' to 'ClientWorld'. I did this change, because the example is for 1.15 and I'm using 1.16 (for example line 26 in CombatParticle needs ClientWorld, because otherwise the constructor was unknown). The code is compiling just fine, but my particle is nowhere to be seen. The particle is supposed to be spawning, when I hit an enemy (see line 108-121 in ElementifyLivingHurtEvent). My best assumption is, that I'm trying to spawn the particle on the server side instead of client side, which is why makeParticle(...) of the CombatParticleFactory is never called.

 

Could someone please explain to me, what I'm doing wrong and how I can fix it?

Link to comment
Share on other sites

Howdy

I haven't played with 1.16 yet, but the best way to troubleshoot this is to set a breakpoint in your particle spawn, then trace into the vanilla code and see what it does after that.

You might find that your spawn call is just ignored (because you're calling the wrong method), or that your particle type is not registered correctly, or the packet is never sent, or that when the packet is received it is ignored for some reason, or that your particle is actually rendering but is invisible or in a different space than you think.

 

-TGG

Link to comment
Share on other sites

I took a deeper look at vanilla minecraft code and noticed, that the addParticle()- function of the class World is empty. However ClientWorld extends World and implements the addParticle function properly. I also looked at the working 1.16 mod 'Rats'. Here he simply calls event.getWorld(), with event being an instance of PlayerInteractEvent.EntityInteract. Calling event.getWorld() should also return a World (not a ClientWorld!), but somehow he can then call .spawnParticle().

I'm kinda confused, why his mod is working. Also I still have no idea, how I should get the right ClientWorld, so I can use its addParticle() function.

Link to comment
Share on other sites

Assuming that it has not changed since 1.15, EntityInteract is fired on both logical sides. This means that when it is fired on the client side, the world will be a ClientWorld (remember that ClientWorld is a subclass of World), and thus addParticle will be implemented and work, which it why it works for the Rats mod. The onLivingHurt event however only fires on the server, I believe.

 

Edit: To create particles from the server, use the spawnParticle method instead of addParticle (as I now see that the Rats mod does), which should also send the particles to the client.

Edited by vemerion
Link to comment
Share on other sites

You mean, that I should change

target.getEntityWorld().addParticle(new CombatParticleData(tint, diameter), xpos, ypos, zpos, xSpeed, ySpeed, zSpeed);

to

target.getEntityWorld().spawnParticle(new CombatParticleData(tint, diameter), xpos, ypos, zpos, xSpeed, ySpeed, zSpeed);

?

When I do that, I only get the error, that spawnParticle is an unknown method. ( I expected this error, but I tried anyway. I don't know, if I'm missing something crucial)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.