Jump to content

[1.15.2] Rendering multiple fake blocks culls faces that are only hidden on one fake block


T-Dark_

Recommended Posts

I'm trying to render a fake block as a sort of "targeting preview" for using a certain item. The block should eventually be drawn at where the player is looking at (which can be really far), but for now I'm just trying to understand how rendering works on a basic level.

To be entirely honest, I don't fully understand the code that I'm using yet. I've copy-pasted it from another question and am now messing around to see which things do what. That being said, I'm seeing a weird piece of behaviour and am stumped.

I'm rendering two "fake" blocks, and they seem to work just fine. That is, until I place a block near one of them. Logically, the face that cannot be seen (there is a block in the way, after all), disappears. However, the same face disappears on the other fake block as well.

 

My code is here: https://github.com/T-Dark0/modding-tutorial/blob/master/src/main/java/com/tdark/mymod/rendering/Rendering.java

 

Why does this happen?

629400737_wrongculling.thumb.jpeg.57c0e944cc99b4639b52589b47738e66.jpeg

Link to comment
Share on other sites

Try not using the same block state for rendering multiple blocks. Create a new one (via getDefaultState) each time.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

8 minutes ago, DavidM said:

Try not using the same block state for rendering multiple blocks. Create a new one (via getDefaultState) each time.

You mean like

        BlockState blockState1 = Blocks.OBSIDIAN.getDefaultState();
        BlockState blockState2 = Blocks.OBSIDIAN.getDefaultState(); 

and then the two calls to renderBlock are identical except one gets blockState1 and the other gets blockState2?

Isn't that the same blockstate anyway?

(Even if it isn't, tried that, doesn't work. The problem remains)

Link to comment
Share on other sites

Howdy

the block renderer uses the BlockPos to check the adjacent blocks to see if any are blocking out the faces

eg if there is a full solid block to the EAST of your block, then the renderer doesn't draw the EAST face.

You appear to use the same dummy BlockPos for both blocks, so if the EAST face is hidden for that blockpos (because there is a solid block to the EAST), then the EAST face is always hidden, regardless of where you have told the renderer to draw your block by translating the render.

 

-TGG

 

 

 

 

 

 

 

 

Link to comment
Share on other sites

17 hours ago, T-Dark_ said:

You mean like


        BlockState blockState1 = Blocks.OBSIDIAN.getDefaultState();
        BlockState blockState2 = Blocks.OBSIDIAN.getDefaultState(); 

and then the two calls to renderBlock are identical except one gets blockState1 and the other gets blockState2?

Isn't that the same blockstate anyway?

(Even if it isn't, tried that, doesn't work. The problem remains)

Ah my bad, I was thinking about mutable block states from Spigot.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.