Chunk forgets about the player if they stop moving

[Draco18s 2414]

Not sure this is Forge's problem, or a vanilla thing, but I noticed it because of Mystcraft (as Mystcraft uses the chunk.hasEntities function to apply potion effects in some dimensions).

 

I have already reported this to XCompWiz who says that the problem is not occurring inside his code.

 

In order to (easily) reproduce the behavior:

1) Install Mystcraft

2) Place book binder block, put leather in upper left slot, add to the central black area:

• Linking panel (page).  Must be farthest left
  
• Diamond ore block (page).  Must be left of next page
  
• Tendrils (page)
  

(All mystcraft items can be found in Mystcraft's creative tabs)

3) remove book from upper left slot

4) Right-click with the book, click the black panel to teleport to new dimension

5) Stand still under the open sky.  Looking around is ok, moving is not.

6) Check inventory for status effects, if not affected by any, repeat steps 1-5.

7) After about 30 seconds you'll stop getting afflicted with the potion effect and it takes walking across a chunk boundary to reset it.

[LexManos 1620]

Do you have ChickenChunks installed?

[Draco18s 2414]

Do you have ChickenChunks installed?

 

No.  Just Forge, Mystcraft, and originally my own mod

 

My mod only adds blocks and environmental effects similar to Mystcraft's Scorching--which relies on the chunk update and chunk.hasEntitites--it was actually my mod that allowed me to notice the behavior, as I was waiting for a long-term effect to complete and I was watching the counter go up and then stop and I was trying to figure out why.  Then I noticed that Mystcraft's potion effects had the same thing happen (I'd noticed it before, but it was so transitory as I was constantly moving, that I attributed it to the RNG).

 

So then I started making sure there was no random behavior at all, that all (living)entities in all chunks were being processed and it would still "time out."

[LexManos 1620]

Chunk.hasEntities only refers to entities that it must save to disc, this does not deal with anything besides that.

And consdiering that Players are not saved to the Chunk but are instead given it's own file, this flag would be set to false if there are no other vail saveable entities.

It seems that you should simply be checking

for (int x = 0; x < chunk.entityLists.length; x++)

  if chunk.entityLists[x].length > 0

 

Less efficent yes, but thats how the flag works.

 

[Draco18s 2414]

Thanks, re-reported back to XCW.