[1.15.2] NoSuchMethodError when testing on server

[PianoManu]

Hey guys!

I ran into some obstinate NoSuchMethodError today whilst testing my mod on a server (locally). I made a block with a tile entity, that mimics another block when it's right-clicked with said block. When I break the block containing the other block, my method "dropContainedBlock" is called to spawn an ItemEntity of the mimicked block. Now that is where I get the NoSuchMethodError exception and the server crashes. Here's my method. I mainly copied it from the vanilla jukebox, but the jukebox works a bit different because it "stores" only records, not blocks:

    //Used to drop the contained block
    //We check the tile entity, get the block from the tile entity and drop it at the block pos plus some small random coords in the world
    protected void dropContainedBlock(World worldIn, BlockPos pos) {
        if (!worldIn.isRemote) {
            TileEntity tileentity = worldIn.getTileEntity(pos);
            if (tileentity instanceof FrameBlockTile) {
                FrameBlockTile frameTileEntity = (FrameBlockTile) tileentity; //My custom tile entity
                BlockState blockState = frameTileEntity.getMimic(); //the contained blockstate
                if (!(blockState == null)) {
                    worldIn.playEvent(1010, pos, 0);
                    //some coords to spawn the item entity
                    double d0 = (double) (worldIn.rand.nextFloat() * 0.7F) + (double) 0.15F;
                    double d1 = (double) (worldIn.rand.nextFloat() * 0.7F) + (double) 0.060000002F + 0.6D;
                    double d2 = (double) (worldIn.rand.nextFloat() * 0.7F) + (double) 0.15F;
                    ItemStack itemstack1 = blockState.getBlock().asItem().getDefaultInstance(); //<---- THAT IS WHERE I GET THE ERROR
                    ItemEntity itementity = new ItemEntity(worldIn, (double) pos.getX() + d0, (double) pos.getY() + d1, (double) pos.getZ() + d2, itemstack1);
                    itementity.setDefaultPickupDelay();
                    worldIn.addEntity(itementity); //this should spawn the item entity - works fine in singleplayer but not on servers
                    frameTileEntity.clear(); //resets my tile entity
                }
            }
        }
    }

It works fine in singleplayer, but when I tried it on a local server, it crashes. I get the following error: "java.lang.NoSuchMethodError: net.minecraft.item.Item.func_190903_i()Lnet/minecraft/item/ItemStack;". This "func_190903_i()" has to be the "getDefaultInstance()"-method, it is annotated as @OnlyIn(Dist.CLIENT) and I guess that's the reason why it does not work on servers. Now my question: How do I get it to work on servers?

Sorry if this is dumb, I'm pretty new and inexperienced...

Regards, Manu

 

In case you need the complete crash report: https://pastebin.com/hAa3Mcfz

[Budschie]

Hello PianoManu.

To me, it seems, that you could just remove the call on both sides,

and it should work fine.

I've never used the "getDefaultInstance"-method before, so I could be wrong.

[Beethoven92]

Why you use this to get and itemStack?

ItemStack itemstack1 = blockState.getBlock().asItem().getDefaultInstance(); //<---- THAT IS WHERE I GET THE ERROR
                    

I think you just need to create an ItemStack with new ItemStack(blockstate.getBlock().asItem())

[Draco18s]

I'm pretty sure new ItemStack(blockstate.getBlock()) is sufficient. Last I checked, the ItemStack class has a constructor that will do the block -> item conversion for you.

[PianoManu]

Thanks to you both @Beethoven92 and @Draco18s. That fixed my problem and helped a lot!