Jump to content

[Solved]Make a block affected by Efficiency


AndrewSherman

Recommended Posts

Hi, I was just wondering if there was a way to make a block affected by the efficiency enchantment.

 

I thought that setting Material.ground would make this work but apparently not...thanks for the help!

If you want picks to be effective, I believe you rather need Material.rock

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

Hi, I was just wondering if there was a way to make a block affected by the efficiency enchantment.

 

I thought that setting Material.ground would make this work but apparently not...thanks for the help!

If you want picks to be effective, I believe you rather need Material.rock

 

Unless you want it to be efficiency on shovels that makes it go.

 

Material.wood for axes, Material.rock or Material.iron for picks, and Material.ground for shovels.

If you can enchant shears, you would use Material.leaves for those.

So, what would happen if I did push that shiny red button over there? ... Really? ... Can I try it? ... Damn.

Link to comment
Share on other sites

Yeah, that's not actually working!

 

I'm using this as the constructor:

protected BlockGraveDirt(int par1)
{
      super(par1, Material.ground);        
}

 

And with a (vanilla) efficiency shovel it doesn't make a difference...

 

(Actually, it doesn't matter what I use to dig it, it always takes the same time to break!)

 

 

Link to comment
Share on other sites

Yeah, that's not actually working!

 

I'm using this as the constructor:

protected BlockGraveDirt(int par1)
{
      super(par1, Material.ground);        
}

 

And with a (vanilla) efficiency shovel it doesn't make a difference...

 

(Actually, it doesn't matter what I use to dig it, it always takes the same time to break!)

Um, out of curiosity, why is your constructor protected?

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

Oh, I don't know lol...bit weird... I think I extended block dirt at one point to see  if that would help with anything...not sure if that would've done it or if it's just my own stupidity!

 

Making it public still didn't change anything though by the way!

Meh, I had a feeling it wasn't getting called correctly (and so didn't register your material type.) Ah well.

 

Unfortunately I don't have my Eclipse up right now, so I'll just ask to make quite certain that efficiency isn't having any effect? After all, dirt gets mined quickly. I have a nasty feeling, though, that Minecraft has "if dirt" hardcoded rather than "if material is ground."

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

And with a (vanilla) efficiency shovel it doesn't make a difference...

 

(Actually, it doesn't matter what I use to dig it, it always takes the same time to break!)

Okay, I get your point. I've got Eclipse up now, researching...

 

...And it looks like the material doesn't matter. What *does* matter is ItemSpade.blocksEffectiveAgainst, which is static/final. Which means that you'll have to override ItemSpade. Rather silly. It seems there should be a Forge hook for this. (Unless there already is and I'm looking over it...)

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

I don't want to sound like a total noob but is a forge hook just a line of code in a base file that can be accessed by anyone to edit parts of the base file remotely (:. Reducing likelihood of compatibility errors) or is it something else entirely?

No, it's more like an event that you handle. I think. I haven't been using them much.

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

A forge hook is a piece of code in forge that allows you to do things, like efficiency shovels working on your block.

 

If you look in the file you would have to modify to make a function work, the forge hooks are at the bottom of the file, under a comment line that says "BEGIN FORGE PATCHES".

 

The also may be a way to register your block through the MinecraftForge files themselves.

So, what would happen if I did push that shiny red button over there? ... Really? ... Can I try it? ... Damn.

Link to comment
Share on other sites

/**
    * Register a block to be harvested by a tool class.  This is the metadata
    * sensitive version, use it if your blocks are using metadata variants.
    * By default, this sets the block class as effective against that type.
    *
    * @param block The block to register.
    * @param metadata The metadata for the block subtype.
    * @param toolClass The tool class to register as able to remove this block.
    *                  You may register the same block multiple times with different tool
    *                  classes, if multiple tool types can be used to harvest this block.
    * @param harvestLevel The minimum tool harvest level required to successfully
    * harvest the block.
    * @see MinecraftForge#setToolClass for details on tool classes.
    */
   public static void setBlockHarvestLevel(Block block, int metadata, String toolClass, int harvestLevel)
   {
       List key = Arrays.asList(block, metadata, toolClass);
       ForgeHooks.toolHarvestLevels.put(key, harvestLevel);
       ForgeHooks.toolEffectiveness.add(key);
   }

 

Just found this. Posting before looking but hey, I'll see if it's actually useful in a sec!

 

Ok, yes it's useful and yes it works!

 

I know what to look out for in the future now, thanks everyone for you help!

Link to comment
Share on other sites

/**
    * Register a block to be harvested by a tool class.  This is the metadata
    * sensitive version, use it if your blocks are using metadata variants.
    * By default, this sets the block class as effective against that type.
    *
    * @param block The block to register.
    * @param metadata The metadata for the block subtype.
    * @param toolClass The tool class to register as able to remove this block.
    *                  You may register the same block multiple times with different tool
    *                  classes, if multiple tool types can be used to harvest this block.
    * @param harvestLevel The minimum tool harvest level required to successfully
    * harvest the block.
    * @see MinecraftForge#setToolClass for details on tool classes.
    */
   public static void setBlockHarvestLevel(Block block, int metadata, String toolClass, int harvestLevel)
   {
       List key = Arrays.asList(block, metadata, toolClass);
       ForgeHooks.toolHarvestLevels.put(key, harvestLevel);
       ForgeHooks.toolEffectiveness.add(key);
   }

 

Just found this. Posting before looking but hey, I'll see if it's actually useful in a sec!

 

Ok, yes it's useful and yes it works!

 

I know what to look out for in the future now, thanks everyone for you help!

Dangit, I saw that, but I assumed it was for tool strength not type... misleading function name.

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.