Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16.3] [Solved] PlayerContainerEvent.Open not fired for Player's Inventory


Recommended Posts

I'm trying to attach a listener to the Player Inventory, to do something when the Player change an ItemStack inside a slot.
To do this I'm adding the listeners to the container that is opened using the PlayerContainerEvent.Open event.
This works for basically any container, except the one I want, which is the Player Container (more specifically the Hotbar and Player Inventory).

 

This is what I've done
 

@SubscribeEvent
public static void onInventoryOpen(final PlayerContainerEvent.Open event) {
  Container container = event.getContainer();
  if(!event.isCanceled() && (container instanceof PlayerContainer ||
      	container instanceof CreativeScreen.CreativeContainer)) {
            container.addListener(new BundleContainerListener());
  }
}

So I'm checking if the Container that has been opened is a PlayerContainer or a CreativeContainer (because PlayerContainer is just the Survival Inventory and I want this listener to work in creative mode too). If it is I then add my listener to the Container, from which I'm able to do whatever I want

public class BundleContainerListener implements IContainerListener {

    @Override
    public void sendAllContents(Container containerToSend, NonNullList<ItemStack> itemsList) {

    }

    @Override
    public void sendSlotContents(Container containerToSend, int slotInd, ItemStack stack) {
        System.out.println("CONTAINER: " + containerToSend + " - SLOT: " + slotInd + " - STACK: " + stack);
    }

    @Override
    public void sendWindowProperty(Container containerIn, int varToUpdate, int newValue) {

    }
}

If I open a Chest and set a breakpoint at the beggining of the onInventoryOpen event, the breakpoint gets hit. However if I open the Player inventory it doesn't.
The interesting part is that the PlayerContainerEvent.Close event gets called. So if I change the onInventoryOpen function to this

@SubscribeEvent
public static void onInventoryOpen(final PlayerContainerEvent.Close event) {
  Container container = event.getContainer();
  if(!event.isCanceled() && (container instanceof PlayerContainer ||
      	container instanceof CreativeScreen.CreativeContainer)) {
            container.addListener(new BundleContainerListener());
  }
}

and open the Player Inventory, the event gets called and the listener added as well. So when I reopen the Player Inventory, the code from the Listener gets called. But this requires the Player to open and close the Inventory the first time, which of course is something I want to avoid. 
Any idea on why the Open event doesn't gets called for Player Inventory, but the Close one does?
Also, since I don't need the other two methods from the listener, is it fine to leave them as empty or should I call something in the container class? I didn't see any issue, but I want to know just to make things right
 

Edited by JimiIT92
solved

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to post
Share on other sites

The server has no idea whether or not you are looking at your inventory. The PlayerContainer is always open, unless you are looking at a different container (e.g. a chest).

If you want to modify the player container somehow, do it in PlayerLoggedInEvent.

The creative GUI is entirely client side, the client simply sends a packet saying "please spawn this stack in this slot". The server still just has the PlayerContainer (the normal inventory) open.

Link to post
Share on other sites

Ok, but how can I do that? Because I can't just do this
 

@SubscribeEvent
public static void onPlayerLoggedIn(final PlayerEvent.PlayerLoggedInEvent event) {
  event.getPlayer().container = new CustomContainer();
}

since the container property is final.

I could also just add the listener here, using the addListener, but I noticed that the code from my listener is executed after the code from the existing listeners. What I'm trying to achieve is to intercept when the player changes an ItemStack into a slot and cancel the event or do some stuff accordingly. But when the code from my listener runs, the slot content has already been changed, so I can't determine what was in the slot and what I'm trying to put inside. Is there a way to set a priority for listeners, so my listener will run before any other?

 

EDIT: Figured out I have to change the value for openContainer. By doing this I can now set a custom implementation of the PlayerContainer. Thank you for the help, but I'm still curious about the listeners priority, and if there is such a way to do it (to avoid using a custom implementation)

Edited by JimiIT92
solved

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to post
Share on other sites
5 hours ago, diesieben07 said:

The listeners are just a list, you can prepend to it as well, using some reflection hackery.

Yes, I know they are just a list. What I want to avoid is using reflection to prepend my listener 😅

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • I just got started with modding and I'm trying to create one. I did everything that the Forge Documentation said, ran the Eclipse IDE launch configurations and after trying to run   gradlew build after 46% of the build I got an error:   > Task :compileJava FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileJava'. > Could not resolve all files for configuration ':compileClasspath'. > Could not find net.minecraftforge:forge:1.16.5-36.1.0_mapped_official_1.16.5. Searched in the following locations: - https://files.minecraftforge.net/maven/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.module - https://files.minecraftforge.net/maven/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.pom - https://files.minecraftforge.net/maven/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.jar - file:/C:/Users/Zalman/.gradle/caches/forge_gradle/bundeled_repo/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.pom - file:/C:/Users/Zalman/.gradle/caches/forge_gradle/bundeled_repo/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.jar - https://libraries.minecraft.net/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.jar - https://repo.maven.apache.org/maven2/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.pom Required by: project : * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/6.8.1/userguide/command_line_interface.html#sec:command_line_warnings BUILD FAILED in 35s 1 actionable task: 1 executed I tried deleting the gradle cache (in C:\Users\username\.gradle) and building again, nothing. Tried deleting the whole project, putting the forge files back and generating the launch configurations again, still nothing. I'd appreciate some support with this.
    • Ugh, I posted in the wrong category, sorry.
    • I just got started with modding and I'm trying to create one. I did everything that the Forge Documentation said, ran the Eclipse IDE launch configurations and after trying to run   gradlew build after 46% of the build I got an error:   > Task :compileJava FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileJava'. > Could not resolve all files for configuration ':compileClasspath'. > Could not find net.minecraftforge:forge:1.16.5-36.1.0_mapped_official_1.16.5. Searched in the following locations: - https://files.minecraftforge.net/maven/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.module - https://files.minecraftforge.net/maven/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.pom - https://files.minecraftforge.net/maven/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.jar - file:/C:/Users/Zalman/.gradle/caches/forge_gradle/bundeled_repo/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.pom - file:/C:/Users/Zalman/.gradle/caches/forge_gradle/bundeled_repo/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.jar - https://libraries.minecraft.net/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.jar - https://repo.maven.apache.org/maven2/net/minecraftforge/forge/1.16.5-36.1.0_mapped_official_1.16.5/forge-1.16.5-36.1.0_mapped_official_1.16.5.pom Required by: project : * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/6.8.1/userguide/command_line_interface.html#sec:command_line_warnings BUILD FAILED in 35s 1 actionable task: 1 executed I tried deleting the gradle cache (in C:\Users\username\.gradle) and building again, nothing. Tried deleting the whole project, putting the forge files back and generating the launch configurations again, still nothing. I'd appreciate some support with this.  
    • This is the launcher log, it's the only place where I see any reference to an error.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.