Jump to content

Strange error


DELTA_12

Recommended Posts

Im trying to make method that checks if desired structure is built near it and return true/false but im still getting it like 4th block didnt existed, i mean it cheks if ID is 181 and return true/false and it is returning false even if i know 101% IT IS block with that id.

Code (BEWARE 80+LINES):

public boolean checkIfExists(World world, int i, int j1, int k) {
	int j = j1 + 1;
	System.out.println("coords: " + i + " " + j + " " + k);
//formatter:off
	if (world.getBlockId(i + 0, j + 2, k + 1) == 181 &&

	world.getBlockId(i + 0, j + 2, k + 2) == 181 &&
	 world.getBlockId(i + 0, j + 2, k + 3) == 181 &&
	  world.getBlockId(i + 0, j + 2, k + 4) == 181 &&
	   world.getBlockId(i + 1, j + 2, k + 2) == 181 &&
	    world.getBlockId(i + 1, j + 2, k + 3) == 181 &&
	     world.getBlockId(i + 1, j + 2, k + 4) == 181 &&
	      world.getBlockId(i + 1, j + 2, k + 5) == 181 &&
	       world.getBlockId(i + 1, j + 3, k + 0) == 181 &&
	        world.getBlockId(i + 1, j + 3, k + 1) == 181 &&
	         world.getBlockId(i + 2, j + 0, k + 2) == 181 &&
	          world.getBlockId(i + 2, j + 1, k + 5) == 181 &&
	           world.getBlockId(i + 2, j + 1, k + 6) == 181 &&
	            world.getBlockId(i + 2, j + 1, k + 7) == 181 &&
	             world.getBlockId(i + 2, j + 1, k +  == 181 &&
	              world.getBlockId(i + 2, j + 2, k + 1) == 182 &&
	               world.getBlockId(i + 2, j + 2, k + 2) == 181 &&
	                world.getBlockId(i + 2, j + 2, k + 3) == 181 &&
	                 world.getBlockId(i + 2, j + 2, k + 4) == 181 &&
	                  world.getBlockId(i + 2, j + 2, k + 5) == 181 &&
	                   world.getBlockId(i + 2, j + 2, k +  == Block.glass.blockID &&
	                    world.getBlockId(i + 2, j + 2, k + 9) == Block.glass.blockID &&
	                     world.getBlockId(i + 2, j + 3, k + 0) == 181 &&
	                      world.getBlockId(i + 2, j + 3, k + 1) == 181 &&
	                       world.getBlockId(i + 2, j + 3, k + 2) == 181 &&
	                        world.getBlockId(i + 2, j + 3, k + 3) == 181 &&
	                         world.getBlockId(i + 2, j + 3, k + 4) == 181 &&
	                          world.getBlockId(i + 3, j + 0, k + 5) == 181 &&
	                           world.getBlockId(i + 3, j + 0, k + 6) == 181 &&
	                            world.getBlockId(i + 3, j + 0, k + 7) == 181 &&
	                             world.getBlockId(i + 3, j + 0, k +  == 181 &&
	                              world.getBlockId(i + 3, j + 1, k + 1) == 181 &&
	                               world.getBlockId(i + 3, j + 1, k + 2) == 181 &&
	                                world.getBlockId(i + 3, j + 1, k + 3) == 181 &&
	                                 world.getBlockId(i + 3, j + 1, k + 4) == 181 &&
	                                  world.getBlockId(i + 3, j + 1, k + 5) == 181 &&
	                                   world.getBlockId(i + 3, j + 1, k + 6) == Block.stairsWoodOak.blockID &&
	                                    world.getBlockId(i + 3, j + 1, k +  == 183 &&
	                                     world.getBlockId(i + 3, j + 1, k + 9) == 181 &&
	                                      world.getBlockId(i + 3, j + 2, k + 1) == 181 &&
	                                       world.getBlockId(i + 3, j + 2, k + 2) == 181 &&
	                                        world.getBlockId(i + 3, j + 2, k + 3) == 181 &&
	                                         world.getBlockId(i + 3, j + 2, k + 4) == 181 &&
	                                          world.getBlockId(i + 3, j + 2, k + 5) == 181 &&
	                                           world.getBlockId(i + 3, j + 2, k + 10) == Block.glass.blockID &&
	                                            world.getBlockId(i + 3, j + 3, k + 0) == 182 &&
	                                             world.getBlockId(i + 3, j + 3, k + 1) == 181 &&
	                                              world.getBlockId(i + 3, j + 3, k + 2) == 181 &&
	                                               world.getBlockId(i + 3, j + 3, k + 3) == 181 &&
	                                                world.getBlockId(i + 3, j + 3, k + 4) == 181 &&
	                                                 world.getBlockId(i + 3, j + 3, k + 5) == 181 && 
	                                                  world.getBlockId(i + 3, j + 3, k +  == Block.glass.blockID &&
	                                                   world.getBlockId(i + 3, j + 3, k + 9) == Block.glass.blockID &&
	                                                    world.getBlockId(i + 3, j + 4, k + 0) == 181 &&
	                                                     world.getBlockId(i + 3, j + 4, k + 1) == 181 &&
	                                                      world.getBlockId(i + 4, j + 0, k + 2) == 181 &&
	                                                       world.getBlockId(i + 4, j + 1, k + 5) == 181 &&
	                                                        world.getBlockId(i + 4, j + 1, k + 6) == 181 &&
	                                                         world.getBlockId(i + 4, j + 1, k + 7) == 181 &&
	                                                          world.getBlockId(i + 4, j + 1, k +  == 181 &&
	                                                           world.getBlockId(i + 4, j + 2, k + 1) == 182 &&
	                                                            world.getBlockId(i + 4, j + 2, k + 2) == 181 &&
	                                                             world.getBlockId(i + 4, j + 2, k + 3) == 181 &&
	                                                              world.getBlockId(i + 4, j + 2, k + 4) == 181 &&
	                                                               world.getBlockId(i + 4, j + 2, k + 5) == 181 &&
	                                                                world.getBlockId(i + 4, j + 2, k +  == Block.glass.blockID &&
	                                                                 world.getBlockId(i + 4, j + 2, k + 9) == Block.glass.blockID &&
	                                                                  world.getBlockId(i + 4, j + 3, k + 0) == 181 &&
	                                                                   world.getBlockId(i + 4, j + 3, k + 1) == 181 &&
	                                                                    world.getBlockId(i + 4, j + 3, k + 2) == 181 &&
	                                                                     world.getBlockId(i + 4, j + 3, k + 3) == 181 &&
	                                                                      world.getBlockId(i + 4, j + 3, k + 4) == 181 &&
	                                                                       world.getBlockId(i + 5, j + 2, k + 2) == 181 &&
	                                                                        world.getBlockId(i + 5, j + 2, k + 3) == 181 &&
	                                                                         world.getBlockId(i + 5, j + 2, k + 4) == 181 &&
	                                                                          world.getBlockId(i + 5, j + 2, k + 5) == 181 &&
	                                                                           world.getBlockId(i + 5, j + 3, k + 0) == 181 &&
	                                                                            world.getBlockId(i + 5, j + 3, k + 1) == 181 &&
	                                                                             world.getBlockId(i + 6, j + 2, k + 1) == 181 &&
	                                                                              world.getBlockId(i + 6, j + 2, k + 2) == 181 &&
	                                                                               world.getBlockId(i + 6, j + 2, k + 3) == 181 &&
	                                                                                world.getBlockId(i + 6, j + 2, k + 4) == 181) {
		System.out.println("DONE=====================");
		return true;
	} else
		return false;

Link to comment
Share on other sites

Dear god, please please please learn how to use loops. I don't know what shape you are trying to make, but I guarantee that you can do in a couple loops whatever it is this mess is trying to do.

 

Otherwise, don't hard-code in that ID. If, say, you are trying to make a frame using your block, let's call it modBlock in your base mod class called MyMod, even if you declare the ID to be 181, instead compare the world.getBlockID to MyMod.modBlock.blockID, similar to how you reference Block.glass.blockID. This ensures that you are comparing to the right thing.

Read my thoughts on my summer mod work and tell me what you think!

http://www.minecraftforge.net/forum/index.php/topic,8396.0.html

 

I absolutely love her when she smiles

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.