[SOLVED][1.16.3] Problems with coloring Blocks

[IcedReaper 0]

Hi,

 

I'm trying to dynamically color blocks (Metal Blocks).

It works fine for items (ingots, dust, etc) but it sadly doesn't work for blocks.

I'm having these events:

    @SubscribeEvent
    public static void colorItems(final ColorHandlerEvent.Item e) {
        ItemColors colors = e.getItemColors();

        ModuleCore.materials.forEach((materialName, materialDefinition) -> {
            materialDefinition.parts.forEach((part, item) -> {
                if(item instanceof BaseItem) {
                    Item i = (Item) item;

                    // This works as it's supposed to be.
                    colors.register((stack, tintIndex) -> materialDefinition.color.getRGB(), i);
                }
                else if(item instanceof MaterialBlock) {
                    Item i = ((MaterialBlock) item).item;

                    // These two were tests to see if I had to color the Blocks items instead of the block. But it didn't do anything.
                    colors.register((stack, tintIndex) -> materialDefinition.color.getRGB(), Item.getItemFromBlock((MaterialBlock) item));
                    colors.register((stack, tintIndex) -> materialDefinition.color.getRGB(), i);
                }
            });
        });
    }

    @SubscribeEvent
    public static void colorBlocks(final ColorHandlerEvent.Block e) {
        BlockColors colors = e.getBlockColors();

        ModuleCore.materials.forEach((materialName, materialDefinition) -> {
            if(materialDefinition.parts.containsKey(Part.BLOCK)) {
                // The code is executed but the block isn't colored.
                colors.register((state, worldIn, pos, tintIndex) -> materialDefinition.color.getRGB(), (Block) materialDefinition.parts.get(Part.BLOCK));
            }
        });
    }

When I add a Logger.info in the if-condition I can see that the method is called and executed for every material I have defined to have a Block.

The coloring of the BaseItems works fine, but all tries to color the Block doesn't seem to work.

 

I looked at the Documentation (which seems to be outdated),

I found this forum thread

I tried several other approaches, but all tries didn't seem to work.

I tried to use an alpha of 0 instead of 255, but it didn't had any influence too.

 

I can see in the Debugger that the colors are being a added (See attached screenshot of the Debugging Information)

 

Does anyone know what am I doing wrong and what do I have to change?

 

 

You can see the complete Code here (https://github.com/IcedReaper/IcedResources/blob/main/src/main/java/com/icedreaper/icedresources/handlers/ColorEventHandler.java) (I currently have the code to color the blocks commented out and instead implemented a way to create new colored images for the blocks, but this shouldn't be the way I'd imagine ;))

 

Thanks in Advance,

IcedReaper

Edited October 25, 2020 by IcedReaper
marked as solved

[ChampionAsh5357 160]

That's simple enough. The models you are registering doesn't have an assigned tint index for the specific face. For each face you want to be tinted, you need to set the tintIndex to the specific index being checked within the event itself (or any number if you're not checking for a specific one, most people go with 0). cube_all does not have a tint index specified for any of it's faces.

[IcedReaper 0]

Thanks for the hint.

As I'm not that experienced with the model definitions I had to look some up, but I got it to work.

 

I now use the following model (if someone has the same problem)

{
  "parent": "block/block",
  "textures": {
    "all": "icedresources:blocks/base_block"
  },
  "elements": [
    {
      "from": [ 0, 0, 0 ],
      "to":   [ 16, 16, 16 ],
      "faces": {
        "north": { "uv": [ 0, 0, 16, 16 ], "texture": "#all", "tintindex": 0 },
        "east":  { "uv": [ 0, 0, 16, 16 ], "texture": "#all", "tintindex": 0 },
        "south": { "uv": [ 0, 0, 16, 16 ], "texture": "#all", "tintindex": 0 },
        "west":  { "uv": [ 0, 0, 16, 16 ], "texture": "#all", "tintindex": 0 },
        "up":    { "uv": [ 0, 0, 16, 16 ], "texture": "#all", "tintindex": 0 },
        "down":  { "uv": [ 0, 0, 16, 16 ], "texture": "#all", "tintindex": 0 }
      }
    }
  ]
}

 

Just change the block Texture and you can use it as a template/parent in your flat blocks you want to tint.

 

And your specific block.json files can then be as slim as:

{
  "parent": "icedresources:block/base_block"
}