Jump to content

Custom Boots not destroyed on reaching Damage Value.


Xwaffle

Recommended Posts

Title says it all. I've got custom boots that add Speed to player. The boots take damage from walking. Once the boots reach there damage value they don't seem to be getting removed from my armor slot. Another thing is that --item.stacksize does not work. I've set up some chat messages to tell me what itemstack equals and what the damage is.

 

 

b750ec7606337874dddaeca864746ed2.png

 

 

 

Here is the class. It should be all you need.

 

 

d76ff5442eeac7e3c408f41dcaeec92f.png

 

 

 

 

Link to comment
Share on other sites

I tried using that if statement but that's not even a valid statement. so I tried a bit of what you wrote

if (boots.stackSize <= 0) {
							boots.stackSize = boots.getItem().getContainerItemStack(boots).stackSize;

						}

 

That does not work. MAde me crash actually.

 

 

Link to comment
Share on other sites

stuff that popped into my head while reading your code:

 

1. are you planning on using this on smp? (if you are, you're going to get a lot of bugs)

2. is your tick handler running client side or server side?

3. you don't need to use "getPlayerCoordinates()" to get a player's coordinates

4. simply casting the coordinates to integers will get inaccurate results

5. you don't need a tick handler for this

Link to comment
Share on other sites

stuff that popped into my head while reading your code:

 

1. are you planning on using this on smp? (if you are, you're going to get a lot of bugs)

2. is your tick handler running client side or server side?

3. you don't need to use "getPlayerCoordinates()" to get a player's coordinates

4. simply casting the coordinates to integers will get inaccurate results

5. you don't need a tick handler for this

True. I hadn't looked at his code initially. Re #5, you should instead be overriding onArmorTickUpdate() in your item class.

BEWARE OF GOD

---

Co-author of Pentachoron Labs' SBFP Tech.

Link to comment
Share on other sites

stuff that popped into my head while reading your code:

 

1. are you planning on using this on smp? (if you are, you're going to get a lot of bugs)

2. is your tick handler running client side or server side?

3. you don't need to use "getPlayerCoordinates()" to get a player's coordinates

4. simply casting the coordinates to integers will get inaccurate results

5. you don't need a tick handler for this

 

 

Well, thanks a bunch for responding!

 

1. Server works perfectly fine actually that would be because of number 2.

2. Yes it is server side. You can not add potion effects client side. Sadly :-/

3. Ideaas?

4. It works though.

5. Hmmm I don't know how else to do it.

 

 

Link to comment
Share on other sites

You'd probably be better off using player.inventory.decrStackSize().

 

I tried doing this but I was not to sure on what I should put in for my paramaters I tried player.inventory.decrStackSize(boots, 1). um the paramters asked ar supposed to be ints so I could not use boots which is the slot of armor slot boots I casted that. I just put 1 for no reason ;P so my question is what should I put for my slot ID number or par1 it says in the declaration.

Link to comment
Share on other sites

stuff that popped into my head while reading your code:

 

1. are you planning on using this on smp? (if you are, you're going to get a lot of bugs)

2. is your tick handler running client side or server side?

3. you don't need to use "getPlayerCoordinates()" to get a player's coordinates

4. simply casting the coordinates to integers will get inaccurate results

5. you don't need a tick handler for this

 

 

Well, thanks a bunch for responding!

 

1. Server works perfectly fine actually that would be because of number 2.

2. Yes it is server side. You can not add potion effects client side. Sadly :-/

3. Ideaas?

4. It works though.

5. Hmmm I don't know how else to do it.

 

1. nope. since your values for bootLastX and bootLastZ are static, it's going to mess up once there are a lot of players. example:

 

player1 is at (0, 0) and stays there. his bootLastX will be 0 and bootLastZ will be 0. since he isn't moving, those shouldn't change.

 

then, player2 is at (5,5) and stays there as well. so his last x will become 5 and his last z will become 5. his last coordinates shouldn't change as well since he's standing still.

 

but since your bootLastX and bootLastZ are static, and due to player2 changing them to (5,5), the values of bootLastX and bootLastZ for player1 also becomes (5,5). so when your code checks to see if player1's moved or not, it will return true because he's at (0,0) while his last x and z are supposedly (5,5) when they should still be (0,0).

 

2. well, it's really supposed to be server side, but like i said, you don't need it.

3. just take out the "getPlayerCoordinates()" part. you can type "player.posX" or "player.posZ" instead so you won't have to unnecessarily call "getPlayerCoordinates()".

4. it works, but at certain coordinates, it will be inaccurate. example:

 

player.posX = 99.5D;

lastBootX = (int) player.posX;

 

lastBootX will become 99. so that'll work fine. but if posX is negative

 

player.posX = -99.5D;

lastBootX = (int) player.posX;

 

lastBootX will become -99 instead of -100. you can use this intead to make sure you get the right values

 

lastBootX = MathHelper.floor_double(player.posX);

 

5. like ObsequiousNewt said, you can us onArmorTickUpdate() in Item

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.