Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • Weird behaviour when trying to damage item on right click
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 0
Korall

Weird behaviour when trying to damage item on right click

By Korall, October 27, 2020 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

Korall    0

Korall

Korall    0

  • Tree Puncher
  • Korall
  • Members
  • 0
  • 10 posts
Posted October 27, 2020

I've come upon something I don't quite understand. I have a custom item where I use the onItemRightClick event. In the event, i modify the NBT tag values of the item, and this works without problem. However, whenever i try to change the items nbt value related to item damage (durability) or damage the item in some other way, it seems to be nullified. I was able to dance around this issue by assigning a damage value in another nbt value and then comparing the two in the setDamage function. So it seems to me like the onItemRightClick event records the damage value before being executed, and then sets it to the item afterwards, making the item have the same damage value regardless of what happened in the event.

 

So, why does this happen, and what is the "correct" way to damage the used itemStack during the onItemRightClick event? I did try to see how the flint and steel item does it, but I couldn't really find anything, since it extends the Item class, and the item class extends... something?

  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7696

diesieben07

diesieben07    7696

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7696
  • 56382 posts
Posted October 27, 2020

Show your code.

  • Quote

Share this post


Link to post
Share on other sites

Korall    0

Korall

Korall    0

  • Tree Puncher
  • Korall
  • Members
  • 0
  • 10 posts
Posted October 27, 2020 (edited)
24 minutes ago, diesieben07 said:

Show your code.

Okay, well... lets see here... the relevant things should be

 

    public ActionResult<ItemStack> useItem(World worldIn, PlayerEntity playerIn, Hand handIn, boolean canRepeat) {
      
      if(handIn == Hand.MAIN_HAND)
            offhandStack = playerIn.getHeldItem(Hand.OFF_HAND);
      else
            offhandStack = playerIn.getHeldItem(Hand.MAIN_HAND);

      if (canUseGunItem(heldStack, offhandStack)) {
        
        ShotItem shotItem = getLoadedShot(heldStack);
        if ((canShoot(heldStack, offhandStack, playerIn, worldIn.isRemote()) && shotItem != null)) {

          float pwr = getGunProperties().getPower();
          playerIn.addVelocity(mDir.x * 0.02 * pwr, 0.01f * pwr, mDir.z * 0.02 * pwr);

          if (!worldIn.isRemote()) {
                
                CompoundNBT tag = heldStack.getTag();

                tag.putInt("rounds", tag.getInt("rounds") - 1);
                
                attemptDamageGun(heldStack, 1);

                if(tag.getInt("rounds") == 0)
                  tag.putInt("shot_ID", -1);

                heldStack.setTag(tag);
                
                //Does some other stuff too, but its irrelevant for this post
              }
              return new ActionResult<>(ActionResultType.SUCCESS, heldStack);
            }

        return new ActionResult<>(ActionResultType.FAIL, heldStack);
      }
      

 

And the attemptDamageGun function:

 

    public void attemptDamageGun(ItemStack stack, int damage)
    {
        CompoundNBT tag = stack.getTag();

        double rand = Math.random();

        Map<Enchantment, Integer> enchantments = EnchantmentHelper.getEnchantments(stack);


        tag.putInt("gun_damage", tag.getInt("gun_damage") + damage);
        tag.putInt("gun_damage_tmp", tag.getInt("gun_damage"));

        stack.setTag(tag);
    }

 

Also the formatting is a bit odd.. il see if i can fix that

 

Now, I am certain that the attemptDamageGun function actually fires, and it does indeed work, just not without that "gun_damage_tmp" fix to compensate

Edited October 27, 2020 by Korall
  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7696

diesieben07

diesieben07    7696

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7696
  • 56382 posts
Posted October 27, 2020

So... which part of this does not work?

  • Quote

Share this post


Link to post
Share on other sites

Korall    0

Korall

Korall    0

  • Tree Puncher
  • Korall
  • Members
  • 0
  • 10 posts
Posted October 27, 2020
Just now, diesieben07 said:

So... which part of this does not work?

Well, this code works... sort of. However to actually damage the item, i need to temporarily put the "gun_damage_tmp" and then in the damageItem function make sure that the inputed damage and the temporary damage match. This seems like a rather hacky soloution, so i figured there must be a better way to damage the item during the right click event. Any changes made to the itemStacks damage during the event will be reset.

 

Also this is my damageItem override event

    @Override
    public void setDamage(ItemStack stack, int damage) {

        int tmpDmg = stack.getTag().getInt("gun_damage_tmp");




        //int nDamage = stack.getTag().getInt("gun_damage") + damage;
        int nDamage = damage;

        if(Math.abs(tmpDmg - damage) < 2 && damage < tmpDmg) {
            nDamage = tmpDmg;
            if(nDamage == 1)
                nDamage = 0;
        }

        stack.getTag().putInt("gun_damage", nDamage);


        if(nDamage >= this.getMaxDamage(stack)) {
            stack.shrink(1);
        }
        if(nDamage < 0)
            stack.getTag().putInt("gun_damage", 0);

        stack.getTag().putInt("gun_damage_tmp", stack.getTag().getInt("gun_damage"));

    }

 

And with that it works. But as previously stated, i find it weird that you cant damage an item during the right click event without it resetting

  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7696

diesieben07

diesieben07    7696

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7696
  • 56382 posts
Posted October 27, 2020

Why are you overriding setDamage anyways? MInecraft already has a way to set damage. Why are you making your own?

  • Quote

Share this post


Link to post
Share on other sites

Korall    0

Korall

Korall    0

  • Tree Puncher
  • Korall
  • Members
  • 0
  • 10 posts
Posted October 27, 2020
Just now, diesieben07 said:

Why are you overriding setDamage anyways? MInecraft already has a way to set damage. Why are you making your own?

Without me overriding it to compensate for this effect, any changes made to the damage during the right click event are nullified

  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7696

diesieben07

diesieben07    7696

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7696
  • 56382 posts
Posted October 27, 2020

Okay. Stupid question, maybe: You are in survival mode, right? Item damage is disabled in creative mode.

  • Quote

Share this post


Link to post
Share on other sites

Korall    0

Korall

Korall    0

  • Tree Puncher
  • Korall
  • Members
  • 0
  • 10 posts
Posted October 27, 2020 (edited)
15 minutes ago, diesieben07 said:

Okay. Stupid question, maybe: You are in survival mode, right? Item damage is disabled in creative mode.

Oh my god. I feel like an absolute idiot now, haha... :< . It works in survival. Therefore the conclusion that can be made is that the onRightClick event resets the item damage if you are in creative, instead of stopping it from happening.

 

Essentially, when right clicking this happens (in pseudo code):

onPlayerRightClickEvent(PlayerEntity player) {
  
  int itemDamage = player.getItem().getDamage()
    
    player.getItem().performRightClickEvent()
    
    if(player.isInCreative())
    	player.getItem().setDamage(itemDamage)

}

 

 

I though there was just a check for being in creative mode in the attemptDamageItem event or damageItem event. Thanks!

Edited October 27, 2020 by Korall
Clarification
  • Quote

Share this post


Link to post
Share on other sites

Draco18s    2414

Draco18s

Draco18s    2414

  • Reality Controller
  • Draco18s
  • Members
  • 2414
  • 15998 posts
Posted October 27, 2020 (edited)
38 minutes ago, Korall said:

Therefore the conclusion that can be made is that the onRightClick event resets the item damage if you are in creative, instead of stopping it from happening.

Not really no. Because there are other ways to damage an item and all of them are ignored in creative.

 

It happens here, in ItemStack#damageItem:

if (!entityIn.world.isRemote && (!(entityIn instanceof PlayerEntity) || !((PlayerEntity)entityIn).abilities.isCreativeMode)) {

If the player is in creative, the interior block (which actually applies the damage) is not run.

Edited October 27, 2020 by Draco18s
  • Like 1
  • Quote

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 0
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Beethoven92
      Error at load_registries event phase

      By Beethoven92 · Posted 6 minutes ago

      Apparently here: BlockList.tutorial_slab = new SlabBlock(Block.Properties.from(BlockList.tutorial_slab)).setRegistryName(location("tutorial_slab")) your BlockList.tutorial_slab block is null when the block registration event is fired..i suggest you use deferred register to manage your registry entries
    • BeardlessBrady
      [1.16.4] Tile Registration

      By BeardlessBrady · Posted 12 minutes ago

      Ah there ya go! Thanks.
    • Beethoven92
      [1.16.4] Tile Registration

      By Beethoven92 · Posted 15 minutes ago

      public VendingTile(TileEntityType<?> tileEntityTypeIn) You don't need an argument in the constructor of your tile entity as in this case is not used since you are passing the TileEntityType to the super class: super(CommonRegistry.TILE_VENDING.get());  
    • BeardlessBrady
      [1.16.4] Tile Registration

      By BeardlessBrady · Posted 25 minutes ago

      Hello, I am having issues registering my tile entity. Here is my code as well as a link to the code in my github. The IDE is complaining that 'TileEntityType.Builder.create' has invalid arguments   // Tiles public static final DeferredRegister<TileEntityType<?>> TILE_ENTITY_TYPES = DeferredRegister.create(ForgeRegistries.TILE_ENTITIES, GOCurrency.MODID); public static final RegistryObject<TileEntityType<VendingTile>> TILE_VENDING = TILE_ENTITY_TYPES.register("vending_te", () -> TileEntityType.Builder.create(VendingTile::new, BLOCK_VENDING.get()).build(null));   https://github.com/Beardlessbrady/Currency-Mod/blob/95230ca4ee2d290b3e5f3ef81810a27f73137625/src/main/java/com/beardlessbrady/gocurrency/handlers/CommonRegistry.java#L42-L43
    • ThisIsNotOriginal
      Error at load_registries event phase

      By ThisIsNotOriginal · Posted 1 hour ago

      The pastebin for the log and Registry Event is posted below this text.   https://pastebin.com/KEzJvRgG https://pastebin.com/VUrXR94k
  • Topics

    • ThisIsNotOriginal
      1
      Error at load_registries event phase

      By ThisIsNotOriginal
      Started 1 hour ago

    • BeardlessBrady
      2
      [1.16.4] Tile Registration

      By BeardlessBrady
      Started 26 minutes ago

    • PlasmaPig13
      1
      The game crashed whilst rendering overlay Error: java.lang.NullPointerException: Rendering overlay Exit Code: -1

      By PlasmaPig13
      Started 1 hour ago

    • EnderiumSmith
      3
      The vanilla tag system isnt suitable for ore dictionary

      By EnderiumSmith
      Started 15 hours ago

    • Ilikecheese
      0
      forge 1.16.5 wont show up

      By Ilikecheese
      Started 1 hour ago

  • Who's Online (See full list)

    • Microcellule
    • Milk_Shak3s
    • Beethoven92
    • AstroTurffx
    • Jeldrik
    • Azurelmao
    • ichttt
    • Deadlocked47
    • BeardlessBrady
    • ThisIsNotOriginal
    • ehbean
    • That_Tallone
    • squidlex
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • Weird behaviour when trying to damage item on right click
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community