Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.16.x] Packet Invalid Message
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
urbanxx001

[1.16.x] Packet Invalid Message

By urbanxx001, October 27, 2020 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

urbanxx001    8

urbanxx001

urbanxx001    8

  • Creeper Killer
  • urbanxx001
  • Members
  • 8
  • 139 posts
Posted October 27, 2020

I have a button in my screen class to send a packet to the container in order to update the inventory (client to server), according to this. Opening the gui and clicking the button in-game, I receive an invalid message error that originates from:

PacketHandler.CHANNEL.send(PacketDistributor.ALL.noArg(), new CapCompContainer(ModContainerTypes.MULTI_9X3.get(), containerID, containerInd, senderInv, 3));

According to this the issue could stem from registration, but I ensured that the packet is registered in FMLCommonSetup and specified the network direction PLAY_TO_SERVER.

 

Classes:

PacketHandler

PacketUpdateContainer

CapCompContainer

CapCompScreen

  • Quote

Share this post


Link to post
Share on other sites

Danebi    26

Danebi

Danebi    26

  • Diamond Finder
  • Danebi
  • Members
  • 26
  • 432 posts
Posted October 27, 2020 (edited)

When do you call the register method?

Edited October 27, 2020 by Danebi
  • Quote

Share this post


Link to post
Share on other sites

urbanxx001    8

urbanxx001

urbanxx001    8

  • Creeper Killer
  • urbanxx001
  • Members
  • 8
  • 139 posts
Posted October 27, 2020 (edited)

It's called in:

private static void commonSetup(FMLCommonSetupEvent event) {
    DeferredWorkQueue.runLater(() -> {
        CapCompScreen.register();
        PacketHandler.register();
    });
}

which in turn is called in the Common Proxy class as:

final IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();
modEventBus.addListener(CommonProxy::commonSetup);
Edited October 27, 2020 by urbanxx001
  • Quote

Share this post


Link to post
Share on other sites

poopoodice    113

poopoodice

poopoodice    113

  • Dragon Slayer
  • poopoodice
  • Members
  • 113
  • 896 posts
Posted October 27, 2020 (edited)

I believe this is sending the packet to everyone

PacketDistributor.ALL.noArg()

You can simply use SimpleChannel#sendToServer()

Edited October 27, 2020 by poopoodice
  • Thanks 1
  • Quote

Share this post


Link to post
Share on other sites

urbanxx001    8

urbanxx001

urbanxx001    8

  • Creeper Killer
  • urbanxx001
  • Members
  • 8
  • 139 posts
Posted October 27, 2020 (edited)

Ah that makes sense. I replaced it with that, but receive the same error. Hopefully it's not an issue on the receiving end (container).

Edited October 27, 2020 by urbanxx001
  • Quote

Share this post


Link to post
Share on other sites

poopoodice    113

poopoodice

poopoodice    113

  • Dragon Slayer
  • poopoodice
  • Members
  • 113
  • 896 posts
Posted October 27, 2020

What's the reason of you sending another packet in PacketUpdateContainer.handle ?

Also in encode you've written a int array into the buffer, but then you read two ints out of the buffer which won't work because the first int will be the length of the array.

  • Thanks 1
  • Quote

Share this post


Link to post
Share on other sites

urbanxx001    8

urbanxx001

urbanxx001    8

  • Creeper Killer
  • urbanxx001
  • Members
  • 8
  • 139 posts
Posted October 27, 2020 (edited)

Right it's being sent in two places, idk why I sent a second one in PacketUpdateContainer.  I'll fix the argument mismatch as well. Thanks for catching those.

Edited October 27, 2020 by urbanxx001
  • Quote

Share this post


Link to post
Share on other sites

urbanxx001    8

urbanxx001

urbanxx001    8

  • Creeper Killer
  • urbanxx001
  • Members
  • 8
  • 139 posts
Posted October 30, 2020 (edited)

Alright I've redone a bit and it's working as long as the block position is given manually in the packet handler. I've been trying to pass it from the tile entity => container => screen instead, however something strange occurs in the container. It receives the correct te and block position, but then a second te with null position is detected. Classes below.

 

ModBlock

ModTileEntity

ModContainer

Edited October 30, 2020 by urbanxx001
  • Quote

Share this post


Link to post
Share on other sites

vemerion    56

vemerion

vemerion    56

  • Creeper Killer
  • vemerion
  • Members
  • 56
  • 220 posts
Posted October 30, 2020
35 minutes ago, urbanxx001 said:

It receives the correct te and block position, but then a second te with null position is detected. Classes below.

From what I can see, you are not using the BlockPos you are sending NetworkHooks.openGui(), and thus the 'dummy' ModTileEntity the container creates on the client will have a null BlockPos.

 

As a side note, I would encourage you to stay away from LockableLootTileEntity and IInventory, and instead use the recommended forge alternative IItemHandler.

  • Quote

Share this post


Link to post
Share on other sites

urbanxx001    8

urbanxx001

urbanxx001    8

  • Creeper Killer
  • urbanxx001
  • Members
  • 8
  • 139 posts
Posted October 30, 2020 (edited)
2 hours ago, vemerion said:

I would encourage you to stay away from LockableLootTileEntity and IInventory, and instead use the recommended forge alternative IItemHandler.

I'll definitely consider IItemHandler down the line, thanks.

With openGui() I was passing the block pos:

NetworkHooks.openGui((ServerPlayerEntity) player, ((INamedContainerProvider) tileentity), t -> t.writeBlockPos(pos));

 

So the problem is this isn't synced with the client. I'll try getUpdatePacket() and onDataPacket() in the te then.

Edited October 31, 2020 by urbanxx001
  • Quote

Share this post


Link to post
Share on other sites

urbanxx001    8

urbanxx001

urbanxx001    8

  • Creeper Killer
  • urbanxx001
  • Members
  • 8
  • 139 posts
Posted October 31, 2020

Woo got it to sync by setting the pos in the read/write methods, which are called by getUpdateTag().

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Potatoe
      Minecraft server

      By Potatoe · Posted 13 minutes ago

      ok
    • diesieben07
      Minecraft server

      By diesieben07 · Posted 17 minutes ago

      This is a Forum for Forge, I would suggest you seek help elsewhere for Vanilla Minecraft.
    • Luis_ST
      [1.16.5] Player Field of View

      By Luis_ST · Posted 23 minutes ago

      In that second I found out for myself but thanks
    • diesieben07
      [1.16.5] Player Field of View

      By diesieben07 · Posted 27 minutes ago

      getUseDuration needs to return a value > 0 for setActiveHand to work. By default it returns 0.
    • Potatoe
      Minecraft server

      By Potatoe · Posted 30 minutes ago

      Vanilla server...  
  • Topics

    • Potatoe
      4
      Minecraft server

      By Potatoe
      Started Sunday at 10:13 AM

    • Luis_ST
      4
      [1.16.5] Player Field of View

      By Luis_ST
      Started 1 hour ago

    • Klarks
      29
      [1.16.4] what difference between custom slots and EquipmentSlotType

      By Klarks
      Started Yesterday at 06:22 AM

    • tuskiomi
      11
      Forge *needs* to save textures after stitching them

      By tuskiomi
      Started March 24, 2020

    • awsfte6
      1
      core mod crash 1.7.10 JRMCore

      By awsfte6
      Started 1 hour ago

  • Who's Online (See full list)

    • hendrik
    • diesieben07
    • Novârch
    • squidlex
    • JoppeGames3
    • Luis_ST
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.16.x] Packet Invalid Message
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community