MrInfinity Posted October 27, 2020 Share Posted October 27, 2020 Hi. I'm making a hopper-like block, and In order to get the item into the gui, I need to be able to test if the item is on a block. I have this, and was wondering how to test what it collided with, or is there a better way to do it? @SubscribeEvent public static void ItemPickup(ItemEvent event) { ItemEntity itemEntity = (ItemEntity) event.getItem(); if (itemEntity.collidedVertically){ } } } Quote Link to comment Share on other sites More sharing options...
Draco18s Posted October 28, 2020 Share Posted October 28, 2020 (edited) This is wholly the wrong way to go about this. Try looking at how the hopper picks up items. Edited October 28, 2020 by Draco18s Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given. Link to comment Share on other sites More sharing options...
MrInfinity Posted October 28, 2020 Author Share Posted October 28, 2020 Where would that be? I've checked eveything I could, but I can't seem to find the coe. What would the fine name be? Quote Link to comment Share on other sites More sharing options...
poopoodice Posted October 28, 2020 Share Posted October 28, 2020 Check onEntityCollision in net.minecraft.block.HopperBlock Quote Link to comment Share on other sites More sharing options...
MrInfinity Posted October 29, 2020 Author Share Posted October 29, 2020 (edited) Ok so I looked at it, and wrote it into my block code. It still won't suck the item in, despite it being a copy of the hopperblock code. Here's what I put in: @Override public void onEntityCollision(BlockState state, World worldIn, BlockPos pos, Entity entityIn) { TileEntity tileentity = worldIn.getTileEntity(pos); if (tileentity instanceof HopperTileEntity) { ((HopperTileEntity)tileentity).onEntityCollision(entityIn); } } Edited October 29, 2020 by MrInfinity Typo Quote Link to comment Share on other sites More sharing options...
poopoodice Posted October 29, 2020 Share Posted October 29, 2020 So....is there a hopper tileentity at that position? Quote Link to comment Share on other sites More sharing options...
MrInfinity Posted October 29, 2020 Author Share Posted October 29, 2020 When I load in the consol says that there is an invalid block entity at every position of the hopper block. Here's the full code: public class ConveyorHopper extends Block { private static final DirectionProperty FACING = HorizontalBlock.HORIZONTAL_FACING; private static final VoxelShape SHAPE_N = Stream.of( Block.makeCuboidShape(0, 10, 0, 16, 16, 16), Block.makeCuboidShape(6, 0, 6, 10, 4, 10), Block.makeCuboidShape(4, 4, 4, 12, 10, 12) ).reduce((v1, v2) -> {return VoxelShapes.combineAndSimplify(v1, v2, IBooleanFunction.OR);}).get(); private static final VoxelShape SHAPE_E = Stream.of( Block.makeCuboidShape(0, 10, 0, 16, 16, 16), Block.makeCuboidShape(6, 0, 6, 10, 4, 10), Block.makeCuboidShape(4, 4, 4, 12, 10, 12) ).reduce((v1, v2) -> {return VoxelShapes.combineAndSimplify(v1, v2, IBooleanFunction.OR);}).get(); private static final VoxelShape SHAPE_S = Stream.of( Block.makeCuboidShape(0, 10, 0, 16, 16, 16), Block.makeCuboidShape(6, 0, 6, 10, 4, 10), Block.makeCuboidShape(4, 4, 4, 12, 10, 12) ).reduce((v1, v2) -> {return VoxelShapes.combineAndSimplify(v1, v2, IBooleanFunction.OR);}).get(); private static final VoxelShape SHAPE_W = Stream.of( Block.makeCuboidShape(0, 10, 0, 16, 16, 16), Block.makeCuboidShape(6, 0, 6, 10, 4, 10), Block.makeCuboidShape(4, 4, 4, 12, 10, 12) ).reduce((v1, v2) -> {return VoxelShapes.combineAndSimplify(v1, v2, IBooleanFunction.OR);}).get(); public ConveyorHopper() { super(AbstractBlock.Properties.create(Material.IRON) .hardnessAndResistance(4.0f, 5.0f) .sound(SoundType.METAL) .harvestLevel(2) .harvestTool(ToolType.PICKAXE)); } @Override public VoxelShape getShape(BlockState state, IBlockReader worldIn, BlockPos pos, ISelectionContext context) { switch (state.get(FACING)) { case EAST: return SHAPE_E; case SOUTH: return SHAPE_S; case WEST: return SHAPE_W; default: return SHAPE_N; } } @Nullable @Override public BlockState getStateForPlacement(BlockItemUseContext context) { return this.getDefaultState().with(FACING, context.getPlacementHorizontalFacing().getOpposite()); } @Override public BlockState rotate(BlockState state, Rotation rot) { return state.with(FACING, rot.rotate(state.get(FACING))); } @Override public BlockState mirror(BlockState state, Mirror mirrorIn) { return state.rotate(mirrorIn.toRotation(state.get(FACING))); } @Override protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) { builder.add(FACING); } @Override public float getAmbientOcclusionLightValue(BlockState state, IBlockReader worldIn, BlockPos pos) { return 0.5f; } @Override public boolean hasTileEntity(BlockState state) { return true; } @Nullable @Override public TileEntity createTileEntity(BlockState state, IBlockReader world) { return new HopperTileEntity(); } @Override public ActionResultType onBlockActivated(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockRayTraceResult trace) { if (!world.isRemote) { TileEntity tileEntity = world.getTileEntity(pos); if (tileEntity instanceof INamedContainerProvider) { NetworkHooks.openGui((ServerPlayerEntity) player, (INamedContainerProvider) tileEntity, tileEntity.getPos()); } else { throw new IllegalStateException("Our named container provider is missing!"); } return ActionResultType.SUCCESS; } return super.onBlockActivated(state, world, pos, player, hand, trace); } @Override public void onReplaced(BlockState state, World worldIn, BlockPos pos, BlockState newState, boolean isMoving) { if (!state.isIn(newState.getBlock())) { TileEntity tileentity = worldIn.getTileEntity(pos); if (tileentity instanceof HopperTileEntity) { InventoryHelper.dropInventoryItems(worldIn, pos, (HopperTileEntity)tileentity); } super.onReplaced(state, worldIn, pos, newState, isMoving); } } @Override public boolean hasComparatorInputOverride(BlockState state) { return true; } @Override public int getComparatorInputOverride(BlockState blockState, World worldIn, BlockPos pos) { return Container.calcRedstone(worldIn.getTileEntity(pos)); } @Override public void onEntityCollision(BlockState state, World worldIn, BlockPos pos, Entity entityIn) { TileEntity tileentity = worldIn.getTileEntity(pos); if (tileentity instanceof HopperTileEntity) { ((HopperTileEntity)tileentity).onEntityCollision(entityIn); } } } Quote Link to comment Share on other sites More sharing options...
poopoodice Posted October 29, 2020 Share Posted October 29, 2020 (edited) That's because your block is not in the list of valid blocks for vanilla hopper tileentity when it is registered. Check net.minecraft.tileentity.TileEntityType And your block does not have boolean property ENABLED Therefore it won't respond to your own hopper. Inherit from existing resource instead of copy and pasting, then override the things you want to modify with. Edited October 29, 2020 by poopoodice Quote Link to comment Share on other sites More sharing options...
MrInfinity Posted November 2, 2020 Author Share Posted November 2, 2020 Well I added the ENABLED property by typing it in, and now it crashes whever I try to place the block. Here's the code with the enabled: package com.mrinfinity.motionblocks.blocks; import net.minecraft.block.*; import net.minecraft.block.material.Material; import net.minecraft.entity.Entity; import net.minecraft.entity.item.ItemEntity; import net.minecraft.entity.player.PlayerEntity; import net.minecraft.entity.player.ServerPlayerEntity; import net.minecraft.inventory.IInventory; import net.minecraft.inventory.InventoryHelper; import net.minecraft.inventory.container.Container; import net.minecraft.inventory.container.INamedContainerProvider; import net.minecraft.item.BlockItemUseContext; import net.minecraft.item.ItemStack; import net.minecraft.state.BooleanProperty; import net.minecraft.state.DirectionProperty; import net.minecraft.state.StateContainer; import net.minecraft.state.properties.BlockStateProperties; import net.minecraft.tileentity.HopperTileEntity; import net.minecraft.tileentity.IHopper; import net.minecraft.tileentity.TileEntity; import net.minecraft.util.*; import net.minecraft.util.math.BlockPos; import net.minecraft.util.math.BlockRayTraceResult; import net.minecraft.util.math.shapes.IBooleanFunction; import net.minecraft.util.math.shapes.ISelectionContext; import net.minecraft.util.math.shapes.VoxelShape; import net.minecraft.util.math.shapes.VoxelShapes; import net.minecraft.world.IBlockReader; import net.minecraft.world.LockCode; import net.minecraft.world.World; import net.minecraftforge.common.ToolType; import net.minecraftforge.fml.network.NetworkHooks; import javax.annotation.Nullable; import java.util.List; import java.util.Objects; import java.util.stream.Collectors; import java.util.stream.Stream; import static net.minecraft.tileentity.HopperTileEntity.captureItem; import static net.minecraft.tileentity.IHopper.COLLECTION_AREA_SHAPE; public class ConveyorHopper extends Block { private NonNullList<ItemStack> inventory = NonNullList.withSize(5, ItemStack.EMPTY); private static final DirectionProperty FACING = HorizontalBlock.HORIZONTAL_FACING; private static final BooleanProperty ENABLED = BlockStateProperties.ENABLED; private int transferCooldown = -1; private LockCode code = LockCode.EMPTY_CODE; private static final VoxelShape SHAPE_N = Stream.of( Block.makeCuboidShape(0, 10, 0, 16, 16, 16), Block.makeCuboidShape(6, 0, 6, 10, 4, 10), Block.makeCuboidShape(4, 4, 4, 12, 10, 12) ).reduce((v1, v2) -> {return VoxelShapes.combineAndSimplify(v1, v2, IBooleanFunction.OR);}).get(); private static final VoxelShape SHAPE_E = Stream.of( Block.makeCuboidShape(0, 10, 0, 16, 16, 16), Block.makeCuboidShape(6, 0, 6, 10, 4, 10), Block.makeCuboidShape(4, 4, 4, 12, 10, 12) ).reduce((v1, v2) -> {return VoxelShapes.combineAndSimplify(v1, v2, IBooleanFunction.OR);}).get(); private static final VoxelShape SHAPE_S = Stream.of( Block.makeCuboidShape(0, 10, 0, 16, 16, 16), Block.makeCuboidShape(6, 0, 6, 10, 4, 10), Block.makeCuboidShape(4, 4, 4, 12, 10, 12) ).reduce((v1, v2) -> {return VoxelShapes.combineAndSimplify(v1, v2, IBooleanFunction.OR);}).get(); private static final VoxelShape SHAPE_W = Stream.of( Block.makeCuboidShape(0, 10, 0, 16, 16, 16), Block.makeCuboidShape(6, 0, 6, 10, 4, 10), Block.makeCuboidShape(4, 4, 4, 12, 10, 12) ).reduce((v1, v2) -> {return VoxelShapes.combineAndSimplify(v1, v2, IBooleanFunction.OR);}).get(); public ConveyorHopper() { super(Properties.create(Material.IRON) .hardnessAndResistance(4.0f, 5.0f) .sound(SoundType.METAL) .harvestLevel(2) .harvestTool(ToolType.PICKAXE)); } @Override public VoxelShape getShape(BlockState state, IBlockReader worldIn, BlockPos pos, ISelectionContext context) { switch (state.get(FACING)) { case EAST: return SHAPE_E; case SOUTH: return SHAPE_S; case WEST: return SHAPE_W; default: return SHAPE_N; } } @Nullable @Override public BlockState getStateForPlacement(BlockItemUseContext context) { return this.getDefaultState().with(FACING, context.getPlacementHorizontalFacing().getOpposite()).with(ENABLED, Boolean.TRUE); } @Override public BlockState rotate(BlockState state, Rotation rot) { return state.with(FACING, rot.rotate(state.get(FACING))); } @Override public BlockState mirror(BlockState state, Mirror mirrorIn) { return state.rotate(mirrorIn.toRotation(state.get(FACING))); } @Override protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) { builder.add(FACING); } @Override public float getAmbientOcclusionLightValue(BlockState state, IBlockReader worldIn, BlockPos pos) { return 0.5f; } @Override public boolean hasTileEntity(BlockState state) { return true; } private void updateState(World worldIn, BlockPos pos, BlockState state) { boolean flag = !worldIn.isBlockPowered(pos); if (flag != state.get(ENABLED)) { worldIn.setBlockState(pos, state.with(ENABLED, flag), 4); } } @Nullable @Override public TileEntity createTileEntity(BlockState state, IBlockReader world) { return new HopperTileEntity(); } @Override public ActionResultType onBlockActivated(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, BlockRayTraceResult trace) { if (!world.isRemote) { TileEntity tileEntity = world.getTileEntity(pos); if (tileEntity instanceof INamedContainerProvider) { NetworkHooks.openGui((ServerPlayerEntity) player, (INamedContainerProvider) tileEntity, tileEntity.getPos()); } else { throw new IllegalStateException("Our named container provider is missing!"); } return ActionResultType.SUCCESS; } return super.onBlockActivated(state, world, pos, player, hand, trace); } @Override public void onReplaced(BlockState state, World worldIn, BlockPos pos, BlockState newState, boolean isMoving) { if (!state.isIn(newState.getBlock())) { TileEntity tileentity = worldIn.getTileEntity(pos); if (tileentity instanceof HopperTileEntity) { InventoryHelper.dropInventoryItems(worldIn, pos, (HopperTileEntity)tileentity); } super.onReplaced(state, worldIn, pos, newState, isMoving); } } @Override public boolean hasComparatorInputOverride(BlockState state) { return true; } private boolean isOnTransferCooldown() { return this.transferCooldown > 0; } public int getSizeInventory() { return this.inventory.size(); } @Override public int getComparatorInputOverride(BlockState blockState, World worldIn, BlockPos pos) { return Container.calcRedstone(worldIn.getTileEntity(pos)); } public static List<ItemEntity> getCaptureItems(IHopper p_200115_0_) { return p_200115_0_.getCollectionArea().toBoundingBoxList().stream().flatMap((p_200110_1_) -> { return Objects.requireNonNull(p_200115_0_.getWorld()).getEntitiesWithinAABB(ItemEntity.class, p_200110_1_.offset(p_200115_0_.getXPos() - 0.5D, p_200115_0_.getYPos() - 0.5D, p_200115_0_.getZPos() - 0.5D), EntityPredicates.IS_ALIVE).stream(); }).collect(Collectors.toList()); } VoxelShape getCollectionArea() { return COLLECTION_AREA_SHAPE; } public boolean onEntityCollision(Entity p_200113_1_, BlockPos pos, IHopper p_200115_0_) { if (p_200113_1_ instanceof ItemEntity) { if (VoxelShapes.compare(VoxelShapes.create(p_200113_1_.getBoundingBox().offset((double) (-pos.getX()), (double) (-pos.getY()), (double) (-pos.getZ()))), this.getCollectionArea(), IBooleanFunction.AND)) { return captureItem((IInventory) this, (ItemEntity) p_200113_1_); } } assert p_200113_1_ instanceof ItemEntity; return captureItem((IInventory) this, (ItemEntity) p_200113_1_); } @Override public void onEntityCollision(BlockState state, World worldIn, BlockPos pos, Entity entityIn) { TileEntity tileentity = worldIn.getTileEntity(pos); if (tileentity instanceof HopperTileEntity) { ((HopperTileEntity) tileentity).onEntityCollision(entityIn); } } } And here's what the crash report says at the top: java.lang.IllegalArgumentException: Cannot set property BooleanProperty{name=enabled, clazz=class java.lang.Boolean, values=[true, false]} as it does not exist in Block{blocksthatmoveyou:conveyor_hopper} Quote Link to comment Share on other sites More sharing options...
poopoodice Posted November 3, 2020 Share Posted November 3, 2020 (edited) 32 minutes ago, MrInfinity said: private NonNullList<ItemStack> inventory = NonNullList.withSize(5, ItemStack.EMPTY); private int transferCooldown = -1; private LockCode code = LockCode.EMPTY_CODE; These are not supposed to exist in your block class, at least not how like how you use it here. You forgot to add the new state to the state container. Edited November 3, 2020 by poopoodice Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.