Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16.3] Player moves based on block direction


Recommended Posts

Hello. I'm making a conveyor mod, so I need the entity to move based on the blocks direction property, here named FACING. I think I'll need to use If to get this to work, but I can't find how to compare the FACING variable properly. How would I do this? I've tried to figure it out by logging the variable whenever the block is walked on, but that only puts out this: DirectionProperty{name=facing, clazz=class net.minecraft.util.Direction, values=[north, south, west, east]} Here's my code:

private static final DirectionProperty FACING = HorizontalBlock.HORIZONTAL_FACING;

public ConveyorBlock() {
    super(Block.Properties.create(Material.IRON)
            .hardnessAndResistance(4.0f, 5.0f)
            .sound(SoundType.METAL)
            .harvestLevel(2)
            .harvestTool(ToolType.PICKAXE)
            .func_235859_g_());
}

@Nullable
@Override
public BlockState getStateForPlacement(BlockItemUseContext context) {
    return this.getDefaultState().with(FACING, context.getPlacementHorizontalFacing().getOpposite());
}

@Override
public BlockState rotate(BlockState state, Rotation rot) {
    return state.with(FACING, rot.rotate(state.get(FACING)));
}

@Override
public BlockState mirror(BlockState state, Mirror mirrorIn) {
    return state.rotate(mirrorIn.toRotation(state.get(FACING)));
}

@Override
protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
    builder.add(FACING);
}

@Override
public void onEntityWalk(World worldIn, BlockPos pos, Entity entityIn) {

    Vector3d v = entityIn.getMotion();
    DirectionProperty facing = FACING;


    BlocksthatMoveyou.LOGGER.info(facing);
    BlocksthatMoveyou.LOGGER.info("Player walked on conveyor!");

    if (FACING == north) //This was one of the ways I tried doing it, but it can't resolve the symbol I also tried putting it in quotes
    entityIn.setMotion(v.x, -v.y, v.z);
}
Edited by MrInfinity
Link to post
Share on other sites

Do you know Java?

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Twitch Launcher: If you are using the Twitch Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Twitch's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

Link to post
Share on other sites

Hi.

 

3 hours ago, MrInfinity said:

entityIn.setMotion(v.x, -v.y, v.z);

You need to add the velocity to the entity, not negate its current velocity (that doesn't make mathematical sense).

 

3 hours ago, MrInfinity said:

private static final DirectionProperty FACING = HorizontalBlock.HORIZONTAL_FACING;

FACING is a DirectionProperty, which is a blockstate property. It does not contain a value by itself, but rather act as a key to a value stored in the blockstate.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to post
Share on other sites
  • 2 weeks later...
On 10/29/2020 at 10:51 PM, DavidM said:

FACING is a DirectionProperty, which is a blockstate property. It does not contain a value by itself, but rather act as a key to a value stored in the blockstate.

So could I use an If statement to check which direction the block under me is facing? I have a code that checks what block is under it, and gets that blocks BlockState.

Link to post
Share on other sites
1 hour ago, MrInfinity said:

So could I use an If statement to check which direction the block under me is facing?

I'm sure there are other ways to go about it, but they amount to basically this.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites

So how would I get the Direction the block is Facing from the blockstate variable? I've looked at a lot of the options that pop up, and I can't seem to find it. what I mean is get the FACING of the block out of the variable storing the blockstate

Edited by MrInfinity
Link to post
Share on other sites

So I have this:

if (thisFacing == Direction.WEST) {
    Vector3d v = entityIn.getMotion();
    entityIn.setVelocity(v.x * 2.0D, v.y, v.z);
}

It gets the right velocity, and it moves you properly, but it moves you in both directions. I want it to only move you in 1 direction, but I can't get it to do that? How'd you go about doing that?

Edited by MrInfinity
Link to post
Share on other sites

That and all you're doing is making the player faster in whatever direction they're already going.

You want to add velocity.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites

Oh ffs

entityIn.setVelocity(v.x - 2.0D, v.y, v.z);

 

Though you'll probably have to fiddle with the 2 value (probably something more like 0.2). Because think about what should happen if the player stands still (the conveyor belt moves him at a constant speed) and what happens if the player moves against the belt (the player should move slowly, which direction is up to you, but either way the two velocities are fighting) and what happens if the player moves in the same direction as the belt (the player should move faster).

 

Right now you're only getting "the player moves faster." But that faster is either "in the direction the player is already moving (your original code) or "in the direction the belt is moving" (what poopdice suggested) so a player trying to go against the flow of the belt gets rocketed backwards!

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites
42 minutes ago, Draco18s said:

Right now you're only getting "the player moves faster." But that faster is either "in the direction the player is already moving (your original code) or "in the direction the belt is moving" (what poopdice suggested) so a player trying to go against the flow of the belt gets rocketed backwards!

Okay yeah that makes sense. Thanks. I didn't think of that for some reason. How would I get the belts motion? It's a block, so it normally woul'nt have any. I can get it's direction, but I can't put that into a vector variable

Link to post
Share on other sites
13 minutes ago, MrInfinity said:

How would I get the belts motion?

...you're already doing that. You're getting its facing already and YOU are the one that decides how fast it moves, which is what the 2.0D is.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites
44 minutes ago, MrInfinity said:

BTW, I have it backwards because the FACING seems to be backwards for the blocks, west is east, and east is west. I don't really care to fix that.

so...flip flop your positive and negative values...

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.