Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16] Rendering arrows on bows


JoieNL
 Share

Recommended Posts

Hiya guys,

I'm developing a mod that adds, among other things, custom bows and arrows to the game. The different arrows can have different damage output, knockback, velocity, or even special attributes. I would like the player to be able to see which arrow they're using when pulling a bow, as opposed to how vanilla handles things. That is, I want to be able to dynamically add another layer to my bow models depending on the arrow used, without having to write a .json file for every combination of bow, arrow, and pull phase.

Now I know that

ItemModelsProperties

are a thing, but I feel like this is not the right approach. I'm pretty sure I'd have to add overrides for every new arrow type to every new bow type model if I used that. And if I were to add another arrow type, I'd have to change every bow model again. Seems like a lot of unnecessary work.

I looked at vanilla's

DynamicBucketModel

and forge's

ItemLayerModel

, and these look promising. I'm just not sure how to go about making these bow models in code, and especially where to register them. Could anyone point me in the right direction or provide some relevant documentation/code? Thanks in advance!

Link to comment
Share on other sites

5 hours ago, JoieNL said:

I'm just not sure how to go about making these bow models in code

You're technically not making the models in code, you are creating loaders that handle your json models. Based on what I gather, you simply want to overlay one model or layer onto another given a specific arrow nocked. You can either use a data generator which will handle all of this overlay data for you and all you need is a texture of the bow and it's states along with a property for the arrow. Otherwise, you would need some implementation of IDynamicBakedModel where it stores the ModelProperty of the arrow using an enum or a registry. There is no specific documentation on this. However, I am sure someone has created examples, though I cannot point you to where.

Link to comment
Share on other sites

I can't believe I've never seen this Forge test library before, thanks for sharing! I'm still having trouble though. My model provider class listens to

GatherDataEvent

and the listener is registered to the mod event bus like in the Forge test, but it seems the event never fires. The model provider should spit some "Hello World"s into the console but it never does. Here's the relevant part of my model provider class:

public class ModelGenerators {

    static {
        System.out.println("Hello World!");
    }

    @SubscribeEvent
    public static void gatherData(GatherDataEvent event) {
        System.out.println("Hello World!");
        DataGenerator generator = event.getGenerator();
        ExistingFileHelper helper = event.getExistingFileHelper();

        if (event.includeClient()) {
            generator.addProvider(new BowModelProvider(generator, helper));
        }
    }
}

In my main mod class I have added the following line:

FMLJavaModLoadingContext.get().getModEventBus().addListener(ModelGenerators::gatherData);

What's going wrong here?

Link to comment
Share on other sites

1 hour ago, diesieben07 said:

DId you configure the runData configuration in your build.gradle correctly? Are you actually running runData?

Good thing this forum has people with functional brain cells to compensate for my lack thereof. I was running runClient instead of runData.

I'll look into generating the bow model files once I find the time to. If I run into any problems along the way, I'll post them here.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • These are my particle effect classes, they are all copied from a tutorial.   public class Juan1ParticalType extends ParticleType { public Juan1ParticalType() { super(false, Juan1ParticalData.DESERIALIZER); } @Override public Codec<Juan1ParticalData> func_230522_e_() { return Codec.unit(new Juan1ParticalData(new Vector3d(0, 0, 0), new Color(0xF63900), 0)); } }   public class Juan1ParticalData implements IParticleData { private final Vector3d speed; private final Color color; private final float diameter; public static final IDeserializer<Juan1ParticalData> DESERIALIZER = new IDeserializer<Juan1ParticalData>() { @Override public Juan1ParticalData deserialize(ParticleType<Juan1ParticalData> particleTypeIn, StringReader reader) throws CommandSyntaxException { final int MIN_COLOUR = 0; final int MAX_COLOUR = 255;reader.expect(' '); double speedX = reader.readDouble(); reader.expect(' '); double speedY = reader.readDouble(); reader.expect(' '); double speedZ = reader.readDouble(); reader.expect(' '); int red = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR); reader.expect(' '); int green = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR); reader.expect(' '); int blue = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR);reader.expect(' ');  int alpha = MathHelper.clamp(reader.readInt(), 1, MAX_COLOUR);reader.expect(' '); float diameter = reader.readFloat();  return new Juan1ParticalData(new Vector3d(speedX, speedY, speedZ), new Color(red, green, blue, alpha), diameter); } @Override public Juan1ParticalData read(ParticleType<Juan1ParticalData> particleTypeIn, PacketBuffer buffer) { final int MIN_COLOUR = 0; final int MAX_COLOUR = 255; double speedX = buffer.readDouble(); double speedY = buffer.readDouble(); double speedZ = buffer.readDouble(); int red = MathHelper.clamp(buffer.readInt(), MIN_COLOUR, MAX_COLOUR); int green = MathHelper.clamp(buffer.readInt(), MIN_COLOUR, MAX_COLOUR); int blue = MathHelper.clamp(buffer.readInt(), MIN_COLOUR, MAX_COLOUR); int alpha = MathHelper.clamp(buffer.readInt(), 1, MAX_COLOUR); float diameter = buffer.readFloat(); return new Juan1ParticalData(new Vector3d(speedX, speedY, speedZ), new Color(red, green, blue, alpha), diameter); } }; public Juan1ParticalData(Vector3d speed, Color color, float diameter) { this.speed = speed; this.color = color; this.diameter = diameter; } @Override public ParticleType<?> getType() { return Utils.ParticleRegistry.JUAN_1_PARTICLE.get(); } @Override public void write(PacketBuffer buffer) { buffer.writeDouble(this.speed.x); buffer.writeDouble(this.speed.y); buffer.writeDouble(this.speed.z); buffer.writeInt(this.color.getRed()); buffer.writeInt(this.color.getGreen()); buffer.writeInt(this.color.getBlue()); buffer.writeInt(this.color.getAlpha()); buffer.writeFloat(this.diameter); } @Override public String getParameters() { return String.format(Locale.ROOT, "%s %.2f %i %i %i %i %.2d %.2d %.2d", this.getType().getRegistryName(), diameter, color.getRed(), color.getGreen(), color.getBlue(), color.getAlpha(), speed.getX(), speed.getY(), speed.getZ()); } public Vector3d getSpeed() { return speed; } public Color getColor() { return color; } public float getDiameter() { return diameter; } }   public class Juan1Particle extends SpriteTexturedParticle { public Juan1Particle(ClientWorld world, double x, double y, double z, Vector3d speed, Color color, float diameter) { super(world, x, y, z, speed.x, speed.y, speed.z); maxAge = 100; setColor(color.getRed() / 255F,color.getGreen() / 255F,color.getBlue() / 255); this.setAlphaF(color.getAlpha()); final float PARTICLE_SCALE_FOR_ONE_METER = 0.1F; particleScale = PARTICLE_SCALE_FOR_ONE_METER * diameter; this.canCollide = true; } @Override public IParticleRenderType getRenderType(){ return IParticleRenderType.PARTICLE_SHEET_TRANSLUCENT; } }   public class Juan1ParticleFactory implements IParticleFactory<Juan1ParticalData> { private final IAnimatedSprite sprites; public Juan1ParticleFactory(IAnimatedSprite sprite) { this.sprites = sprite; } @Override public Particle makeParticle(Juan1ParticalData typeIn, ClientWorld worldIn, double x, double y, double z, double xSpeed, double ySpeed, double zSpeed) { Juan1Particle particle = new Juan1Particle(worldIn, x, y, z, typeIn.getSpeed(), typeIn.getColor(), typeIn.getDiameter()); particle.selectSpriteWithAge(sprites); return particle; } }
    • This is where I want to call the addParticle() method, it is in the livingTick() in an entity. But it shows no particle effect. @Override public void livingTick() { double x = rand.nextGaussian() * 0.02D; double y = rand.nextGaussian() * 0.02D; double z = rand.nextGaussian() * 0.02D; double px = this.getPosX() + 4.0D * rand.nextDouble() - 2.0D; double py = this.getPosY() + rand.nextDouble() - 0.5D; double pz = this.getPosZ() + 4.0D * rand.nextDouble() - 2.0D; world.addParticle(new Juan1ParticalData(new Vector3d(x, y, z), new Color(0xae6be2), 0), px, py, pz, x, y, z);  } When I change "new Juan1ParticalData(new Vector3d(x, y, z), new Color(0xae6be2), 0)" to "ParticleTypes.DRAGON_BREATH" , the particle effects appeared.
    • can you get any useful info from your crash reports?
    • I made a particle effect of my own, and I can only display the particle effect in the game through the command : /particle mymod:juan1particle 0 0 0 0 0 255 100 3.   When I want add the particle through World.addParticle(IParticleData particleData, double x, double y, double z, double xSpeed, double ySpeed, double zSpeed), it does not show at all.   But when I change the particleData Parameter from my particledata's instance to those in the ParticleTypes in the vanilla, It works without problem. So it seems that only my particle effect can't be added into the game, but those in the vanilla can be added.
    • Ok, so, that's really helpful. I guess i need to learn how to make a custom sound instance for my sound.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.