Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16.3] Item registrations


ehbean
 Share

Recommended Posts

I know I've asked a lot of questions recently, but I hit another wall recently.

 

I've been trying something with

ItemHandHelper.giveItemToPlayer();

that is triggered whenever an Item is right clicked.

As it stand I can give players an item from the vanilla game, but I can't seem to give any items from my mod. I suspect that it has to do with how I'm registering all the mod items, which looks like this

public static final RegistryObject<Item> EMPTY_SYRINGE = RegistryHandler.ITEMS.register("empty_syringe", () -> new EmptySyringe());

Whenever I try to add the argument for a mod item to be given to the player I get the follow error "The constructor ItemStack(RegistryObject<Item>) is undefined".

 

I'm assuming that I need to change the way I'm registering the items or do I need to add another line or two to make it work?

 

Thank you

Link to comment
Share on other sites

13 hours ago, poopoodice said:

RegistryObject is a type supplier, use RegistryObject#get to get the item

I've looked at the documentation for the method you suggested. I can't seem to find something that exactly matches that. Would it be event.getRegistry() or is that something else? Thank you.

Link to comment
Share on other sites

1 hour ago, poopoodice said:

The constructor of ItemStack is looking for an Item, but you has passed in an Item Supplier.

You need to use RegistryObject#get to get the Item from the supplier, for example

RegistryObject<Item> MY_ITEM = .....

new ItemStack(MY_ITEM.get());

I apologize if this is a dumb question, but would that look like this?

public static final RegistryObject<Item> EMPTY_SYRINGE = RegistryHandler.ITEMS.register("empty_syringe", () -> new EmptySyringe(), new ItemStack(EMPTY_SYRINGE.get()));

I get an error on the .register, the "new EmptySyringe()" and the "EMPTY_SYRINGE" inside of the new ItemStack.

Here are the error messages

- The method register(String, Supplier<? extends I>) in the type DeferredRegister<Item> is not applicable for the arguments (String, () -> {}, ItemStack)

- Type mismatch: cannot convert from EmptySyringe to I

- Cannot reference a field before it is defined

 

I first and second errors are throwing me a bit. The third one, I'm assuming is because its looking for an ItemStack, but there is no ItemStack by the name of EmptySyringe that I've properly defined?

 

Once again, Thank you for your time.

 

 

Link to comment
Share on other sites

Ultimate goal here is to just make an item that on a right click, is shrunk from the inventory (which I've got down), and then give another, different, item to the player. I'm still learning all the different bits of modding using forge and Minecraft in general, so I apologize if these questions are simple. I am able to give the player an item from the vanilla game, but I can't seem to get it to work with the mod item I've made.

 

So in summary the plan is: Right click empty syringe -> empty syringe is taken from inventory -> blood syringe is given to inventory.

Link to comment
Share on other sites

You need to go into your FullSyringe class, go into the on-right-click method, and type:

 

new ItemStack(ModItems.EMPTY_SYRINGE.get());

  • Thanks 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • This is what I have for two ModelFiles, the first only applying one overlay and the second apply the first overlay + another. public ModelFile scuffedWarenaiBlockModel(Block block) { return models().getBuilder("scuffed_" + name(block)) .parent(existingMcModel("block")) .texture("particle", warenaiBlockTexture(block)) .texture("underlay", warenaiBlockTexture(block)) .texture("overlay", scuffedTexture()) .element().from(0, 0, 0).to(16, 16, 16).allFaces((direction, faceBuilder) -> faceBuilder.uvs(0, 0, 16, 16).texture("#underlay").cullface(direction)).end() .element().from(0, 0, 0).to(16, 16, 16).allFaces((direction, faceBuilder) -> faceBuilder.uvs(0, 0, 16, 16).texture("#overlay").cullface(direction)).end(); } public ModelFile crackedWarenaiBlockModel(Block block, int crackedLevel) { return models().getBuilder("cracked" + crackedLevel + "_" + name(block)) .parent(existingMcModel("block")) .texture("particle", warenaiBlockTexture(block)) .texture("underlay", warenaiBlockTexture(block)) .texture("overlay1", scuffedTexture()) .texture("overlay2", crackedTexture(crackedLevel)) .element().from(0, 0, 0).to(16, 16, 16).allFaces((direction, faceBuilder) -> faceBuilder.uvs(0, 0, 16, 16).texture("#underlay").cullface(direction)).end() .element().from(0, 0, 0).to(16, 16, 16).allFaces((direction, faceBuilder) -> faceBuilder.uvs(0, 0, 16, 16).texture("#overlay1").cullface(direction)).end() .element().from(0, 0, 0).to(16, 16, 16).allFaces((direction, faceBuilder) -> faceBuilder.uvs(0, 0, 16, 16).texture("#overlay2").cullface(direction)).end(); }   This works, but it doesn't seem so simple for a stair block.  I copied the stair stuff from the forge BlockStateProvider class to get started with a normal stair model that works:  public void warenaiStairBlock(StairsBlock block, ResourceLocation texture) { warenaiStairBlockInternal1(block, texture, texture, texture); } public void warenaiStairBlockInternal1(StairsBlock block, ResourceLocation side, ResourceLocation bottom, ResourceLocation top) { warenaiStairBlockInternal2(block, block.getRegistryName().toString(), side, bottom, top); } public void warenaiStairBlockInternal2(StairsBlock block, String baseName, ResourceLocation side, ResourceLocation bottom, ResourceLocation top) { ModelFile normal_stairs = models().stairs(baseName, side, bottom, top); ModelFile normal_stairsInner = models().stairsInner(baseName + "_inner", side, bottom, top); ModelFile normal_stairsOuter = models().stairsOuter(baseName + "_outer", side, bottom, top); warenaiStairsBlock(block, normal_stairs, normal_stairsInner, normal_stairsOuter); } public void warenaiStairsBlock(StairsBlock block, ModelFile stairs, ModelFile stairsInner, ModelFile stairsOuter) { getVariantBuilder(block) .forAllStatesExcept(state -> { Direction facing = state.getValue(StairsBlock.FACING); Half half = state.getValue(StairsBlock.HALF); StairsShape shape = state.getValue(StairsBlock.SHAPE); int yRot = (int) facing.getClockWise().toYRot(); // Stairs model is rotated 90 degrees clockwise for some reason yRot %= 360; boolean uvlock = yRot != 0 || half == Half.TOP; // Don't set uvlock for states that have no rotation ModelFile shapeDependentModel = shape == StairsShape.STRAIGHT ? stairs : shape == StairsShape.INNER_LEFT || shape == StairsShape.INNER_RIGHT ? stairsInner : stairsOuter; if (shape == StairsShape.INNER_LEFT || shape == StairsShape.OUTER_LEFT) { yRot += 270; // Left facing stairs are rotated 90 degrees clockwise } if (shape != StairsShape.STRAIGHT && half == Half.TOP) { yRot += 90; // Top stairs are rotated 90 degrees clockwise } return ConfiguredModel.builder() .modelFile(shapeDependentModel) .rotationX(half == Half.BOTTOM ? 0 : 180) .rotationY(yRot) .uvLock(uvlock) .build(); }, StairsBlock.WATERLOGGED); }   Now I have no idea where to go. I could take the time and figure it out all on my own, but since I really should be working on a college essay I thought I would see if anyone else knew what to do first. If not, then I will just do it myself when I get the time.
    • O well i tried to fix a bug in the stone age mod and my plan failed after trying to insert the json directly into the jar.
    • You spawn the entity on the server. The server then ensures it is spawned on all clients that can see it.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.