Tick Entity Crash

[hypov 0]

My mod keeps crashing the client.

Can anyone help?

crash-2020-11-10_22.15.47-server.txt

[Draco18s 2401]

Quote

    at io.github.withonetee.entities.DreamEntity.onLivingFall(DreamEntity.java:148) ~[?:?] {re:classloading}

Complain to the mod author.

[diesieben07 7587]

2 hours ago, Draco18s said:

Complain to the mod author.

They are the mod author

 

@hypov Show your code.

[hypov 0]

11 hours ago, diesieben07 said:

They are the mod author

 

@hypov Show your code.

The entity class?

 

 

DreamEntity.java

[diesieben07 7587]

1. Please learn what static means. None of those things should be static.
2. Do not re-use ItemStack instances.
3. Do not cache things like Blocks.WATER in your own fields.

That crash is impossible to get with the code you posted.

[hypov 0]

18 minutes ago, diesieben07 said:

1. Please learn what static means. None of those things should be static.
2. Do not re-use ItemStack instances.
3. Do not cache things like Blocks.WATER in your own fields.

That crash is impossible to get with the code you posted.

Why can't I re-use ItemStack instances?

[loordgek 174]

because they are shared between you DreamEntitys

[diesieben07 7587]

5 minutes ago, hypov said:

Why can't I re-use ItemStack instances?

Because they hold state, like size, damage, etc. This will all be shared.

[hypov 0]

59 minutes ago, diesieben07 said:

Because they hold state, like size, damage, etc. This will all be shared.

I'm confused 

What does that mean?

[diesieben07 7587]

You create an ItemStack and store it in a static field.

You then do something with that stack, e.g. give it to the player. This will cause this ItemStack reference to get modified (if the player splits the stack in their inventory, for example). Now your static field holds the same ItemStack instance still, but it has changed (now has a different count).

You now give this stack to a different player. The first player then changes the stack in their inventory and magically the stack in the 2nd player's inventory changes also.

[hypov 0]

2 minutes ago, diesieben07 said:

You create an ItemStack and store it in a static field.

You then do something with that stack, e.g. give it to the player. This will cause this ItemStack reference to get modified (if the player splits the stack in their inventory, for example). Now your static field holds the same ItemStack instance still, but it has changed (now has a different count).

You now give this stack to a different player. The first player then changes the stack in their inventory and magically the stack in the 2nd player's inventory changes also.

oh right

How would I fix this?

 

Also I'm trying to add mlg features to the entity.. how would I do that?

 

Thank you!

[diesieben07 7587]

Just now, hypov said:

oh right

How would I fix this?

Don't re-use Itemstacks.

 

1 minute ago, hypov said:

Also I'm trying to add mlg features to the entity.. how would I do that?

What?

[hypov 0]

Just now, diesieben07 said:

Don't re-use Itemstacks.

 

What?

Okay

 

Basically if an entity is falling, the entity would place a water bucket below them to counteract the fall damage

 

[diesieben07 7587]

Probably need to check the Y motion for a negative value and check if there is ground below.

[hypov 0]

1 minute ago, diesieben07 said:

Probably need to check the Y motion for a negative value and check if there is ground below.

Uhm yes, I have problems though

 

1. How do I check if there's ground below an entity?

2. I'm registering the event handler in another class, so how would I set the item of the entity in the other class?

 

 

[Draco18s 2401]

44 minutes ago, hypov said:

Uhm yes, I have problems though

 

1. How do I check if there's ground below an entity?

world#getBlockState