Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[Solved]Multi texture block bug in inventory


decebaldecebal
 Share

Recommended Posts

Hello forge community, I have created a multi textured block that is based on the furnace code.It basically works the same as the furnace, but with different recipes.The problem I have is that the texture on the block works well when it is placed in the world, but when it is in my hand or inventory, the texture does not render correctly.Here is a screenshot that shows exactly what I mean:

nm4Z6l3.jpg

 

The code to my block class is located here:

http://pastebin.com/eeMPk18v

 

Any help with this would be greatly appreciated.

 

Also, I have found another small bug with this block.I have made some custom fuels that can run into this custom furnace, some of them which have a very long burn time.The bug I found is that if I have an item that burns for let's say 30 seconds, and it burns half way through, after I exit the world and re-log back in, the flaming animation from the furnace fuel progress bar is back in the starting position, and not in the middle as it was before.After I wait another 14 seconds, the flame starts to go down very fast and finally it stops when the item is fully burned.I have no idea how to fix this bug.

 

I repeat that I have done exactly everything as the furnace does things, but it seems to not work properly.

Link to comment
Share on other sites

Also, I have found another small bug with this block.I have made some custom fuels that can run into this custom furnace, some of them which have a very long burn time.The bug I found is that if I have an item that burns for let's say 30 seconds, and it burns half way through, after I exit the world and re-log back in, the flaming animation from the furnace fuel progress bar is back in the starting position, and not in the middle as it was before.After I wait another 14 seconds, the flame starts to go down very fast and finally it stops when the item is fully burned.I have no idea how to fix this bug.

 

I repeat that I have done exactly everything as the furnace does things, but it seems to not work properly.

This bug is present in vanilla furnaces too last time I checked. If anyone knows a fix, I could use it too, but I've kind of given up on it myself.

Read my thoughts on my summer mod work and tell me what you think!

http://www.minecraftforge.net/forum/index.php/topic,8396.0.html

 

I absolutely love her when she smiles

Link to comment
Share on other sites

This bug is present in vanilla furnaces too last time I checked. If anyone knows a fix, I could use it too, but I've kind of given up on it myself.

 

Well I kind of tested it with a normal furnace and couldn't find any problem with the animation, maybe the fuel I used didn't burn for long enough if you say that this happens with Vanilla too...

Link to comment
Share on other sites

I meant the second bug. That's why I quoted you mentioning the second bug.

Put a piece of coal and 8 iron in a vanilla furnace and wait till 4 pieces have been smelted. The fire will have burned down halfway. Exit the world, then log back in, and you will notice the fire is full again, and will drop rapidly when it reaches the last item to be smelted.

Read my thoughts on my summer mod work and tell me what you think!

http://www.minecraftforge.net/forum/index.php/topic,8396.0.html

 

I absolutely love her when she smiles

Link to comment
Share on other sites

I have a solution for the second bug, but I'm stuck on the first myself.

 

The bug is caused because the fuel value of the last item burnt isn't written to NBT, and is read by looking at the item in the slot when the tile entity is loaded. All's well and good if that item is the same as before, but if the stack ran out then it defaults to 200 to avoid zero division.

 

Adding a new tag in the writeToNBT() and readFromNBT() methods seemed to solve it:

 

public void writeToNBT( NBTTagCompound tagCompound )
{
	super.writeToNBT( tagCompound );

	tagCompound.setShort( "BurnTime", (short) furnaceBurnTime );
	tagCompound.setShort( "CookTime", (short) furnaceCookTime );
	tagCompound.setShort( "ItemBurnTime", (short) currentItemBurnTime );        // <- this

	// add inventory and shizzle
}

public void readFromNBT( NBTTagCompound tagCompound )
{
	super.readFromNBT( tagCompound );
   
	// read inventory and shizzle

	furnaceBurnTime = tagCompound.getShort( "BurnTime" );
	furnaceCookTime = tagCompound.getShort( "CookTime" );
	currentItemBurnTime = tagCompound.getShort( "ItemBurnTime" );        // <- and this
}

 

... or something along those lines.

Link to comment
Share on other sites

What is the metadata of the block when it's in your hand?

given that this is how you call the front texture this should probably be thought about. (I'm guessing 0 and that it is rendering on the bottom of the item)

 

hint:

if you want to see the metadata in minecraft (sans NEI), just hold F3 and press H

Link to comment
Share on other sites

What is the metadata of the block when it's in your hand?

given that this is how you call the front texture this should probably be thought about. (I'm guessing 0 and that it is rendering on the bottom of the item)

 

hint:

if you want to see the metadata in minecraft (sans NEI), just hold F3 and press H

 

Well the metada of the block is 0, so I will try to check if the metadata is 0 and render that texture, but the problem is how to stop this happening in the world also.I will try it and see if it works.

Link to comment
Share on other sites

OK, so it seems that everything is fixed now.For the side, I added another check when the metadata is 0 and the side is 3, and that seems to work perfectly fine, in the inventory it looks like the furnace, and in the world everything works perfectly.

 

Also I added to the NBT data what Homletmoo said:

 

Adding a new tag in the writeToNBT() and readFromNBT() methods seemed to solve it:

 

public void writeToNBT( NBTTagCompound tagCompound )
{
	super.writeToNBT( tagCompound );

	tagCompound.setShort( "BurnTime", (short) furnaceBurnTime );
	tagCompound.setShort( "CookTime", (short) furnaceCookTime );
	tagCompound.setShort( "ItemBurnTime", (short) currentItemBurnTime );        // <- add this

	// add inventory and shizzle
}

public void readFromNBT( NBTTagCompound tagCompound )
{
	super.readFromNBT( tagCompound );
   
	// read inventory and shizzle

	furnaceBurnTime = tagCompound.getShort( "BurnTime" );
	furnaceCookTime = tagCompound.getShort( "CookTime" );

                currentItemBurnTime = getItemBurnTime(this.furnaceItemStacks[1]);     // <- if you have this delete it and

	currentItemBurnTime = tagCompound.getShort( "ItemBurnTime" );        // <- add this
}

 

Thanks for the help guys!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Ahh ok  But also in mods with custom armor you normally use resourcepacks for the model (every mod has a built-in resource pack), so there really is no need. If you want to do it anyway ... it's your choice 
    • Well, im just learning) Wanna make my own mods in future.
    • Hi! You don't need an extra Mod to do this, you can just use a resource pack and replace the armor texture and model
    • hello. I try to create my custom chest BUT that's make me crazy. 1.if I put an item in my custom chest it become doubled, and if I click it ,it will be dispeared.:( 2.the custom chest what i made use the same container in different blocks.   TileEntity: public class SFCTileEntity extends TileEntity implements INamedContainerProvider { public static final int NUMBER_OF_SLOTS = 27; public SFCTileEntity() { super(TileEntityTypeRegistry.TileEntity.get()); chestContents = ChestContents.createForTileEntity(NUMBER_OF_SLOTS, this::canPlayerAccessInventory, this::setChanged); } public boolean canPlayerAccessInventory(PlayerEntity player) { if (this.level.getBlockEntity(this.worldPosition) != this) return false; final double X_CENTRE_OFFSET = 0.5; final double Y_CENTRE_OFFSET = 0.5; final double Z_CENTRE_OFFSET = 0.5; final double MAXIMUM_DISTANCE_SQ = 8.0 * 8.0; return player.distanceToSqr(worldPosition.getX() + X_CENTRE_OFFSET, worldPosition.getY() + Y_CENTRE_OFFSET, worldPosition.getZ() + Z_CENTRE_OFFSET) < MAXIMUM_DISTANCE_SQ; } private static final String CHESTCONTENTS_INVENTORY_TAG = "contents"; @Override public CompoundNBT save(CompoundNBT parentNBTTagCompound) { super.save(parentNBTTagCompound); CompoundNBT inventoryNBT = chestContents.serializeNBT(); parentNBTTagCompound.put(CHESTCONTENTS_INVENTORY_TAG, inventoryNBT); return parentNBTTagCompound; } @Override public void load(BlockState blockState, CompoundNBT parentNBTTagCompound) { super.load(blockState, parentNBTTagCompound); CompoundNBT inventoryNBT = parentNBTTagCompound.getCompound(CHESTCONTENTS_INVENTORY_TAG); chestContents.deserializeNBT(inventoryNBT); } @Override @Nullable public SUpdateTileEntityPacket getUpdatePacket() { CompoundNBT nbtTagCompound = new CompoundNBT(); save(nbtTagCompound); int tileEntityType = 42; return new SUpdateTileEntityPacket(this.worldPosition, tileEntityType, nbtTagCompound); } @Override public void onDataPacket(NetworkManager net, SUpdateTileEntityPacket pkt) { BlockState blockState = level.getBlockState(worldPosition); load(blockState, pkt.getTag()); } @Override public CompoundNBT getUpdateTag() { CompoundNBT nbtTagCompound = new CompoundNBT(); save(nbtTagCompound); return nbtTagCompound; } /* Populates this TileEntity with information from the tag, used by vanilla to transmit from server to client * The vanilla default is suitable for this example but I've included an explicit definition anyway. */ @Override public void handleUpdateTag(BlockState blockState, CompoundNBT tag) { this.load(blockState, tag); } @Override public ITextComponent getDisplayName() { return null; } @Nullable @Override public Container createMenu(int windowID, PlayerInventory playerInventory, PlayerEntity playerEntity) { return SFContainer.createContainerServerSide(windowID, playerInventory, chestContents); } public static ChestContents getChestContents() { return chestContents; } private static ChestContents chestContents; }   Container: public class SFContainer extends Container { private static final int HOTBAR_SLOT_COUNT = 9; private static final int PLAYER_INVENTORY_ROW_COUNT = 3; private static final int PLAYER_INVENTORY_COLUMN_COUNT = 9; private static final int PLAYER_INVENTORY_SLOT_COUNT = PLAYER_INVENTORY_COLUMN_COUNT * PLAYER_INVENTORY_ROW_COUNT; private static final int VANILLA_SLOT_COUNT = HOTBAR_SLOT_COUNT + PLAYER_INVENTORY_SLOT_COUNT; private static final int VANILLA_FIRST_SLOT_INDEX = 0; private static final int TE_INVENTORY_FIRST_SLOT_INDEX = VANILLA_FIRST_SLOT_INDEX + VANILLA_SLOT_COUNT; private static final int TE_INVENTORY_SLOT_COUNT = SFCTileEntity.NUMBER_OF_SLOTS; public static final int TILE_INVENTORY_YPOS = 18; public static final int PLAYER_INVENTORY_YPOS = 86; public SFContainer(int windowID, PlayerInventory playerInventory, ChestContents chestContents) { super(ContainerTypeRegistry.Container.get(), windowID); PlayerInvWrapper playerInventoryForge = new PlayerInvWrapper(playerInventory); this.chestContents = chestContents; final int SLOT_X_SPACING = 18; final int SLOT_Y_SPACING = 18; final int HOTBAR_XPOS = 8; final int HOTBAR_YPOS = 144; for (int x = 0; x < HOTBAR_SLOT_COUNT; x++) { int slotNumber = x; addSlot(new SlotItemHandler(playerInventoryForge, slotNumber, HOTBAR_XPOS + SLOT_X_SPACING * x, HOTBAR_YPOS)); } final int PLAYER_INVENTORY_XPOS = 8; // Add the rest of the player's inventory to the gui for (int y = 0; y < PLAYER_INVENTORY_ROW_COUNT; y++) { for (int x = 0; x < PLAYER_INVENTORY_COLUMN_COUNT; x++) { int slotNumber = HOTBAR_SLOT_COUNT + y * PLAYER_INVENTORY_COLUMN_COUNT + x; int xpos = PLAYER_INVENTORY_XPOS + x * SLOT_X_SPACING; int ypos = PLAYER_INVENTORY_YPOS + y * SLOT_Y_SPACING; addSlot(new SlotItemHandler(playerInventoryForge, slotNumber, xpos, ypos)); } } // Add the tile inventory container to the gui for(int i = 0;i<9;i++){ addSlot(new Slot(chestContents, i, 8+18*i, 18)); addSlot(new Slot(chestContents, i+9, 8+18*i, 36)); addSlot(new Slot(chestContents, i+18, 8+18*i, 54)); } } public static SFContainer createContainerServerSide(int windowID, PlayerInventory playerInventory, ChestContents chestContents) { return new SFContainer(windowID, playerInventory, chestContents); } public static SFContainer createContainerClientSide(int windowID, PlayerInventory playerInventory, net.minecraft.network.PacketBuffer extraData) { ChestContents chestContents = ChestContents.createForClientSideContainer(SFCTileEntity.NUMBER_OF_SLOTS); return new SFContainer(windowID, playerInventory, chestContents); } @Override public boolean stillValid(PlayerEntity playerEntity) { return chestContents.stillValid(playerEntity); } @Override public ItemStack quickMoveStack(PlayerEntity playerEntity, int sourceSlotIndex) { Slot sourceSlot = getSlot(sourceSlotIndex); if (sourceSlot == null || !sourceSlot.hasItem()) return ItemStack.EMPTY; //EMPTY_ITEM ItemStack sourceStack = sourceSlot.getItem(); ItemStack copyOfSourceStack = sourceStack.copy(); // Check if the slot clicked is one of the vanilla container slots if (sourceSlotIndex >= VANILLA_FIRST_SLOT_INDEX && sourceSlotIndex < VANILLA_FIRST_SLOT_INDEX + VANILLA_SLOT_COUNT) { // This is a vanilla container slot so merge the stack into the tile inventory if (!moveItemStackTo(sourceStack, TE_INVENTORY_FIRST_SLOT_INDEX, TE_INVENTORY_FIRST_SLOT_INDEX + TE_INVENTORY_SLOT_COUNT, false)){ return ItemStack.EMPTY; // EMPTY_ITEM } } else if (sourceSlotIndex >= TE_INVENTORY_FIRST_SLOT_INDEX && sourceSlotIndex < TE_INVENTORY_FIRST_SLOT_INDEX + TE_INVENTORY_SLOT_COUNT) { // This is a TE slot so merge the stack into the players inventory if (!moveItemStackTo(sourceStack, VANILLA_FIRST_SLOT_INDEX, VANILLA_FIRST_SLOT_INDEX + VANILLA_SLOT_COUNT, false)) { return ItemStack.EMPTY; } } else { LOGGER.warn("Invalid slotIndex:" + sourceSlotIndex); return ItemStack.EMPTY; } // If stack size == 0 (the entire stack was moved) set slot contents to null if (sourceStack.getCount() == 0) { sourceSlot.mayPlace(ItemStack.EMPTY); } else { sourceSlot.setChanged(); } sourceSlot.onTake(playerEntity, sourceStack); return copyOfSourceStack; } // pass the close container message to the parent inventory (not strictly needed for this example) // see ContainerChest and TileEntityChest - used to animate the lid when no players are accessing the chest any more @Override public void removed(PlayerEntity playerIn) { super.removed(playerIn); } private ChestContents chestContents; private static final Logger LOGGER = LogManager.getLogger(); }  
    • Posting again to finish this thread as I've found a solution for my problem. Don't know why it was having an issue with Java but uninstalled my most recent update of java and switched back to Java 17.02 Here's a link to the version of Java I'm now using https://download.oracle.com/java/17/latest/jdk-17_windows-x64_bin.exe Hope it works for whoever is looking for a solution.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.