Jump to content

[1.15.2] Quarry Tile Entity Not Saving Time Ticked When Leaving World


foonicular

Recommended Posts

The quarry tile entity I made is not saving the ticked time when you leave the world. I have an NBT helper class that contains read and write functions for my tile entity. I believe that it is because I am missing TileEntity#markDirty(), and if it is, do I put that in my tile entity class? Also, is there anything else that I am missing? Thanks in advance to those who help.

 

GitHub: http://github.com/foonicular/AMCMod

Edited by foonicular
Link to comment
Share on other sites

8 hours ago, foonicular said:

The quarry tile entity I made is not saving the ticked time when you leave the world. I have an NBT helper class that contains read and write functions for my tile entity. I believe that it is because I am missing TileEntity#markDirty(), and if it is, do I put that in my tile entity class? Also, is there anything else that I am missing? Thanks in advance to those who help.

 

GitHub: http://github.com/foonicular/AMCMod

@Override
	public void read(CompoundNBT compound) {
		super.read(compound);
		CompoundNBT initValues = compound.getCompound("initvalues");
		if(initValues != null) {
			this.x = initValues.getInt("x");
			this.y = initValues.getInt("y");
			this.z = initValues.getInt("z");
			this.tick = 0;
			initialized = true;
			return;
		}
		init();
	}

You are hard setting the tick field to 0 every time your tileEntity reads the saved NBT data

Link to comment
Share on other sites

11 minutes ago, foonicular said:

how would I store the time the ticks between logins?

the game doesn't really tick when the game isn't running

but you can call Instant.now().getEpochSecond() to get the current time as a long. you could get this value whenever it unloaded (you can override onChunkUnloaded for instance) and save it in a nbt for instance. then when it loaded back again you could get the current time as a long again and calculated the difference. Then you'd have the elapsed time in seconds.

 

(also: you're not being a jerk, don't worry)

Edited by kiou.23
Link to comment
Share on other sites

48 minutes ago, kiou.23 said:

the game doesn't really tick when the game isn't running

but you can call Instant.now().getEpochSecond() to get the current time as a long. you could get this value whenever it unloaded (you can override onChunkUnloaded for instance) and save it in a nbt for instance. then when it loaded back again you could get the current time as a long again and calculated the difference. Then you'd have the elapsed time in seconds.

Where should this go? Within the tile entity class? Also, how would I go about storing the value in an NBT, I have barely any knowledge on NBT currently

Edited by foonicular
Link to comment
Share on other sites

9 hours ago, foonicular said:

Where should this go? Within the tile entity class? Also, how would I go about storing the value in an NBT, I have barely any knowledge on NBT currently

I'm not 100% sure, as I'm also new to modding. but I think you can do this in the write and read methods. In the write method you can save the current time to the nbt.

and in the read method you can get the difference between the current time and the saved time

Link to comment
Share on other sites

So something along the lines of this would work? Create a variable that stores the seconds ticked, when the chunk is unloaded write the seconds ticked variable to it. Then when the chunk is loaded, multiply the seconds ticked variable by 20 (because it is in seconds) set ticks = to seconds ticked and change the 'if ticks = 60000' to 'if ticks >= 60000' to prevent it from breaking?

Link to comment
Share on other sites

2 hours ago, foonicular said:

So something along the lines of this would work? Create a variable that stores the seconds ticked, when the chunk is unloaded write the seconds ticked variable to it. Then when the chunk is loaded, multiply the seconds ticked variable by 20 (because it is in seconds) set ticks = to seconds ticked and change the 'if ticks = 60000' to 'if ticks >= 60000' to prevent it from breaking?

when the chunk is loaded, calculate the difference between the current time, and the time you stored, and then multiply it by 20.

but then I think you would want to divide by 60,000 to know how many times it should have executed?

 

It depends, do you want it to behave as if if it was executing while the game wasn't loaded? so it behaves in "real time"

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I created my own modpack just for mainly entities right now and im having issues with only a handful of the mobs. is there a way someone could help go over my work and check whats wrong? its a file 
    • Hi, I have a problem with my minecraft: I'm in forge 1.20.1 and I have several mods installed, (link to photo below) and after a while, at random, the game freezes, I can't play or move but I can still hear the game in the background, there's just the image that remains, (problematic when I fight a fire dragon :() ) can you help me? my mods:   zmedievalmusic-1.20.1-2.1 treeharvester-1.20.1-8.7 tctcore-1.0-1.20.1 specialmobs-1.20.1-3.1.3 simpleOres2-1.20.1-6.0.0.2 OldCombatMod_1.20x.jar oculus-mc1.20.1-1.7.0 medieval_buildings-forge-1.0.2 matmos-5.2-forge-1.20.1 journeymap-1.20.1-5.9.18-forge jei-1.20.1-forge-15.8.0.11 iceandfire-2.1.13-1.20.1-beta-4 healthindicatortxf-1.20.1-1.2.2-forge geckolib-forge-1.20.1-4.4.7 embeddium-0.3.25+mc1.20.1 dynamiclights-1.20.1-1.2 cupboard-1.20.1-2.7 crust-1.20.1-2.3.3 collective-1.20.1-7.71 citadel-2.4.9-1.20.1 bucketlib-1.20.1-2.3.0.5 born_in_chaos_(Forge)1.20.1_1.3.1 betterfpsdist-4.4   forge 1.20.1 (47.3.5) i fink it's because of ice and fire mod, but i want it thank to help me! i hope you are well Translated with DeepL.com (free version)
    • Long story short, my girlfriend found a mod for Minecraft she wanted but it was for Pocket Edition. So I took it on myself to try and port it over and it has gone fairly well until the point I had to work with particles. Basically, I had it working using animateTick but I was checking if the block name contained a certain value to specify the lantern's color and as such choose which particle to spawn. I was initially trying to do this via the constructor, but this value hasn't been initialized that early and I can't seem to find some event or method to override which ideally happens when the block is loaded/placed. Performing upwards to 16 string comparisons per tick isn't exactly efficient so I want to try and optimize this. By the time animateTick starts executing, the name is properly initialized and I can use that to set my property accordingly. But this is where I'm starting to run into a weird issue. This is my current code; public void animateTick(BlockState state, Level level, BlockPos pos, RandomSource randomSource) { // It's not fully initialized yet... I guess? if (this.getName().toString().contains("air")) return; if (!state.getValue(COLOR_SET)) { // This method doesn't work at all, neither states are updated var blockState = level.getBlockState(pos); blockState.setValue(LANTERNCOLOR, this.getBlockColor()); blockState.setValue(COLOR_SET, true); level.setBlockAndUpdate(pos, blockState); } double d0 = (double)pos.getX() + randomSource.nextDouble(); double d1 = (double)pos.getY() + randomSource.nextDouble(); double d2 = (double)pos.getZ() + randomSource.nextDouble(); // No idea how to better do this without adding 5 000 new files if (level.getBlockState(pos).getValue(LANTERNCOLOR) == DyeColor.WHITE.getId()) level.addParticle(PaperLanterns.LANTERN_GLOW_WHITE.get(), d0, d1, d2, 0.0D, ThreadLocalRandom.current().nextDouble(-0.10D, 0.0D), 0.0D); if (level.getBlockState(pos).getValue(LANTERNCOLOR) == DyeColor.BLUE.getId()) level.addParticle(PaperLanterns.LANTERN_GLOW_BLUE.get(), d0, d1, d2, 0.0D, ThreadLocalRandom.current().nextDouble(-0.10D, 0.0D), 0.0D); } COLOR_SET is a BooleanProperty meant to ensure this is only executed once, for performance reasons. LANTERNCOLOR is currently an IntegerProperty (it used to be an EnumProperty, but been changing stuff around trying to fix the issue) which specified the color. My issue is that I can only set one of these states, for example like this; if (!state.getValue(COLOR_SET)) { // LANTERNCOLOR is set successfully, but not COLORSET level.setBlockAndUpdate(pos, state.setValue(LANTERNCOLOR, this.getBlockColor())); level.setBlockAndUpdate(pos, state.setValue(COLOR_SET, true)); } // OR if (!state.getValue(COLOR_SET)) { // COLOR_SET is set successfully, but not LANTERNCOLOR level.setBlockAndUpdate(pos, state.setValue(COLOR_SET, true)); level.setBlockAndUpdate(pos, state.setValue(LANTERNCOLOR, this.getBlockColor())); } So I can only seemingly set one state at a time, I now know that my issue wasn't in my usage of EnumProperty so once I solve this I will be going back to that and using a switch-case. But I would love some pointers as to why I can only set one of these states. Is it because once you set it and update it, that instance of the block is now considered dirty and as such accepts no more state changes or something? I know the code's a bit all over the place with how I retrieve the states. I'm still learning and have been testing a bunch trying to get this to work, but have now found the issue but no idea how to solve it 😅 If there's a better way of setting this LANTERNCOLOR property and ensuring it's only executed once, that would be even better. The sole purpose of this is to choose which particle to spawn, since the particle colors are hardcoded.
    • Hi, I have a problem with my minecraft: I'm in forge 1.20.1 and I have several mods installed, (link to photo below) and after a while, at random, the game freezes, I can't play or move but I can still hear the game in the background, there's just the image that remains, (problematic when I fight a fire dragon :() ) can you help me? my mods: file:///C:/Users/meria/Pictures/Capture.PNG forge 1.20.1 (47.3.5) i fink it's because of ice and fire mod, but i want it thank to help me! i hope you are well Translated with DeepL.com (free version)
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.