Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.5.1] FurnaceRecipes.getSmeltingResult always null


epicsquare
 Share

Recommended Posts

Hi all,

 

I'm trying to make a custom picaxe that will smelt the block you mine. However, when I try to get the smelt result of a block, it always returns null, EXCEPT for the first time for each new block.

The first stone I mined, smelted into stone, however after that it returned null every time. The first iron ore I mined dropped an iron ingot, after that FurnaceRecipes.smelting().getSmeltingResult(new ItemStack(Block.blocksList[par3])) always returned null for iron ore (I have checked to make sure that new ItemStack(Block.blocksList[par3]) is of the correct type). Can anyone help me? Here is my onBlockDestroyed code

 

@Override
public boolean onBlockDestroyed(ItemStack par1ItemStack, World par2World, int par3, int x, int y, int z, EntityLiving par7EntityLiving) {

	        boolean dropModified = false;
		if (!par2World.isRemote)
		{


			ItemStack res = FurnaceRecipes.smelting().getSmeltingResult(new ItemStack(Block.blocksList[par3]));
			if (res != null)
			{
				float f = 0.7F;
				double d0 = (double)(par2World.rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;
				double d1 = (double)(par2World.rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;
				double d2 = (double)(par2World.rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;
				EntityItem entityitem = new EntityItem(par2World, (double)x + d0, (double)y + d1, (double)z + d2, res);
				entityitem.delayBeforeCanPickup = 10;
				par2World.spawnEntityInWorld(entityitem);
				dropModified = true;
			}

	        }
                        if (!dropModified)
		      super.onBlockDestroyed(par1ItemStack, par2World, par3, x, y, z, par7EntityLiving);
                        else
                             par2World.destroyBlock(x, y, z, false);
	        return true;
}

Link to comment
Share on other sites

Do you need the

                        if (!dropModified)
		      super.onBlockDestroyed(par1ItemStack, par2World, par3, x, y, z, par7EntityLiving);
                        else
                             par2World.destroyBlock(x, y, z, false);

? If not, try deleting it.

↑↑↑↑↑↑↑↑↑↑ Click it please? :3 ↑↑↑↑↑↑↑↑↑↑

Link to comment
Share on other sites

Do you need the

                        if (!dropModified)
		      super.onBlockDestroyed(par1ItemStack, par2World, par3, x, y, z, par7EntityLiving);
                        else
                             par2World.destroyBlock(x, y, z, false);

? If not, try deleting it.

 

The whole statement? Then the block will drop the smelted contents and the original contents too won't it?

 

I need the pickaxe should only smelt things SOMETIMES as in there's a chance it will drop regularly. I didnt put that part into the code I posted but it shouldn't affect it. My issue is that FurnaceRecipes returns null even though it shouldn't.

Link to comment
Share on other sites

which heu ......

 

which class has the code for onBlockDestroyed?

 

im serious btw, this might be a huge problem

 

As I said my class is extending ItemPickaxe.

 

OnBlockDestroyed is part of ItemTool

 

ItemPickaxe extends ItemTool

 

Yes, that is how I overrode it.

Link to comment
Share on other sites

just for fun, try

 

ItemStack iss = (ItemStack)FurnaceRecipes.smelting().getSmeltingList().get(par3);

 

its basicly what vanilla is doing. also safecheck non-null of "iss"

how to debug 101:http://www.minecraftforge.net/wiki/Debug_101

-hydroflame, author of the forge revolution-

Link to comment
Share on other sites

just for fun, try

 

ItemStack iss = (ItemStack)FurnaceRecipes.smelting().getSmeltingList().get(par3);

 

its basicly what vanilla is doing. also safecheck non-null of "iss"

 

It seems like my problem is now in this part:

 

if (!par2World.isRemote && par2World.getGameRules().getGameRuleBooleanValue("doTileDrops"))
			{
				float f = 0.7F;
				double d0 = (double)(par2World.rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;
				double d1 = (double)(par2World.rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;
				double d2 = (double)(par2World.rand.nextFloat() * f) + (double)(1.0F - f) * 0.5D;
				EntityItem entityitem = new EntityItem(par2World, (double)x + d0, (double)y + d1, (double)z + d2, iss);
				entityitem.delayBeforeCanPickup = 10;
				par2World.spawnEntityInWorld(entityitem);
				dropModified = true;
			}

 

Its not actually spawning anything even though the code is run just fine. It spawns something once then stops

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • public class ManaOverlay extends Gui implements IIngameOverlay { private final Minecraft mc; private Font font = null; public int left_height = 39; public int right_height = 49; private RenderGameOverlayEvent eventParent; public static final ResourceLocation GUI_MANA_LOCATION = new ResourceLocation("textures/gui/icons.png"); private static final ManaOverlay INSTANCE = new ManaOverlay(Minecraft.getInstance()); public ManaOverlay(Minecraft p_93005_) { super(p_93005_); this.mc = Minecraft.getInstance(); this.font = mc.font; OverlayRegistry.registerOverlayTop("Mana ", (gui, mStack, partialTicks, screenWidth, screenHeight) -> { boolean isMounted = gui.minecraft.player.getVehicle() instanceof LivingEntity; if (!isMounted && !gui.minecraft.options.hideGui && gui.shouldDrawSurvivalElements()) { setupOverlayRenderState(true, false); renderMana(screenWidth, screenHeight, mStack); } }); } public void setupOverlayRenderState(boolean blend, boolean depthText) { setupOverlayRenderState(blend, depthText, GUI_MANA_LOCATION); } public void setupOverlayRenderState(boolean blend, boolean depthTest, @Nullable ResourceLocation texture) { if (blend) { RenderSystem.enableBlend(); RenderSystem.defaultBlendFunc(); } else { RenderSystem.disableBlend(); } if (depthTest) { RenderSystem.enableDepthTest(); } else { RenderSystem.disableDepthTest(); } if (texture != null) { RenderSystem.enableTexture(); bind(texture); } else { RenderSystem.disableTexture(); } RenderSystem.setShaderColor(1.0F, 1.0F, 1.0F, 1.0F); RenderSystem.setShader(GameRenderer::getPositionTexShader); } public static void init() { MinecraftForge.EVENT_BUS.register(INSTANCE); } public void renderMana(int width, int height, PoseStack mStack) { minecraft.getProfiler().push("mana"); Player player = (Player)this.minecraft.getCameraEntity(); RenderSystem.enableBlend(); int left = width / 2 + 91; int top = height - right_height ; boolean unused = false;// Unused flag in vanilla, seems to be part of a 'fade out' mechanic FoodData stats = minecraft.player.getFoodData(); int level = stats.getFoodLevel(); for (int i = 0; i < 10; ++i) { int idx = i * 2 + 1; int x = left - i * 8 - 9; int y = top; int icon = 16; byte background = 0; if (minecraft.player.hasEffect(MobEffects.HUNGER)) { icon += 36; background = 13; } if (unused) background = 1; //Probably should be a += 1 but vanilla never uses this if (player.getFoodData().getSaturationLevel() <= 0.0F && tickCount % (level * 3 + 1) == 0) { y = top + (random.nextInt(3) - 1); } blit(mStack, x, y, 16 + background * 9, 27, 9, 9); if (idx < level) blit(mStack, x, y, icon + 36, 27, 9, 9); else if (idx == level) blit(mStack, x, y, icon + 45, 27, 9, 9); } RenderSystem.disableBlend(); minecraft.getProfiler().pop(); } @Override public void render(ForgeIngameGui gui, PoseStack pStack, float partialTicks, int width, int height) { this.screenWidth = this.minecraft.getWindow().getGuiScaledWidth(); this.screenHeight = this.minecraft.getWindow().getGuiScaledHeight(); eventParent = new RenderGameOverlayEvent(pStack, partialTicks, this.minecraft.getWindow()); if (pre(ALL, pStack)) return; font = minecraft.font; this.random.setSeed(tickCount * 312871L); OverlayRegistry.orderedEntries().forEach(entry -> { try { if (!entry.isEnabled()) return; IIngameOverlay overlay = entry.getOverlay(); if (pre(overlay, pStack)) return; //overlay.render(this, pStack, partialTicks, screenWidth, screenHeight); post(overlay, pStack); } catch(Exception e) { } }); RenderSystem.setShaderColor(1.0F, 1.0F, 1.0F, 1.0F); post(ALL, pStack); } private boolean pre(RenderGameOverlayEvent.ElementType type, PoseStack mStack) { return MinecraftForge.EVENT_BUS.post(new RenderGameOverlayEvent.Pre(mStack, eventParent, type)); } private void post(RenderGameOverlayEvent.ElementType type, PoseStack mStack) { MinecraftForge.EVENT_BUS.post(new RenderGameOverlayEvent.Post(mStack, eventParent, type)); } private boolean pre(IIngameOverlay overlay, PoseStack mStack) { return MinecraftForge.EVENT_BUS.post(new RenderGameOverlayEvent.PreLayer(mStack, eventParent, overlay)); } private void post(IIngameOverlay overlay, PoseStack mStack) { MinecraftForge.EVENT_BUS.post(new RenderGameOverlayEvent.PostLayer(mStack, eventParent, overlay)); } private void bind(ResourceLocation res) { RenderSystem.setShaderTexture(0, res); } } Thanks to you, I was able to display it. However, the bar that uses the full stomach ground keeps shaking. I wonder why that is?  
    • It's the "Width on the screen" and "Height on the screen", so in this case the screen width and height.
    • I was able to post the 4 others, so they are on there now.
    • Could be "write", check vanilla for examples, or provide details of which version you're currently on.
    • I am trying to update a mod, and there does not seem to be any save() function in BlockEntity. What do I use instead?
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.