Jump to content

How to make a value for an overrides predicate in a json file to change the model of an item?


MaxAnimator

Recommended Posts

Hello there,

so I got an item, which can be thrown. The issues is, it's facing the wrong way when doing the charge animation when right click is held. I checked how Mojang did with the trident, they're using an overrides predicate with a special value called "throwing", that updates from 0.0 to 1.0 when the item is being thrown.

How could I make my own value just like they did? I checked the wiki but the docs are out of date.

Link to comment
Share on other sites

Hello again,

thanks for the info!

I got a problem though...
image.png.812e2e2bcf6661bd820e6fb1552c6b7a.png

It does that, with that:

public ModdedSpearItem(Properties properties)
	{
		super(properties);
		ItemModelsProperties.registerProperty(Registries.iron_spear.get(), new ResourceLocation("spear_throwing"), (itemstack, clientworld, livingentity) -> {
			return livingentity != null && livingentity.isHandActive() && livingentity.getActiveItemStack() == itemstack ? 1.0F : 0.0F;
		});
	}

and that's how my object is registered:

public static final RegistryObject<Item> iron_spear = ITEMS.register("iron_spear", () -> new ModdedSpearItem(new Item.Properties().group(Azure.TAB).maxStackSize(1)));

You got any idea of what I've done wrong?

Link to comment
Share on other sites

public Azure() {
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup);
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::doClientStuff);
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::enqueueWork);
        
        Registries.init();

        MinecraftForge.EVENT_BUS.register(this);
    }
private void enqueueWork(final FMLClientSetupEvent event)
    {
    	ItemModelsProperties.registerProperty(Registries.iron_spear.get(), new ResourceLocation("spear_throwing"), (itemstack, clientworld, livingentity) -> {
			return livingentity != null && livingentity.isHandActive() && livingentity.getActiveItemStack() == itemstack ? 1.0F : 0.0F;
		});
    }

Am I doing something wrong? The game launches but seems to ignore it.

Link to comment
Share on other sites

10 minutes ago, diesieben07 said:

You called your method enqueueWork... that's not going to do anything. You need to use enqueueWork on the event, because ItemModelsProperties is not threadsafe.

You also registered your property under the "minecraft" namespace, which is probably not what you intended (nor what you should do).

What do you mean "under the "minecraft" namespace"? And also how do I use the enqueueWork function?

Edited by MaxAnimator
Link to comment
Share on other sites

Ok I just got it to work... but it still doesn't do anything.

private void doClientStuff(final FMLClientSetupEvent event) {
    	event.enqueueWork(new Runnable() {
			public void run() {
				ItemModelsProperties.registerProperty(Registries.iron_spear.get(), new ResourceLocation("azure:spear_throwing"), (itemstack, clientworld, livingentity) -> {
					return livingentity != null && livingentity.isHandActive() && livingentity.getActiveItemStack() == itemstack ? 1.0F : 0.0F;
				});
			}
		});
    }

 

Link to comment
Share on other sites

33 minutes ago, diesieben07 said:

You said "it is not working".

Which behavior made you say that?

The game seems to ignore it. There's no modification made at all when in game; I checked my model and it does work; so it's coming from this piece of code:

private void doClientStuff(final FMLClientSetupEvent event) {
    	event.enqueueWork(new Runnable() {
			public void run() {
				ItemModelsProperties.registerProperty(Registries.iron_spear.get(), new ResourceLocation("azure:spear_throwing"), (itemstack, clientworld, livingentity) -> {
					return livingentity != null && livingentity.isHandActive() && livingentity.getActiveItemStack() == itemstack ? 1.0F : 0.0F;
				});
			}
		});
    }

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.