Jump to content

1.16.4 craft item


arturkr

Recommended Posts

How to prevent an item from being wasted during crafting? Something like crafting a cake. I know that a bucket of milk is prescribed, that they do not waste when crafting. But I can't do this so that the item is not spent during crafting. Ideally, make it so that with each craft -1 durability. I started digging towards

ActionResult <ItemCraftedEvent>

but to no avail so far. Help me please

 

translated by Google Translate))

Link to comment
Share on other sites

1 hour ago, arturkr said:

Is it possible in more detail?😅
Just starting to learn modding for mc

If it's a custom Item that you're implementing you'll need to create a class for it, and override the hasContainerItem and getContainerItem methods, in the getContainerItem you can return the item you want to appear in the crafting slot once the recipe is crafted, in this case you'd want to return the itemStack and damage by one point

if it's a vanilla Item you want that behaviour for... I don't know how to help you

Link to comment
Share on other sites

10 hours ago, kiou.23 said:

If it's a custom Item that you're implementing you'll need to create a class for it, and override the hasContainerItem and getContainerItem methods, in the getContainerItem you can return the item you want to appear in the crafting slot once the recipe is crafted, in this case you'd want to return the itemStack and damage by one point

if it's a vanilla Item you want that behaviour for... I don't know how to help you

Yes, this is for a custom item. But I don't know how to override yet ...


My ItemInit.java

public class ItemInit {

	public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS,
			Main.MOD_ID);
	public static final RegistryObject<Item> pounder = ITEMS.register("pounder", 
			() -> new Item(new Item.Properties().group(ItemGroup.TOOLS).maxStackSize(1).setNoRepair().maxDamage(63)));
}

My Main.java

public class Main {
	public static Random random = new Random();
	public static final Logger LOGGER = LogManager.getLogger();
	public static final String MOD_ID = "magic";
	public Main() {
		IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus();
		bus.addListener(this::setup);

		ItemInit.ITEMS.register(bus);
		
		MinecraftForge.EVENT_BUS.register(this);
	}
	private void setup(final FMLCommonSetupEvent event) {

	}
}

 

Can you tell me where to override?😅

Link to comment
Share on other sites

3 minutes ago, diesieben07 said:

You need a class that extends Item.

 

public class ItemInit extends Item{
	
	public ItemInit(Properties properties) {
		super(properties);
	}
	
	
	public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS,
			Main.MOD_ID);
	
	public static final RegistryObject<Item> pounder = ItemInit.ITEMS.register("pounder", 
			() -> new Item(new Item.Properties().group(ItemGroup.TOOLS).maxStackSize(1).setNoRepair().maxDamage(63)));
	
	
	@Override
    public ItemStack getContainerItem(ItemStack stack) { 
      
        ItemStack ret = stack.copy();
      
        if(ret.attemptDamageItem(1, Main.random, null)) 
          
            return ItemStack.EMPTY; 
      
        else
          
            return ret;
      
    }
	
}

But when crafting, the item is still spent

 

Link to comment
Share on other sites

27 minutes ago, arturkr said:

But when crafting, the item is still spent

Make a seperate class that extends Item, e.g. MyItem and then use that when registering your item instead of using the Item class:

public static final RegistryObject<Item> pounder = ItemInit.ITEMS.register("pounder", 
			() -> new MyItem(new Item.Properties().group(ItemGroup.TOOLS).maxStackSize(1).setNoRepair().maxDamage(63)));

 

Link to comment
Share on other sites

28 minutes ago, diesieben07 said:

Why did you make ItemInit extend Item? Apart from the fact that this makes no sense - you never register any instances of this new item class.

register in Main

public class Main {
	public static Random random = new Random();
	public static final Logger LOGGER = LogManager.getLogger();
	public static final String MOD_ID = "magic";
	public Main() {
		IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus();
		bus.addListener(this::setup);
		
		ItemInit.ITEMS.register(bus);
		Pounder.ITEMS.register(bus);
		BlockInit.BLOCKS.register(bus);
		
		MinecraftForge.EVENT_BUS.register(this);
	}
	private void setup(final FMLCommonSetupEvent event) {
		
	}
}

 

 

 

 

8 minutes ago, justAm0dd3r said:

Make a seperate class that extends Item, e.g. MyItem and then use that when registering your item instead of using the Item class:


public static final RegistryObject<Item> pounder = ItemInit.ITEMS.register("pounder", 
			() -> new MyItem(new Item.Properties().group(ItemGroup.TOOLS).maxStackSize(1).setNoRepair().maxDamage(63)));

 

I didn't succeed, as you suggested. The instrument was not registered. I did it differently and it appeared in the game, but it still disappears when crafting

 

public class Pounder extends Item{
	
	public Pounder(Properties properties) {
		super(properties);
	}
	public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS,
			Main.MOD_ID);
	
	public static final RegistryObject<Item> pounder = Pounder.ITEMS.register("pounder", 
			() -> new Item(new Item.Properties().group(ItemGroup.TOOLS).maxStackSize(1).setNoRepair().maxDamage(63)));
	
	
	@Override
    public ItemStack getContainerItem(ItemStack stack) { 
      
        ItemStack ret = stack.copy();
      
        if(ret.attemptDamageItem(1, Main.random, null)) 
          
            return ItemStack.EMPTY; 
      
        else
          
            return ret;
      
    }
}

 

Link to comment
Share on other sites

2 minutes ago, diesieben07 said:

You clearly do not know enough about Java to start modding. Basic Java knowledge (what are classes, how to override methods) is required.

It's true. I know C ++ well and I thought that there was not much difference there ... But Java is just a different world)
But still, can you help with the code?

Link to comment
Share on other sites

3 minutes ago, diesieben07 said:

You need to make a class that extends Item. You need to override getContainerItem and hasContainerItem. You then need to actually use this class.

AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA. You understand that I am stupid and do not know Java.
Could you write for me where to click and where to write?)

Link to comment
Share on other sites

46 minutes ago, diesieben07 said:

No.

Ha-ha

ItemInit.java
  
public class ItemInit{
	
	public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS,
			Main.MOD_ID);

	public static final RegistryObject<Item> pounder = ItemInit.ITEMS.register("pounder", 
			() -> new Pounder(new Item.Properties().group(ItemGroup.TOOLS).maxStackSize(1).setNoRepair().maxDamage(63)));
  
}

 

Pounder.java

public class Pounder extends Item{
	
	public Pounder(Properties properties)
    {
        super(properties);
    }	
	@Override
    public boolean hasContainerItem(ItemStack stack) {  
        return true;
    }
    @Override
    public ItemStack getContainerItem(ItemStack stack) {   
        ItemStack ret = stack.copy(); 
        if(ret.attemptDamageItem(1, Main.random, null)) 
            return ItemStack.EMPTY;
        else
            return ret;
      
    }
}

 

Main.java


public class Main {
	public static Random random = new Random();
	public static final Logger LOGGER = LogManager.getLogger();
	public static final String MOD_ID = "magic";
	public Main() {
		IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus();
		bus.addListener(this::setup);
		
		ItemInit.ITEMS.register(bus);
		
		MinecraftForge.EVENT_BUS.register(this);
	}
	private void setup(final FMLCommonSetupEvent event) {
		
	}
}

 

ITS WORK

238101931_.png.5062aeb3d7010eedc08455b25ce0fb28.png

 

and in recipes need add for item "data": 32767.


Yeeeey

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I created my own modpack just for mainly entities right now and im having issues with only a handful of the mobs. is there a way someone could help go over my work and check whats wrong? its a file 
    • Hi, I have a problem with my minecraft: I'm in forge 1.20.1 and I have several mods installed, (link to photo below) and after a while, at random, the game freezes, I can't play or move but I can still hear the game in the background, there's just the image that remains, (problematic when I fight a fire dragon :() ) can you help me? my mods:   zmedievalmusic-1.20.1-2.1 treeharvester-1.20.1-8.7 tctcore-1.0-1.20.1 specialmobs-1.20.1-3.1.3 simpleOres2-1.20.1-6.0.0.2 OldCombatMod_1.20x.jar oculus-mc1.20.1-1.7.0 medieval_buildings-forge-1.0.2 matmos-5.2-forge-1.20.1 journeymap-1.20.1-5.9.18-forge jei-1.20.1-forge-15.8.0.11 iceandfire-2.1.13-1.20.1-beta-4 healthindicatortxf-1.20.1-1.2.2-forge geckolib-forge-1.20.1-4.4.7 embeddium-0.3.25+mc1.20.1 dynamiclights-1.20.1-1.2 cupboard-1.20.1-2.7 crust-1.20.1-2.3.3 collective-1.20.1-7.71 citadel-2.4.9-1.20.1 bucketlib-1.20.1-2.3.0.5 born_in_chaos_(Forge)1.20.1_1.3.1 betterfpsdist-4.4   forge 1.20.1 (47.3.5) i fink it's because of ice and fire mod, but i want it thank to help me! i hope you are well Translated with DeepL.com (free version)
    • Long story short, my girlfriend found a mod for Minecraft she wanted but it was for Pocket Edition. So I took it on myself to try and port it over and it has gone fairly well until the point I had to work with particles. Basically, I had it working using animateTick but I was checking if the block name contained a certain value to specify the lantern's color and as such choose which particle to spawn. I was initially trying to do this via the constructor, but this value hasn't been initialized that early and I can't seem to find some event or method to override which ideally happens when the block is loaded/placed. Performing upwards to 16 string comparisons per tick isn't exactly efficient so I want to try and optimize this. By the time animateTick starts executing, the name is properly initialized and I can use that to set my property accordingly. But this is where I'm starting to run into a weird issue. This is my current code; public void animateTick(BlockState state, Level level, BlockPos pos, RandomSource randomSource) { // It's not fully initialized yet... I guess? if (this.getName().toString().contains("air")) return; if (!state.getValue(COLOR_SET)) { // This method doesn't work at all, neither states are updated var blockState = level.getBlockState(pos); blockState.setValue(LANTERNCOLOR, this.getBlockColor()); blockState.setValue(COLOR_SET, true); level.setBlockAndUpdate(pos, blockState); } double d0 = (double)pos.getX() + randomSource.nextDouble(); double d1 = (double)pos.getY() + randomSource.nextDouble(); double d2 = (double)pos.getZ() + randomSource.nextDouble(); // No idea how to better do this without adding 5 000 new files if (level.getBlockState(pos).getValue(LANTERNCOLOR) == DyeColor.WHITE.getId()) level.addParticle(PaperLanterns.LANTERN_GLOW_WHITE.get(), d0, d1, d2, 0.0D, ThreadLocalRandom.current().nextDouble(-0.10D, 0.0D), 0.0D); if (level.getBlockState(pos).getValue(LANTERNCOLOR) == DyeColor.BLUE.getId()) level.addParticle(PaperLanterns.LANTERN_GLOW_BLUE.get(), d0, d1, d2, 0.0D, ThreadLocalRandom.current().nextDouble(-0.10D, 0.0D), 0.0D); } COLOR_SET is a BooleanProperty meant to ensure this is only executed once, for performance reasons. LANTERNCOLOR is currently an IntegerProperty (it used to be an EnumProperty, but been changing stuff around trying to fix the issue) which specified the color. My issue is that I can only set one of these states, for example like this; if (!state.getValue(COLOR_SET)) { // LANTERNCOLOR is set successfully, but not COLORSET level.setBlockAndUpdate(pos, state.setValue(LANTERNCOLOR, this.getBlockColor())); level.setBlockAndUpdate(pos, state.setValue(COLOR_SET, true)); } // OR if (!state.getValue(COLOR_SET)) { // COLOR_SET is set successfully, but not LANTERNCOLOR level.setBlockAndUpdate(pos, state.setValue(COLOR_SET, true)); level.setBlockAndUpdate(pos, state.setValue(LANTERNCOLOR, this.getBlockColor())); } So I can only seemingly set one state at a time, I now know that my issue wasn't in my usage of EnumProperty so once I solve this I will be going back to that and using a switch-case. But I would love some pointers as to why I can only set one of these states. Is it because once you set it and update it, that instance of the block is now considered dirty and as such accepts no more state changes or something? I know the code's a bit all over the place with how I retrieve the states. I'm still learning and have been testing a bunch trying to get this to work, but have now found the issue but no idea how to solve it 😅 If there's a better way of setting this LANTERNCOLOR property and ensuring it's only executed once, that would be even better. The sole purpose of this is to choose which particle to spawn, since the particle colors are hardcoded.
    • Hi, I have a problem with my minecraft: I'm in forge 1.20.1 and I have several mods installed, (link to photo below) and after a while, at random, the game freezes, I can't play or move but I can still hear the game in the background, there's just the image that remains, (problematic when I fight a fire dragon :() ) can you help me? my mods: file:///C:/Users/meria/Pictures/Capture.PNG forge 1.20.1 (47.3.5) i fink it's because of ice and fire mod, but i want it thank to help me! i hope you are well Translated with DeepL.com (free version)
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.