(1.16.2) How do I use onPlayerTick?

[e2rifia 0]

I fiddled around, trying to somehow get onPlayerTick to do something.

This is when I tried to make my head a flamethrower, but it doesn't spawn fireballs.

What did I do wrong? Please point it out.

 

@Mod(the class below)
@Mod.EventBusSubscriber(modid = the class below)
a public class {

 

@SubscribeEvent
    public void onPlayerTick(TickEvent.PlayerTickEvent event) {
        ServerPlayerEntity player = (ServerPlayerEntity) event.player;

        Vector3d v3 = player.getLook(1);
        SmallFireballEntity fireball = new SmallFireballEntity(player.getEntityWorld(), player.getPosX(), player.getPosY() + player.getEyeHeight(), player.getPosZ(), v3.x, v3.y, v3.z);
        fireball.setShooter(player);
        player.getEntityWorld().addEntity(fireball);
    }

Edited January 16 by e2rifia

[diesieben07 7696]

13 minutes ago, e2rifia said:

ServerPlayerEntity player = (ServerPlayerEntity) event.player;

This will immediately crash the game, there are not just server side entities. The fact that it doesn't mean your event handler is not even running. It is not running, because @EventBusSubscriber only works with static event handler methods.

[e2rifia 0]

One step ahead?

 

@SubscribeEvent
    public void clientTickEnd(TickEvent.PlayerTickEvent event){
        if (event.phase != Phase.START || event.player == null) return;
        PlayerEntity player = event.player;
        Vector3d v3 = player.getLook(1);
        SmallFireballEntity fireball = new SmallFireballEntity(player.getEntityWorld(), player.getPosX(), player.getPosY() + player.getEyeHeight(), player.getPosZ(), v3.x, v3.y, v3.z);
        fireball.setShooter(player);
        player.getEntityWorld().addEntity(fireball);

}

 

Should I move it out of @EventBusSubscriber to somewhere else?

Edited January 16 by e2rifia

[diesieben07 7696]

15 minutes ago, e2rifia said:

One step ahead?

?

 

15 minutes ago, e2rifia said:

@SubscribeEvent
    public void clientTickEnd(TickEvent.PlayerTickEvent event){
        if (event.phase != Phase.START || event.player == null) return;
        PlayerEntity player = event.player;
        Vector3d v3 = player.getLook(1);
        SmallFireballEntity fireball = new SmallFireballEntity(player.getEntityWorld(), player.getPosX(), player.getPosY() + player.getEyeHeight(), player.getPosZ(), v3.x, v3.y, v3.z);
        fireball.setShooter(player);
        player.getEntityWorld().addEntity(fireball);

}

Now you are spawning the entity on both client and server. You need to check World#isRemote and only spawn it on the server.

 

15 minutes ago, e2rifia said:

Should I move it out of @EventBusSubscriber to somewhere else?

@EventBusSubscriber is fine, you just need to user static methods with it.

[e2rifia 0]

It works! It works!

 

public static void onPlayerTick(TickEvent.PlayerTickEvent event){
        if (event.phase != Phase.START || event.player == null) return;
        if (!event.player.world.isRemote) {
        PlayerEntity player = event.player;
        Vector3d v3 = player.getLook(1);
        SmallFireballEntity fireball = new SmallFireballEntity(player.getEntityWorld(), player.getPosX(), player.getPosY() + player.getEyeHeight(), player.getPosZ(), v3.x, v3.y, v3.z);
        fireball.setShooter(player);
        player.getEntityWorld().addEntity(fireball);
        }
    }