(1.16.2) Making a new capability (3)

[e2rifia 0]

When I asked console:

System.out.println(player.getCapability(MagicCapability.MAGIC).orElse(null) == null);

"true"

 

What did I do or not do, that made this capability not loaded?

Please point it out. I have no clue.

 

public static void setup (final FMLCommonSetupEvent event){
        MinecraftForge.EVENT_BUS.register(new Fool());
        MagicCapability.register();
    }

 

public class MagicCapability
{
    @CapabilityInject(IMaxMP.class)
    public static Capability<IMaxMP> MAGIC = null;

    public static void register()
    {
        CapabilityManager.INSTANCE.register(IMaxMP.class, new IStorage<IMaxMP>()
        {
            @Override
            public INBT writeNBT(Capability<IMaxMP> capability, IMaxMP instance, Direction side)
            {
                return IntNBT.valueOf(instance.getManaStored());
            }

            @Override
            public void readNBT(Capability<IMaxMP> capability, IMaxMP instance, Direction side, INBT nbt)
            {
                ((MaxMP)instance).addMana(((IntNBT)nbt).getInt());
            }
        },
        () -> new MaxMP(null));
    }
}

public interface IMaxMP
{
	public int getManaStored();
	public void addMana(int amount);
	public void setMana(int amount);
	public boolean useMana(int amount);
	public int getMaxMana();
	public void addMaxMana(int amount);
	public void setMaxMana(int amount);
}

public class Fool {

	 @SubscribeEvent
	 public void attatchCapability(AttachCapabilitiesEvent <Entity> event)
	 {
		 ServerPlayerEntity player;
		 if (event.getObject() instanceof ServerPlayerEntity) {
			 player = (ServerPlayerEntity) event.getObject();
		 } else {
			 return;
		 }
		 LazyOptional<IMaxMP> optPlayer = player.getCapability(MagicCape.MAGIC);
		 if (!optPlayer.isPresent()) {
			 event.addCapability(new ResourceLocation(Chants.MODID, "magic_capability"), new Maou(player));
		 }
	 }
}

public class Maou implements ICapabilityProvider, ICapabilitySerializable<CompoundNBT>
{
	IMaxMP storage;

	public Maou (ServerPlayerEntity serverPlayerEntity) {
		storage = new MaxMP(serverPlayerEntity);
	}
	
	@Override
	public <T> LazyOptional<T> getCapability(Capability<T> cap, Direction side) {
		if (cap == MagicCape.MAGIC)
			return (LazyOptional<T>) LazyOptional.of(() -> storage);
		return LazyOptional.empty();
	}

	@Override
	public CompoundNBT serializeNBT() {
		CompoundNBT ret = new CompoundNBT();
		ret.putInt("magicStored", storage.getManaStored());
		return ret;
	}

	@Override
	public void deserializeNBT(CompoundNBT nbt) {
		int magic = nbt.getInt("magicStored");
		storage.addMana(magic);
	}
}

 

Edited January 17 by e2rifia

[poopoodice 117]

Is the event called? Have you attach the capability to the players?

[e2rifia 0]

17 minutes ago, poopoodice said:

Is the event called? Have you attach the capability to the players?

I think so.

[diesieben07 7695]

• Do not create a new LazyOptional every time. This defeats the purpose of LazyOptional.

• 1 hour ago, e2rifia said:

  System.out.println(player.getCapability(MagicCapability.MAGIC).orElse(null) == null);

  "true"

  More context is needed. Where is this code located?

• 36 minutes ago, e2rifia said:

  I think so.

  Thinking is not helpful here. Verify using the debugger.

[e2rifia 0]

31 minutes ago, diesieben07 said:

• More context is needed. Where is this code located?

@Mod(Main.MODID)
@Mod.EventBusSubscriber(modid = Main.MODID)
public class Main {
    public static final String MODID = "main";

@SubscribeEvent
    public static void onServerStarting(FMLServerStartingEvent event) {
        CommandDispatcher<CommandSource> d = event.getServer().getCommandManager().getDispatcher();

d.register(Commands.literal("tellme").requires(source -> {
            try {
                return source.asPlayer() != null;
            } catch(CommandSyntaxException e) {
                return false;
            }
        }).executes(command -> {
            ServerPlayerEntity player = command.getSource().asPlayer();
            System.out.println(player.getCapability(MagicCape.MAGIC).orElse(null) == null);
            return 1;
        }));

42 minutes ago, diesieben07 said:

• Thinking is not helpful here. Verify using the debugger.

I see that @SubscribeEvent setup() is not called at all.

[diesieben07 7695]

1 minute ago, e2rifia said:

I see that @SubscribeEvent setup() is not called at all.

How did you register it to the event bus?

[e2rifia 0]

@Mod(Main.MODID)
@Mod.EventBusSubscriber(modid = Main.MODID)
public class Main{
    public static final String MODID = "main";

@SubscribeEvent 
    public static void setup(final FMLCommonSetupEvent event) {
        System.out.println("I'm setting up!");
        MinecraftForge.EVENT_BUS.register(new CapabilityAttatcher());
        MagicCapability.register();
    }

}

 

Edited January 17 by e2rifia

[diesieben07 7695]

@EventBusSubscriber subscribes to the forge bus by default, but FMLCommonSetupEvent is fired on the mod bus.

 

 

Please use the code format when posting code.

[e2rifia 0]

 

5 minutes ago, diesieben07 said:

@EventBusSubscriber subscribes to the forge bus by default, but FMLCommonSetupEvent is fired on the mod bus.

I should separate @Mod and @EventBusSubscriber?

[diesieben07 7695]

1 minute ago, e2rifia said:

I should separate @Mod and @EventBusSubscriber?

You don't need to, no. Why?

[e2rifia 0]

9 minutes ago, diesieben07 said:

You don't need to, no. Why?

Is @EventBusSubscriber what's getting in the way of setup?

It didn't work...

Edited January 17 by e2rifia

[loordgek 176]

24 minutes ago, e2rifia said:

It didn't work...

what dint work, show your new code

[e2rifia 0]

40 minutes ago, diesieben07 said:

@EventBusSubscriber subscribes to the forge bus by default, but FMLCommonSetupEvent is fired on the mod bus.

@Mod(Main.MODID)
//@Mod.EventBusSubscriber(modid = Main.MODID)
public class Main{
    public static final String MODID = "main";

@SubscribeEvent 
    public static void setup(final FMLCommonSetupEvent event) {
        System.out.println("I'm setting up!");
        MinecraftForge.EVENT_BUS.register(new CapabilityAttatcher());
        MagicCapability.register();
    }

}

 

[Linky132 1]

I could be wrong, but I think you might need to add this code in the constructor:

FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup);

And you may need to change the setup method to non-static.

Edited January 17 by Linky132

[diesieben07 7695]

4 hours ago, e2rifia said:

@Mod(Main.MODID)
//@Mod.EventBusSubscriber(modid = Main.MODID)
public class Main{
    public static final String MODID = "main";

@SubscribeEvent 
    public static void setup(final FMLCommonSetupEvent event) {
        System.out.println("I'm setting up!");
        MinecraftForge.EVENT_BUS.register(new CapabilityAttatcher());
        MagicCapability.register();
    }

}

 

So now you just removed the @EventBusSubscriber annotation.

I did not tell you to do this.