[1.16.4] what difference between custom slots and EquipmentSlotType

[Klarks 0]

In my container class ive created slots 

private static final EquipmentSlotType[] VALID_EQUIPMENT_SLOTS = new EquipmentSlotType[]{EquipmentSlotType.HEAD, EquipmentSlotType.CHEST, EquipmentSlotType.LEGS, EquipmentSlotType.FEET};

 
en.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY).ifPresent(h -> {
     int index =0;
     for(int i = 8;i < 64;i+=18)
     {
         final EquipmentSlotType equipmentslottype = VALID_EQUIPMENT_SLOTS[index];
         addSlot(new SlotItemHandler(h,index,8,i)
         {
             public int getSlotStackLimit() {
                 return 1;
             }

             public boolean isItemValid(ItemStack stack) {
                 return stack.canEquip(equipmentslottype,en);
             }


             public boolean canTakeStack(PlayerEntity playerIn) {
                 ItemStack itemstack = this.getStack();
                 return !itemstack.isEmpty() && !playerIn.isCreative() && EnchantmentHelper.hasBindingCurse(itemstack) ? false : super.canTakeStack(playerIn);
             }

             @OnlyIn(Dist.CLIENT)
             public Pair<ResourceLocation, ResourceLocation> getBackground() {
                 return Pair.of(MyModContainer.LOCATION_BLOCKS_TEXTURE, MyModContainer.ARMOR_SLOT_TEXTURES[equipmentslottype.getIndex()]);
             }
         });
    index++;
     }
});

 

In my entity class i can use hadler to set and get my items from slots

    public ItemStackHandler handler;

    private ItemStackHandler getHandler()
    {
        if(handler == null)
        {
            handler = new ItemStackHandler(4);
        }
        return handler;
    }




    @Override
    public ILivingEntityData onInitialSpawn(IServerWorld worldIn, DifficultyInstance difficultyIn, SpawnReason reason, @Nullable ILivingEntityData spawnDataIn, @Nullable CompoundNBT dataTag) {
handler.setStackInSlot(0,new ItemStack(Items.DIAMOND_HELMET));




        return super.onInitialSpawn(worldIn, difficultyIn, reason, spawnDataIn, dataTag);
    }

 

But i cant get an itemstack from my handler from my layer model class. the game crashes. but i can get it from EquipmentSlotType but i dont need it because i store items in my container class slots

public class top1Layer  extends LayerRenderer<MyEntity, MobModel<MyEntity>> {
    private static final ResourceLocation TEXTURE_TOP1 = new ResourceLocation(Main.MODID,"textures/entity/mob/monster.png");

    public top1Layer(IEntityRenderer<MyEntity, MobModel<MyEntity>> entityRendererIn) {
        super(entityRendererIn);
    }





    @Override
    public void render(MatrixStack matrixStackIn, IRenderTypeBuffer bufferIn, int packedLightIn, MyEntity entitylivingbaseIn, float limbSwing, float limbSwingAmount, float partialTicks, float ageInTicks, float netHeadYaw, float headPitch) {
       ItemStack itemstack = entitylivingbaseIn.handler.getStackInSlot(0);
    }
}

[diesieben07 7826]

All living entities already have an armor and held item inventory, you don't need to add it manually. Look at LivingEntity#getCapability, it will return you IItemHandler instances for those inventories.

[Klarks 0]

Return here?

public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {


    if(cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
    {
      
  return  LazyOptional.of(() -> (T) getHandler()); //Here?
    }
    return super.getCapability(cap, side);
}

[diesieben07 7826]

I don't understand that question.

[Klarks 0]

should  this line return me IItemHandler instances for armor and held inventories?

return  LazyOptional.of(() -> (T) getHandler());

Edited January 21 by Klarks

[diesieben07 7826]

No, that is your IItemHandler. You need to look at LivingEntity - it already has these inventories.

[Klarks 0]

those handlers ?

public <T> net.minecraftforge.common.util.LazyOptional<T> getCapability(net.minecraftforge.common.capabilities.Capability<T> capability, @Nullable Direction facing) {
   if (this.isAlive() && capability == net.minecraftforge.items.CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) {
      if (facing == null) return handlers[2].cast();
      else if (facing.getAxis().isVertical()) return handlers[0].cast();
      else if (facing.getAxis().isHorizontal()) return handlers[1].cast();
   }
   return super.getCapability(capability, facing);
}

 

[diesieben07 7826]

Yes, exactly.

[Klarks 0]

I dont understand how i can get them from my class

[diesieben07 7826]

Call getCapability.

[Klarks 0]

Like this

public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {


    if(cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
    {
        return getCapability(cap,side).cast();
     
    }
    return super.getCapability(cap, side);
}

[diesieben07 7826]

That's an infinite loop.

Why are you overriding getCapability at all?

[Klarks 0]

To get my itemhandler.i need to get default living entity slots and my custom slots

[diesieben07 7826]

Then you need an IItemHandler that combines the default slots (call super.getCapability to get them) and your own.

[Klarks 0]

Like this?
 

public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {


    if(cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
    {
        super.getCapability(cap, side);
        return  LazyOptional.of(() -> (T) getHandler());
    }
    return super.getCapability(cap, side);
}

[diesieben07 7826]

Please learn basic Java.

That completely ignores the result of super.getCapability.

[Klarks 0]

I dont even understand what type of value is this. What LazyOptional do, how it works and how i can get ItemHandler from this. 

[Klarks 0]

Do i need to return a list of ItemHandlers?

[diesieben07 7826]

LazyOptional is just that: An optional value that is computed lazily.

 

4 minutes ago, Klarks said:

Do i need to return a list of ItemHandlers?

No, you need to create a combined IItemHandler by using CombinedInvWrapper.

This should not happen inside getCapability, you should create this handler and the LazyOptional once (in your class' constructor) and then just return the value in getCapability.

[Klarks 0]

I guess i did it.

public <T> LazyOptional<T> create(LivingEntity entity)
{
    LazyOptional<IItemHandlerModifiable>[] ret = new LazyOptional[2];
    ret[0] = LazyOptional.of(() ->  getHandler());
    ret[1] = LazyOptional.of(() -> new EntityArmorInvWrapper(entity));
    return LazyOptional.of(() -> (T)new CombinedInvWrapper(ret[0].orElse(null), ret[1].orElse(null)));
}

public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {


    if(cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
    {
      //  super.getCapability(cap, side).;
        return create(this);
    }
    return super.getCapability(cap, side);
}

 

But how would a slot know if its a default or a custom slot
 

en.getCapability(CapabilityItemHandler.ITEM_HANDLER_CAPABILITY).ifPresent(h -> {
    int index = 0;
    for(int i =8;i < 63;i+=18)
    {
        final EquipmentSlotType equipmentslottype = VALID_EQUIPMENT_SLOTS[index];
        addSlot(new SlotItemHandler(h,index,8,i){

            public int getSlotStackLimit() {
                return 1;
            }


            public boolean isItemValid(ItemStack stack) {
                return stack.canEquip(equipmentslottype, en);
            }

            public boolean canTakeStack(PlayerEntity playerIn) {
                ItemStack itemstack = this.getStack();
                return !itemstack.isEmpty() && !playerIn.isCreative() && EnchantmentHelper.hasBindingCurse(itemstack) ? false : super.canTakeStack(playerIn);
            }

            @OnlyIn(Dist.CLIENT)
            public Pair<ResourceLocation, ResourceLocation> getBackground() {
                return Pair.of(PlayerContainer.LOCATION_BLOCKS_TEXTURE, MyModContainer.ARMOR_SLOT_TEXTURES[equipmentslottype.getIndex()]);
            }
        });
        index++;
    }
});

[diesieben07 7826]

You are not doing what I told you to do:

1. You are not creating your handler and LazyOptional in the constructor.
2. You are not using super.getCapability to get the default handlers.

Additionally:

• Please use @Override when overriding methods.
• Do not use @OnlyIn.

• 20 minutes ago, Klarks said:

  for(int i =8;i < 63;i+=18)

  This is only four slots. Do you actually have any slots besides the armor and hand inventory?

[Klarks 0]

I created now.

public MyEntity(EntityType<? extends MyEntity> type, World worldIn)
{
    super(type, worldIn);
   handler = getHandler();
    optional = create(this);
}

do i need this?

public <T> LazyOptional<T> create(LivingEntity entity)
{
    LazyOptional<IItemHandlerModifiable>[] ret = new LazyOptional[2];
    ret[0] = LazyOptional.of(() ->  getHandler());
    ret[1] = LazyOptional.of(() -> new EntityArmorInvWrapper(entity));
    return LazyOptional.of(() -> (T)new CombinedInvWrapper(ret[0].orElse(null), ret[1].orElse(null)));
}

 

here i got default handler 
 

public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) {


    if(cap == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
    {
        defHandler = (ItemStackHandler) super.getCapability(cap,side).orElse(null);
        return create(this);
    }
    return super.getCapability(cap, side);
}

public ItemStack func_213803_dV() {
    return this.getItemStackFromSlot(EquipmentSlotType.CHEST);
}

Am i going right?

[Draco18s 2427]

31 minutes ago, Klarks said:

return LazyOptional.of(() -> (T)new CombinedInvWrapper(ret[0].orElse(null), ret[1].orElse(null)));

Why did you create two lazy optionals, then unbox them to pass into the CombinedInvWrapper?

(Not to mention using an array to store the local results? Why!?)

return LazyOptional.of(() -> (T)new CombinedInvWrapper(getHandler(), new EntityArmorInvWrapper(entity)));

Edited January 21 by Draco18s

[Klarks 0]

If super.getCapability give me the default handlers so what new EntityArmorInvWrapper(entity) do 

[Klarks 0]

Why i need cal super.getCapability? Is new EntityArmorInvWrapper(entity) doing same thing?

LivingEntity. it returns handlers which are LazyOptional<IItemHandlerModifiable>[] and they contains same things what i have already created

private final net.minecraftforge.common.util.LazyOptional<?>[] handlers = net.minecraftforge.items.wrapper.EntityEquipmentInvWrapper.create(this);

public <T> net.minecraftforge.common.util.LazyOptional<T> getCapability(net.minecraftforge.common.capabilities.Capability<T> capability, @Nullable Direction facing) {
   if (this.isAlive() && capability == net.minecraftforge.items.CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) {
      if (facing == null) return handlers[2].cast();
      else if (facing.getAxis().isVertical()) return handlers[0].cast();
      else if (facing.getAxis().isHorizontal()) return handlers[1].cast();
   }
   return super.getCapability(capability, facing);

 

EntityEquipmentInvWrapper

public static LazyOptional<IItemHandlerModifiable>[] create(LivingEntity entity)
{
    @SuppressWarnings("unchecked")
    LazyOptional<IItemHandlerModifiable>[] ret = new LazyOptional[3];
    ret[0] = LazyOptional.of(() -> new EntityHandsInvWrapper(entity));
    ret[1] = LazyOptional.of(() -> new EntityArmorInvWrapper(entity));
    ret[2] = LazyOptional.of(() -> new CombinedInvWrapper(ret[0].orElse(null), ret[1].orElse(null)));
    return ret;
}