[1.16.5] Help with custom Glass Block

[Luis_ST 6]

I want to creat a block wich is translucent but disable sky light through the block

i just creat this:

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/blocks/TintedGlass.java

but when i stand in a cube of my glass there is a skylight:

 

Edited January 22 by Luis_ST

[Beethoven92 75]

Override the getOpacity in your glass block class, look at the super method implementation to see how opacity is normally handled. It should be pretty easy to see what to put in your override

[Luis_ST 6]

On 1/24/2021 at 2:25 AM, Beethoven92 said:

Override the getOpacity in your glass block class, look at the super method implementation to see how opacity is normally handled. It should be pretty easy to see what to put in your override

i just looked at it but is this not controlled by method propagatesSkylightDown beacause:

and it dosent work.

   @Deprecated
   public int getOpacity(BlockState state, IBlockReader worldIn, BlockPos pos) {
      if (state.isOpaqueCube(worldIn, pos)) {
         return worldIn.getMaxLightLevel();
      } else {
         return state.propagatesSkylightDown(worldIn, pos) ? 0 : 1;
      }
   }

this is currently my block class:

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/blocks/TintedGlass.java

Edited January 25 by Luis_ST

[Draco18s 2414]

You do know what that returned int does, right?

[Luis_ST 6]

5 hours ago, Draco18s said:

You do know what that returned int does, right?

I think yes the int returned is the light going through the block

so 0 will retrun no light through the block

or is that wrong?

Edited January 25 by Luis_ST

[Draco18s 2414]

Lets check the original function.

"If the block is opaque, return the maximum light value. Otherwise if sky light is supposed to propagate downwards, return 0. Otherwise return 1."

 

🤔

[Luis_ST 6]

8 hours ago, Draco18s said:

If the block is opaque, return the maximum light value.

okay i understand but

8 hours ago, Draco18s said:

Otherwise if sky light is supposed to propagate downwards, return 0. Otherwise return 1.

if i understand this correctly i have to return 0.

 

but when i set the value to 0 it dosent work and when i set it to 1 (for testing) it also dosent work

[Draco18s 2414]

On 1/22/2021 at 1:35 AM, Luis_ST said:

but disable sky light through the block

7 hours ago, Luis_ST said:

if i understand this correctly i have to return 0.

"supposed to propagate downwards" -> lets sky light through it.

This is clearly not the effect you want. The point wasn't to follow the existing logic to see what the default method returns for your block (because duh, the default logic doesn't work for you), it was to figure out how opaque blocks block skylight.

Edited January 26 by Draco18s

[Luis_ST 6]

16 hours ago, Draco18s said:

This is clearly not the effect you want.

So if 0 is the wrong effect and then i have to use 1 but why it dosent work

 

package net.luis.cave.blocks;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.util.Direction;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockReader;

public class TintedGlass extends Block {

	public TintedGlass() {
		
		super(Block.Properties.create(Material.ROCK)
				.zeroHardnessAndResistance()
				.sound(SoundType.GLASS)
				.notSolid());

	}
	
	@Override
	public float getAmbientOcclusionLightValue(BlockState state, IBlockReader worldIn, BlockPos pos) {
		
		return 0.2f;
		
	}
	
	@Override
	public boolean propagatesSkylightDown(BlockState state, IBlockReader reader, BlockPos pos) {
		
		return false;
		
	}
	
	@Override
	public int getOpacity(BlockState state, IBlockReader worldIn, BlockPos pos) {
		
		return 1;
		
	}
	
	@Override
	@SuppressWarnings("deprecation")
	public boolean isSideInvisible(BlockState state, BlockState adjacentBlockState, Direction side) {
		
		return adjacentBlockState.isIn(this) ? true : super.isSideInvisible(state, adjacentBlockState, side);
		
	}

}

 

[Draco18s 2414]

THERE ARE MORE VALUES THAN 0 AND 1. I even told you, twice, what to look at.

 

Here's a big blindingly stupid hint:

The value returned from getOpacity is subtracted off the current light value in order to determine how bright the next space is.

Edited January 27 by Draco18s

[Luis_ST 6]

Thanks now it work (sometimes im a bit lost when it comes to understanding things)