Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16.4] Why recipe result calculated on server side?


Recommended Posts

I want to implement my own block for crafting. So, I investigated canonical example - workbench. And found this code:

 

   protected static void updateCraftingResult(int id, World world, PlayerEntity player, CraftingInventory inventory, CraftResultInventory inventoryResult) {
      if (!world.isRemote) {
         ServerPlayerEntity serverplayerentity = (ServerPlayerEntity)player;
         ItemStack itemstack = ItemStack.EMPTY;
         Optional<ICraftingRecipe> optional = world.getServer().getRecipeManager().getRecipe(IRecipeType.CRAFTING, inventory, world);
         if (optional.isPresent()) {
            ICraftingRecipe icraftingrecipe = optional.get();
            if (inventoryResult.canUseRecipe(world, serverplayerentity, icraftingrecipe)) {
               itemstack = icraftingrecipe.getCraftingResult(inventory);
            }
         }

         inventoryResult.setInventorySlotContents(0, itemstack);
         serverplayerentity.connection.sendPacket(new SSetSlotPacket(id, 0, itemstack));
      }
   }

 

Crafting result calculates on logical server and than client will be notified about result. But why? My crafting interface propose few results, based on items, which player have. Calculation of all combinations is not easy (of couse it have options for optimisation). What a reason to execute crafting result calculations on server?

Link to post
Share on other sites
54 minutes ago, kiou.23 said:

https://link.springer.com/referenceworkentry/10.1007%2F978-3-319-08234-9_272-1

It's the architecture, the server does all the logical shenanigans, and the client is only a viewport, an interface to the state that's managed in the server side

So, it is more ideologically question than strong restriction? I will try to prevent all situations, when count of combination will be critically big. But in theory I may miss some scenarious, which will creates overload. In this case will be better to overload client and give bad expirience for one player, than overlod server and give bad expirience for all.

Edited by S-Spirit
Link to post
Share on other sites
36 minutes ago, S-Spirit said:

So, it is more ideologically question than strong restriction? I will try to prevent all situations, when count of combination will be critically big. But in theory I may miss some scenarious, which will creates overload. In this case will be better to overload client and give bad expirience for one player, than overlod server and give bad expirience for all.

Cheating.

 

Player says "let me just modify my recipe files so that cobblestone makes diamonds."

Normal server goes "what, no stupid, you can't make diamonds out of cobblestone."

You: "OK, diamonds for you! That is a totally legitimate result I believe you're being honest."

  • Thanks 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites
22 hours ago, Draco18s said:

Cheating.

 

Player says "let me just modify my recipe files so that cobblestone makes diamonds."

Normal server goes "what, no stupid, you can't make diamonds out of cobblestone."

You: "OK, diamonds for you! That is a totally legitimate result I believe you're being honest."

For now it is impossible. My crating system is tricki a little. I didn't found way to represents necessary logic by JSON without losing my wishes about customisation. So I don't use recipes consept at all. But I hope at future resolve this problem and use it. In any case, I think your notification about cheating it a great point! So I will implement combinations calculation and filtration at client, but then send results to server for approve and apply into slots. Thanks.

Edited by S-Spirit
Link to post
Share on other sites
1 hour ago, S-Spirit said:

but then send results to server for approve

The server would have to do all the same calculations the client did in order to approve.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites
13 hours ago, Draco18s said:

The server would have to do all the same calculations the client did in order to approve.

I want to propose to user few options, which he/she may craft from items in inventory. Client will prepare all combinations, than select only few best (in my context). Server will validate only this few combinations. Ofcouse I plans to add precheck how many combination client may construct and prevent few-seconds freezes with message like "Sorry, so many ingredients for autocompletion."

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Do not implement IChestLid on your tile entity.
    • Ok so, i think that the problem is i register a ISTER Property of the Item while i initialize the server. But how can I separate item/block registration between client and server?
    • Hi! I had this mod that adds new chest, and when i launch it in a single player world it works good. But when i try to load it on a server, i receive this error: 13.05 11:48:37 [Server] modloading-worker-11/INFO [ne.mi.co.ForgeMod/FORGEMOD]: Forge mod loading, version 36.1.13, for MC 1.16.5 with MCP 20210115.111550 13.05 11:48:37 [Server] modloading-worker-11/INFO [ne.mi.co.MinecraftForge/FORGE]: MinecraftForge v36.1.13 Initialized 13.05 11:48:37 [Server] modloading-worker-2/ERROR [ne.mi.fm.ja.FMLModContainer/LOADING]: Failed to create mod instance. ModID: tenchest, class com.ike.tenchest.TenChest 13.05 11:48:37 [Server] INFO java.lang.BootstrapMethodError: java.lang.IllegalAccessError: no such constructor: com.ike.tenchest.minichest.MiniChest.<init>()void/newInvokeSpecial 13.05 11:48:37 [Server] INFO at com.ike.tenchest.Blocks.<clinit>(Blocks.java:63) ~[tenchest:1.0] {re:classloading,pl:runtimedistcleaner:A} 13.05 11:48:37 [Server] INFO at com.ike.tenchest.TenChest.<init>(TenChest.java:54) ~[tenchest:1.0] {re:classloading} 13.05 11:48:37 [Server] INFO at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at java.lang.reflect.Constructor.newInstance(Constructor.java:423) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at java.lang.Class.newInstance(Class.java:442) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:81) ~[forge:36.1] {re:classloading} 13.05 11:48:37 [Server] INFO at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:120) ~[forge:?] {re:classloading} 13.05 11:48:37 [Server] INFO at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1640) [?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1632) [?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) [?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) [?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) [?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175) [?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO Caused by: java.lang.IllegalAccessError: no such constructor: com.ike.tenchest.minichest.MiniChest.<init>()void/newInvokeSpecial 13.05 11:48:37 [Server] INFO at java.lang.invoke.MethodHandleNatives.linkMethodHandleConstant(MethodHandleNatives.java:483) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO ... 15 more 13.05 11:48:37 [Server] INFO Caused by: java.lang.NoClassDefFoundError: net/minecraft/tileentity/IChestLid 13.05 11:48:37 [Server] INFO at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at java.lang.ClassLoader.defineClass(ClassLoader.java:756) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:138) ~[modlauncher-8.0.9.jar:?] {re:classloading} 13.05 11:48:37 [Server] INFO at cpw.mods.modlauncher.TransformingClassLoader.loadClass(TransformingClassLoader.java:98) ~[modlauncher-8.0.9.jar:?] {re:classloading} 13.05 11:48:37 [Server] INFO at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at net.minecraftforge.eventbus.EventSubclassTransformer.buildEvents(EventSubclassTransformer.java:62) ~[eventbus-4.0.0.jar:?] {} 13.05 11:48:37 [Server] INFO at net.minecraftforge.eventbus.EventSubclassTransformer.transform(EventSubclassTransformer.java:44) ~[eventbus-4.0.0.jar:?] {} 13.05 11:48:37 [Multicraft] Skipped 83 lines due to rate limit (30/s) 13.05 11:48:37 [Server] main/FATAL [ne.mi.fm.ModLoader/LOADING]: Failed to complete lifecycle event CONSTRUCT, 1 errors found 13.05 11:48:37 [Server] main/FATAL [ne.mi.co.ForgeMod/]: Preparing crash report with UUID 449cf277-bc9c-4a21-b16a-3f07d0d4e0c4 13.05 11:48:37 [Server] main/INFO [STDOUT/]: [net.minecraft.crash.CrashReport:func_85057_a:196]: Negative index in crash report handler (16/18) 13.05 11:48:37 [Server] main/FATAL [ne.mi.fm.se.ServerModLoader/]: Crash report saved to ./crash-reports/crash-2021-05-13_11.48.37-fml.txt 13.05 11:48:37 [Server] INFO ---- Minecraft Crash Report ---- 13.05 11:48:37 [Server] INFO // Daisy, daisy... 13.05 11:48:37 [Server] INFO Time: 5/13/21 11:48 AM 13.05 11:48:37 [Server] INFO Description: Mod loading error has occurred 13.05 11:48:37 [Server] INFO java.lang.Exception: Mod Loading has failed 13.05 11:48:37 [Server] INFO at net.minecraftforge.fml.CrashReportExtender.dumpModLoadingCrashReport(CrashReportExtender.java:85) ~[forge:?] {re:classloading} 13.05 11:48:37 [Server] INFO at net.minecraftforge.fml.server.ServerModLoader.load(ServerModLoader.java:51) ~[forge:?] {re:classloading} 13.05 11:48:37 [Server] INFO at net.minecraft.server.Main.main(Main.java:95) ~[?:?] {re:classloading} 13.05 11:48:37 [Server] INFO at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_292] {} 13.05 11:48:37 [Server] INFO at net.minecraftforge.fml.loading.FMLServerLaunchProvider.lambda$launchService$0(FMLServerLaunchProvider.java:51) ~[forge_1.16.5.jar:36.1] {} 13.05 11:48:37 [Server] INFO at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {} 13.05 11:48:37 [Server] INFO at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {} 13.05 11:48:37 [Server] INFO at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {} 13.05 11:48:37 [Server] INFO at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {} 13.05 11:48:37 [Server] INFO at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {} 13.05 11:48:37 [Server] INFO at net.minecraftforge.server.ServerMain$Runner.runLauncher(ServerMain.java:63) [forge_1.16.5.jar:?] {} 13.05 11:48:37 [Server] INFO at net.minecraftforge.server.ServerMain$Runner.access$100(ServerMain.java:60) [forge_1.16.5.jar:?] {} 13.05 11:48:37 [Server] INFO at net.minecraftforge.server.ServerMain.main(ServerMain.java:57) [forge_1.16.5.jar:?] {} 13.05 11:48:37 [Server] INFO A detailed walkthrough of the error, its code path and all known details is as follows: 13.05 11:48:38 [Multicraft] Server shut down (running) 13.05 11:48:38 [Multicraft] Restarting crashed server in 300 seconds 13.05 11:48:38 [Multicraft] Server stopped 13.05 11:50:33 [Multicraft] Received kill command 13.05 11:50:33 [Multicraft] Server stopped What can i do?
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.