Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16.4] Why recipe result calculated on server side?


Recommended Posts

I want to implement my own block for crafting. So, I investigated canonical example - workbench. And found this code:

 

   protected static void updateCraftingResult(int id, World world, PlayerEntity player, CraftingInventory inventory, CraftResultInventory inventoryResult) {
      if (!world.isRemote) {
         ServerPlayerEntity serverplayerentity = (ServerPlayerEntity)player;
         ItemStack itemstack = ItemStack.EMPTY;
         Optional<ICraftingRecipe> optional = world.getServer().getRecipeManager().getRecipe(IRecipeType.CRAFTING, inventory, world);
         if (optional.isPresent()) {
            ICraftingRecipe icraftingrecipe = optional.get();
            if (inventoryResult.canUseRecipe(world, serverplayerentity, icraftingrecipe)) {
               itemstack = icraftingrecipe.getCraftingResult(inventory);
            }
         }

         inventoryResult.setInventorySlotContents(0, itemstack);
         serverplayerentity.connection.sendPacket(new SSetSlotPacket(id, 0, itemstack));
      }
   }

 

Crafting result calculates on logical server and than client will be notified about result. But why? My crafting interface propose few results, based on items, which player have. Calculation of all combinations is not easy (of couse it have options for optimisation). What a reason to execute crafting result calculations on server?

Link to post
Share on other sites
54 minutes ago, kiou.23 said:

https://link.springer.com/referenceworkentry/10.1007%2F978-3-319-08234-9_272-1

It's the architecture, the server does all the logical shenanigans, and the client is only a viewport, an interface to the state that's managed in the server side

So, it is more ideologically question than strong restriction? I will try to prevent all situations, when count of combination will be critically big. But in theory I may miss some scenarious, which will creates overload. In this case will be better to overload client and give bad expirience for one player, than overlod server and give bad expirience for all.

Edited by S-Spirit
Link to post
Share on other sites
36 minutes ago, S-Spirit said:

So, it is more ideologically question than strong restriction? I will try to prevent all situations, when count of combination will be critically big. But in theory I may miss some scenarious, which will creates overload. In this case will be better to overload client and give bad expirience for one player, than overlod server and give bad expirience for all.

Cheating.

 

Player says "let me just modify my recipe files so that cobblestone makes diamonds."

Normal server goes "what, no stupid, you can't make diamonds out of cobblestone."

You: "OK, diamonds for you! That is a totally legitimate result I believe you're being honest."

  • Thanks 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites
22 hours ago, Draco18s said:

Cheating.

 

Player says "let me just modify my recipe files so that cobblestone makes diamonds."

Normal server goes "what, no stupid, you can't make diamonds out of cobblestone."

You: "OK, diamonds for you! That is a totally legitimate result I believe you're being honest."

For now it is impossible. My crating system is tricki a little. I didn't found way to represents necessary logic by JSON without losing my wishes about customisation. So I don't use recipes consept at all. But I hope at future resolve this problem and use it. In any case, I think your notification about cheating it a great point! So I will implement combinations calculation and filtration at client, but then send results to server for approve and apply into slots. Thanks.

Edited by S-Spirit
Link to post
Share on other sites
1 hour ago, S-Spirit said:

but then send results to server for approve

The server would have to do all the same calculations the client did in order to approve.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites
13 hours ago, Draco18s said:

The server would have to do all the same calculations the client did in order to approve.

I want to propose to user few options, which he/she may craft from items in inventory. Client will prepare all combinations, than select only few best (in my context). Server will validate only this few combinations. Ofcouse I plans to add precheck how many combination client may construct and prevent few-seconds freezes with message like "Sorry, so many ingredients for autocompletion."

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • I found a strange bug that can be reproduced by steps: Create empty gradle project(without any plugins) (by intellij idea) Create submodule `app` which contain regular forge mdk Create submodule `common` which contain annotation `Mark` and class `ClassFromSubmodule`  Create submodule `annotation-processor` which contain anootation processor which generate simple companion class for each class annotated with `@Mark` Add some code: //Test.java, `app` submodule //annotation processor will generate TestCompanion for it(and he doing it) @Mark public class Test { } //Main.java, `app` submodule @Mod("strange_bug") public class Main { public Main() { try { System.out.println("Main successful: " + Class.forName("hohserg.strange.bug.TestCompanion")); } catch (ClassNotFoundException e) { System.out.println("Main failed: "); e.printStackTrace(); } ClassFromSubmodule.test(); } } //ClassFromSubmodule.java, `common` submodule public class ClassFromSubmodule { public static void test() { try { System.out.println("ClassFromSubmodule successful: " + Class.forName("hohserg.strange.bug.TestCompanion")); } catch (Throwable e) { System.out.println("ClassFromSubmodule failed: "); e.printStackTrace(); } } } Run `gradle :app:genIntellijRuns` Try run client Got follow log (time mark removed): [modloading-worker-0/INFO] [STDOUT/]: [hohserg.strange.bug.Main:<init>:9]: Main successful: class hohserg.strange.bug.TestCompanion [modloading-worker-0/INFO] [STDOUT/]: [hohserg.strange.bug.ClassFromSubmodule:test:8]: ClassFromSubmodule failed: [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: java.lang.ClassNotFoundException: hohserg.strange.bug.TestCompanion [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.net.URLClassLoader.findClass(URLClassLoader.java:382) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.lang.ClassLoader.loadClass(ClassLoader.java:418) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.lang.ClassLoader.loadClass(ClassLoader.java:351) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.lang.Class.forName0(Native Method) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.lang.Class.forName(Class.java:264) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at hohserg.strange.bug.ClassFromSubmodule.test(ClassFromSubmodule.java:6) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at hohserg.strange.bug.Main.<init>(Main.java:14) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.lang.reflect.Constructor.newInstance(Constructor.java:423) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.lang.Class.newInstance(Class.java:442) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:81) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$4(ModContainer.java:120) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.util.concurrent.CompletableFuture$AsyncRun.run$$$capture(CompletableFuture.java:1640) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1632) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) [modloading-worker-0/INFO] [STDERR/]: [hohserg.strange.bug.ClassFromSubmodule:test:9]: at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) So, class which generated by annotation processor is accessible from Main class(main class of mod) and isn't accessible from class from submodule. Bug is preserved in built jar of mod if it's added as dependency to another mdk project. Bug isn't preserved in built jar of mod if it's running at regular game client. I checked, it's bug does not appears if `app` submodule is simply java application (without mdk) I checked some other cases and resultative limits of bug: Attempt to access to class which generated by annotation processor by `Class.forName` from class from other submodule in dev workspace perform `ClassNotFoundException`  Running game with `.\StrangeBugRoot\gradlew.bat --project-dir ./StrangeBugRoot/ :app:runClient` does not produce bug. Full source code: https://github.com/hohserg1/StrangeBug
    • Depends on your needs. Why do you need the data on the client?
    • Looks like it works now, thanks  
    • Or PlayerLoggedIn is fine too?
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.