[1.16.4] Can't Set ItemTier Material to Custom

[hammy3502 0]

Hello! I'm currently trying to set my ItemTier's repair material to be an item that I've added to the game, so that it can be used in an anvil. However, I seem to run into a problem where it fails to add as the registry for the repair item hasn't taken place yet! However, I'm not sure how I could fix this, as I need to register the ToolItems at some point. Here's the code I've written:

 

Repair Material:

public static final RegistryObject<Item> foodariumIngot = ITEMS.register("foodarium_ingot", () -> new Item(new Item.Properties().group(SurvivalExtras2.CreativeGroup)));

Tool Creation:

public static final Item[] foodariumTools = ModToolsArmor.registerTools("foodarium", 2, 777, 8.0F,
        2.5F, 16, -3.05F, ModItems.foodariumIngot.get());

ModToolsArmor.registerTools() function:

public static Item[] registerTools(String materialName, int harvestLevel, int maxUses, float miningSpeed,
                           float attackDamageExtraFromWood, int enchantability, float axeAttackSpeed, Item repairMaterial) {

    Item[] tools = new Item[5];

    ModItemTier itemTier = new ModItemTier(harvestLevel, maxUses, miningSpeed, attackDamageExtraFromWood, enchantability,
            repairMaterial);

    tools[0] = ModItems.ITEMS.register(materialName + "_sword", () ->
            new SwordItem(itemTier, 4, -2.4F, new Item.Properties().group(SurvivalExtras2.CreativeGroup))
            ).get();
    tools[1] = ModItems.ITEMS.register(materialName + "_pickaxe", () ->
            new PickaxeItem(itemTier, 1, -2.8F, new Item.Properties().group(SurvivalExtras2.CreativeGroup))
    ).get();
    tools[2] = ModItems.ITEMS.register(materialName + "_axe", () ->
            new PickaxeItem(itemTier, 5, axeAttackSpeed, new Item.Properties().group(SurvivalExtras2.CreativeGroup))
    ).get();
    tools[3] = ModItems.ITEMS.register(materialName + "_shovel", () ->
            new ShovelItem(itemTier, 1.5F, -3.0F, new Item.Properties().group(SurvivalExtras2.CreativeGroup))
    ).get();
    tools[4] = ModItems.ITEMS.register(materialName + "_shovel", () ->
            new HoeItem(itemTier, -3, 0.0F, new Item.Properties().group(SurvivalExtras2.CreativeGroup))
    ).get();


    return tools;
}

Thank you so much for any help!

EDIT: Crash log: https://pastebin.com/s9N9Qur6

Edited January 31 by hammy3502

[Beethoven92 87]

Use a Supplier for the Item instead of the Item itself

[Draco18s 2427]

Example:
https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/item/ModItemTier.java

[hammy3502 0]

Hello, and thank you for the help so far!

 

It seems in 1.16, LazyLoadBase was moved to LazyValue, but even with that, it sadly still seems to crash.

 

Tool Creation:

public static final Item[] foodariumTools = ModToolsArmor.registerTools("foodarium", 2, 777, 8.0F,
        2.5F, 16, -3.05F, ModItems.foodariumIngot.get());

Start of registerTools (rest of it is the same):

public static Item[] registerTools(String materialName, int harvestLevel, int maxUses, float miningSpeed,
                           float attackDamageExtraFromWood, int enchantability, float axeAttackSpeed, Item repairMaterial) {

    Item[] tools = new Item[5];

    ModItemTier itemTier = new ModItemTier(harvestLevel, maxUses, miningSpeed, attackDamageExtraFromWood, enchantability,
            () -> Ingredient.fromItems(repairMaterial));

Modified ItemTier:

public class ModItemTier implements IItemTier {

    private final int harvestLevel;
    private final int maxUses;
    private final float miningSpeed;
    private final float attackDamageExtraFromWood;
    private final int enchantability;
    private final LazyValue<Ingredient> repairMaterial;

    public ModItemTier(int harvestLevel, int maxUses, float miningSpeed, float attackDamageExtraFromWood, int enchantability, Supplier<Ingredient> repairMaterial) {
        this.harvestLevel = harvestLevel;
        this.maxUses = maxUses;
        this.miningSpeed = miningSpeed;
        this.attackDamageExtraFromWood = attackDamageExtraFromWood;
        this.repairMaterial = new LazyValue<>(repairMaterial);
        this.enchantability = enchantability;

    }

    @Override
    public int getMaxUses() {
        return this.maxUses;
    }

    @Override
    public float getEfficiency() {
        return this.miningSpeed;
    }

    @Override
    public float getAttackDamage() {
        return this.attackDamageExtraFromWood;
    }

    @Override
    public int getHarvestLevel() {
        return this.harvestLevel;
    }

    @Override
    public int getEnchantability() {
        return this.enchantability;
    }

    @Override
    public Ingredient getRepairMaterial() {
        return this.repairMaterial.getValue();
    }
}

New Crash Log (seems to have the same error as before):

https://pastebin.com/PSDVZaDE

 

Thank you again for all the help so far!

[diesieben07 7814]

You are creating items in a static initializer. You cannot do that. Items must be created and registered during the registry events. I suggest you use DeferredRegister for this purpose.

Then you still have a hard requirement on foodariumIngot being there when you call registerTools, because you just call foodariumIngot.get(). But at this point you have no idea that it is initialized, so you cannot do that. You need to use the supplier (foodariumIngot), not call get immediately.

[hammy3502 0]

Hello, and thank you so much for the help! I know it may not be clear from the code above, but the items are currently registered through the DeferredRegister. How would I go about getting the supplier for foodariumIngot? Just passing in the foodariumIngot is a RegistryObject<Item>, but I need a Supplier<Item>. Thank you so much for any help!

[diesieben07 7814]

3 minutes ago, hammy3502 said:

know it may not be clear from the code above, but the items are currently registered through the DeferredRegister.

That is not possible. You call registerTools from a static initializer and it returns an Item[]. If the items it returns were registered using DeferredRegister, this would crash, because this runs before the registry event.

[hammy3502 0]

I've put a quick temporary patch on registerTools to return a boolean, and simply register the items necessary without calling .get(), though the crash still occurs on the repairMaterial, as I'm not sure how to pass in a proper Supplier.

[diesieben07 7814]

Please post more of your code and not just snippets.

Also post the crash.

[hammy3502 0]

I'm stupid, the RegistryObject's are suppliers. Swapping those in, and changing the code around a bit, and everything works now. Thank you so much for the help!