Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • My Recipe Won't Work
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
TheMajorN

My Recipe Won't Work

By TheMajorN, February 22 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

TheMajorN    0

TheMajorN

TheMajorN    0

  • Tree Puncher
  • TheMajorN
  • Members
  • 0
  • 25 posts
Posted February 22 (edited)

Heya, so I'm making a cutting board for turning meat into sliced meat and all that.  I have everything set up: The container, tile entity, gui, etc.  Everything is working fine, except for the fact that when I put beef into the first slot, nothing happens and nothing outputs.  I double and triple checked all the code and everything seems to be in line and I'm sure this is just a stupid error, but I'm not sure what to do about it.

 

Here's my the relevant files in my github (Containers, tile entities, serializers, recipes, etc) :

https://github.com/TheMajorN/sculleryProject/tree/main/src/main/java/com/thamajorn/scullery/util

https://github.com/TheMajorN/sculleryProject/tree/main/src/main/java/com/thamajorn/scullery/tileentities

https://github.com/TheMajorN/sculleryProject/tree/main/src/main/java/com/thamajorn/scullery/container

https://github.com/TheMajorN/sculleryProject/tree/main/src/main/java/com/thamajorn/scullery/gui

https://github.com/TheMajorN/sculleryProject/tree/main/src/main/java/com/thamajorn/scullery/recipes

https://github.com/TheMajorN/sculleryProject/tree/main/src/main/resources/data/scullery/recipes/cuttingboardrecipes

 

Sorry for pretty much having someone look over my work but maybe an extra set of eyes is just what I need.

 

Edit: You'll see some files not using upper camel case, sorry about that but it's not really my priority rn to fix it rn but I'll get around to organization once I get this problem sorted.

Edited February 22 by TheMajorN
Clarification on disorganization
  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7697

diesieben07

diesieben07    7697

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7697
  • 56382 posts
Posted February 22

You never register the DeferredRegister for recipe serializers to the event bus, as such your recipe serializer is not registered. You can see this in the console:

Quote

com.google.gson.JsonSyntaxException: Invalid or unsupported recipe type 'scullery:cuttingboard'

 

  • Quote

Share this post


Link to post
Share on other sites

TheMajorN    0

TheMajorN

TheMajorN    0

  • Tree Puncher
  • TheMajorN
  • Members
  • 0
  • 25 posts
Posted February 22
25 minutes ago, diesieben07 said:

You never register the DeferredRegister for recipe serializers to the event bus, as such your recipe serializer is not registered. You can see this in the console:

 

Ohhh my god I totally missed that.  Thanks for your help as always diesie.

  • Quote

Share this post


Link to post
Share on other sites

TheMajorN    0

TheMajorN

TheMajorN    0

  • Tree Puncher
  • TheMajorN
  • Members
  • 0
  • 25 posts
Posted February 23

Hey so sorry to bother again, but I registered it and everything and the recipe still isn't working for some reason.  I was reading through the console and the only thing that looked like was wrong with the recipe is that it wasn't categorized, but I don't think that would completely negate the recipe.  I updated the github to the most recent changes just in case I missed something else.  Sorry for the trouble.

  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7697

diesieben07

diesieben07    7697

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7697
  • 56382 posts
Posted February 23

It works just fine, except that your progress bar is messed up:

2021-02-23_09_11_40.png.d5a8703e72fa9bd62982e0244d83aa8b.png

 

Also, your getRecipe method can be simplified a lot, if you use RecipeManager#getRecipe(IRecipeType, IInventory, World).

  • Quote

Share this post


Link to post
Share on other sites

TheMajorN    0

TheMajorN

TheMajorN    0

  • Tree Puncher
  • TheMajorN
  • Members
  • 0
  • 25 posts
Posted February 23

OH! I didn't even realize I had a line of code in there that made it required to be powered by redstone.  I just got rid of that and everything is working mostly fine!  I also switched the progress bar from the foreground to background changed the x and y on it, and its in the right place and shows up.  The only problem is now that the progress bar cuts off at about 1/4 the way through, but I should be able to find and fix that.  I'll also take a look at the getRecipe method for simplificaiton.

 

Thank you so much for the help dude.

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Draco18s
      [1.16.x] Custom block as a shop

      By Draco18s · Posted 8 minutes ago

      So, if your parses throw a NumberFormatException.... what values will price and quantity contain when buyItem is called? You still don't actually need this check. You don't need to do this... signTe.signText is a public ITextComponentString[]...
    • Deadlocked47
      Can't get into forge discord

      By Deadlocked47 · Posted 15 minutes ago

      Bump
    • moyas1009
      Texture for new Layer

      By moyas1009 · Posted 55 minutes ago

      Hi, I'm making a layer that goes over the player's head, so far I've gotten the model to render correctly but I don't know what to put in the json so that the texture renders or if I should even make a json in the first place, any help is greatly appreciated
    • ThisIsNotOriginal
      When I try to run my mod after I just added Deferred Registries it crashes

      By ThisIsNotOriginal · Posted 1 hour ago

      when i run it the game gets terminated and doesnt give me a log except the one i provided  
    • ThisIsNotOriginal
      When I try to run my mod after I just added Deferred Registries it crashes

      By ThisIsNotOriginal · Posted 1 hour ago

      idk where that is this si the only file it shows me  
  • Topics

    • Retsal
      5
      [1.16.x] Custom block as a shop

      By Retsal
      Started 14 hours ago

    • Deadlocked47
      2
      Can't get into forge discord

      By Deadlocked47
      Started Saturday at 06:58 PM

    • moyas1009
      0
      Texture for new Layer

      By moyas1009
      Started 55 minutes ago

    • ThisIsNotOriginal
      3
      When I try to run my mod after I just added Deferred Registries it crashes

      By ThisIsNotOriginal
      Started 3 hours ago

    • keepercreeper22
      0
      I need help with getting a old world of mine back on a older version of forge(yes i know old forge is not supported, i dont care if admins try to help even if people that are experienced would be great

      By keepercreeper22
      Started 2 hours ago

  • Who's Online (See full list)

    • Woosh
    • veinex1728@gmail.com
    • Zari
    • Deadlocked47
    • Draco18s
    • ThisIsNotOriginal
    • mcnuggies
    • PyRoTheLifeLess
    • Megaton_216_
    • ChampionAsh5357
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • My Recipe Won't Work
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community