Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.16.4] GlobalEntityTypeAttributes problem
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
SubliminallySublime

[1.16.4] GlobalEntityTypeAttributes problem

By SubliminallySublime, February 23 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

SubliminallySublime    2

SubliminallySublime

SubliminallySublime    2

  • Tree Puncher
  • SubliminallySublime
  • Members
  • 2
  • 30 posts
Posted February 23 (edited)

Hello. I am getting this crash on right click with a spawn egg:
 

[00:17:29] [Server thread/FATAL] [minecraft/ThreadTaskExecutor]: Error executing task on Server
java.lang.NullPointerException: null
	at net.minecraft.entity.ai.attributes.AttributeModifierManager.getAttributeValue(AttributeModifierManager.java:67) ~[forge:?] {re:classloading}
	at net.minecraft.entity.LivingEntity.getAttributeValue(LivingEntity.java:1849) ~[forge:?] {re:classloading}
	at net.minecraft.entity.LivingEntity.getMaxHealth(LivingEntity.java:1610) ~[forge:?] {re:classloading}
	at net.minecraft.entity.LivingEntity.<init>(LivingEntity.java:209) ~[forge:?] {re:classloading}
	at net.minecraft.entity.MobEntity.<init>(MobEntity.java:108) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.entity.CreatureEntity.<init>(CreatureEntity.java:13) ~[forge:?] {re:classloading}
	at net.minecraft.entity.monster.MonsterEntity.<init>(MonsterEntity.java:29) ~[forge:?] {re:classloading}
	at testmod.entity.testentity.EntityTest.<init>(EntityTest.java:40) ~[?:?] {re:classloading}


From what I can tell, this means it doesn't have custom attributes, namely MaxHealth. I am registering them like so:

In my Mod file:

//in constructor
	FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setupCustomAttributes);



private void setupCustomAttributes(final ParallelDispatchEvent event)
{
    event.enqueueWork(() -> {
        System.out.println("CALLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLED");
        GlobalEntityTypeAttributes.put(ModEntities.ENTITY_TEST.get(), EntityTest.setCustomAttributes().create());
    });
}


In my Entity class 

public class EntityTest extends MonsterEntity {

  public static AttributeModifierMap.MutableAttribute setCustomAttributes() {
     return MonsterEntity.func_233666_p_()
           .createMutableAttribute(Attributes.MAX_HEALTH, 100.0D)
           .createMutableAttribute(Attributes.MOVEMENT_SPEED, 1D);
  }
}


In my ModEntities class

public class ModEntities
{
	public static final RegistryObject<EntityType<EntityTest>> ENTITY_TEST = registerEntityAndEgg(() -> EntityType.Builder.create(EntityTest::new, EntityClassification.MISC)
			.size(1.5f, 2.25f)
			.build(new ResourceLocation(TestMod.MOD_ID, "test_entity").toString()), "test_entity", EntityTest.COLOR1, EntityTest.COLOR2);
	
	public static final <T extends Entity> RegistryObject<EntityType<T>> registerEntityAndEgg (Supplier<EntityType<T>> entityTypeSupplier, String name, int color, int color2)
	{
		RegistryObject<EntityType<T>> registeryEntity = Registration.ENTITIES.register(name, entityTypeSupplier);
		
		//TODO: STORE?
		RegistryObject<Item> SPAWN_EGG = Registration.ITEMS.register(
				"spawn_egg_" + name,
				() -> new SpawnEggItem(entityTypeSupplier.get(), color, color2, new Item.Properties().group(ItemGroup.MATERIALS)));
	
		return registeryEntity;
	}
}


And finally my registration class:

public class Registration
{
	public static final DeferredRegister<Block> BLOCKS = DeferredRegister.create(ForgeRegistries.BLOCKS, TestMod.MOD_ID);
	public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, TestMod.MOD_ID);
	
	public static final DeferredRegister<EntityType<?>> ENTITIES = DeferredRegister.create(ForgeRegistries.ENTITIES, TheUpsideDownMod.MOD_ID);
	
	public static void register()
	{
		IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();
		
		BLOCKS.register(modEventBus);
		ITEMS.register(modEventBus);
		
		ENTITIES.register(modEventBus);
		
	}
}


The method IS called as determined by breakpoints and my output call. 

I am not sure what is up here. I am not sure how to test any further than my output and breakpoint checks. Should I update to 1.16.5 and try again?
 

Edited February 23 by SubliminallySublime
Code correction
  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7697

diesieben07

diesieben07    7697

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7697
  • 56382 posts
Posted February 23
2 hours ago, SubliminallySublime said:

private void setupCustomAttributes(final ParallelDispatchEvent event)

This makes zero sense. This means you will receive all subclasses of this event, which makes this event handler meaningless. Use FMLCommonSetupEvent.

 

Additionally: Do not put a DeferredRegister and its registry entries in separate classes. A DeferredRegister field should be private.

  • Like 1
  • Quote

Share this post


Link to post
Share on other sites

SubliminallySublime    2

SubliminallySublime

SubliminallySublime    2

  • Tree Puncher
  • SubliminallySublime
  • Members
  • 2
  • 30 posts
Posted February 23
7 hours ago, diesieben07 said:

This makes zero sense. This means you will receive all subclasses of this event, which makes this event handler meaningless. Use FMLCommonSetupEvent.

 

Additionally: Do not put a DeferredRegister and its registry entries in separate classes. A DeferredRegister field should be private.

Thank you!  I was not aware FMLCommonSetupEvent had an enque event I could access. I am getting a different crash now but I think I can solve it.

I am also correcting my DeferredRegister design. Thank you.

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Draco18s
      [1.16.x] Custom block as a shop

      By Draco18s · Posted 53 minutes ago

      So, if your parses throw a NumberFormatException.... what values will price and quantity contain when buyItem is called? You still don't actually need this check. You don't need to do this... signTe.signText is a public ITextComponentString[]...
    • Deadlocked47
      Can't get into forge discord

      By Deadlocked47 · Posted 1 hour ago

      Bump
    • moyas1009
      Texture for new Layer

      By moyas1009 · Posted 1 hour ago

      Hi, I'm making a layer that goes over the player's head, so far I've gotten the model to render correctly but I don't know what to put in the json so that the texture renders or if I should even make a json in the first place, any help is greatly appreciated
    • ThisIsNotOriginal
      When I try to run my mod after I just added Deferred Registries it crashes

      By ThisIsNotOriginal · Posted 1 hour ago

      when i run it the game gets terminated and doesnt give me a log except the one i provided  
    • ThisIsNotOriginal
      When I try to run my mod after I just added Deferred Registries it crashes

      By ThisIsNotOriginal · Posted 1 hour ago

      idk where that is this si the only file it shows me  
  • Topics

    • Retsal
      5
      [1.16.x] Custom block as a shop

      By Retsal
      Started 14 hours ago

    • Deadlocked47
      2
      Can't get into forge discord

      By Deadlocked47
      Started Saturday at 06:58 PM

    • moyas1009
      0
      Texture for new Layer

      By moyas1009
      Started 1 hour ago

    • ThisIsNotOriginal
      3
      When I try to run my mod after I just added Deferred Registries it crashes

      By ThisIsNotOriginal
      Started 4 hours ago

    • keepercreeper22
      0
      I need help with getting a old world of mine back on a older version of forge(yes i know old forge is not supported, i dont care if admins try to help even if people that are experienced would be great

      By keepercreeper22
      Started 3 hours ago

  • Who's Online (See full list)

    • brok4d
    • moyas1009
    • DmitryLovin
    • ThisIsNotOriginal
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.16.4] GlobalEntityTypeAttributes problem
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community