Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16.4] GlobalEntityTypeAttributes problem


Recommended Posts

Hello. I am getting this crash on right click with a spawn egg:
 

[00:17:29] [Server thread/FATAL] [minecraft/ThreadTaskExecutor]: Error executing task on Server
java.lang.NullPointerException: null
	at net.minecraft.entity.ai.attributes.AttributeModifierManager.getAttributeValue(AttributeModifierManager.java:67) ~[forge:?] {re:classloading}
	at net.minecraft.entity.LivingEntity.getAttributeValue(LivingEntity.java:1849) ~[forge:?] {re:classloading}
	at net.minecraft.entity.LivingEntity.getMaxHealth(LivingEntity.java:1610) ~[forge:?] {re:classloading}
	at net.minecraft.entity.LivingEntity.<init>(LivingEntity.java:209) ~[forge:?] {re:classloading}
	at net.minecraft.entity.MobEntity.<init>(MobEntity.java:108) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.entity.CreatureEntity.<init>(CreatureEntity.java:13) ~[forge:?] {re:classloading}
	at net.minecraft.entity.monster.MonsterEntity.<init>(MonsterEntity.java:29) ~[forge:?] {re:classloading}
	at testmod.entity.testentity.EntityTest.<init>(EntityTest.java:40) ~[?:?] {re:classloading}


From what I can tell, this means it doesn't have custom attributes, namely MaxHealth. I am registering them like so:

In my Mod file:

//in constructor
	FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setupCustomAttributes);



private void setupCustomAttributes(final ParallelDispatchEvent event)
{
    event.enqueueWork(() -> {
        System.out.println("CALLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLED");
        GlobalEntityTypeAttributes.put(ModEntities.ENTITY_TEST.get(), EntityTest.setCustomAttributes().create());
    });
}


In my Entity class 

public class EntityTest extends MonsterEntity {

  public static AttributeModifierMap.MutableAttribute setCustomAttributes() {
     return MonsterEntity.func_233666_p_()
           .createMutableAttribute(Attributes.MAX_HEALTH, 100.0D)
           .createMutableAttribute(Attributes.MOVEMENT_SPEED, 1D);
  }
}


In my ModEntities class

public class ModEntities
{
	public static final RegistryObject<EntityType<EntityTest>> ENTITY_TEST = registerEntityAndEgg(() -> EntityType.Builder.create(EntityTest::new, EntityClassification.MISC)
			.size(1.5f, 2.25f)
			.build(new ResourceLocation(TestMod.MOD_ID, "test_entity").toString()), "test_entity", EntityTest.COLOR1, EntityTest.COLOR2);
	
	public static final <T extends Entity> RegistryObject<EntityType<T>> registerEntityAndEgg (Supplier<EntityType<T>> entityTypeSupplier, String name, int color, int color2)
	{
		RegistryObject<EntityType<T>> registeryEntity = Registration.ENTITIES.register(name, entityTypeSupplier);
		
		//TODO: STORE?
		RegistryObject<Item> SPAWN_EGG = Registration.ITEMS.register(
				"spawn_egg_" + name,
				() -> new SpawnEggItem(entityTypeSupplier.get(), color, color2, new Item.Properties().group(ItemGroup.MATERIALS)));
	
		return registeryEntity;
	}
}


And finally my registration class:

public class Registration
{
	public static final DeferredRegister<Block> BLOCKS = DeferredRegister.create(ForgeRegistries.BLOCKS, TestMod.MOD_ID);
	public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, TestMod.MOD_ID);
	
	public static final DeferredRegister<EntityType<?>> ENTITIES = DeferredRegister.create(ForgeRegistries.ENTITIES, TheUpsideDownMod.MOD_ID);
	
	public static void register()
	{
		IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();
		
		BLOCKS.register(modEventBus);
		ITEMS.register(modEventBus);
		
		ENTITIES.register(modEventBus);
		
	}
}


The method IS called as determined by breakpoints and my output call. 

I am not sure what is up here. I am not sure how to test any further than my output and breakpoint checks. Should I update to 1.16.5 and try again?
 

Edited by SubliminallySublime
Code correction
Link to post
Share on other sites
2 hours ago, SubliminallySublime said:

private void setupCustomAttributes(final ParallelDispatchEvent event)

This makes zero sense. This means you will receive all subclasses of this event, which makes this event handler meaningless. Use FMLCommonSetupEvent.

 

Additionally: Do not put a DeferredRegister and its registry entries in separate classes. A DeferredRegister field should be private.

  • Like 1
Link to post
Share on other sites
7 hours ago, diesieben07 said:

This makes zero sense. This means you will receive all subclasses of this event, which makes this event handler meaningless. Use FMLCommonSetupEvent.

 

Additionally: Do not put a DeferredRegister and its registry entries in separate classes. A DeferredRegister field should be private.

Thank you!  I was not aware FMLCommonSetupEvent had an enque event I could access. I am getting a different crash now but I think I can solve it.

I am also correcting my DeferredRegister design. Thank you.

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.