Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.16.4] GlobalEntityTypeAttributes problem
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
SubliminallySublime

[1.16.4] GlobalEntityTypeAttributes problem

By SubliminallySublime, Tuesday at 05:32 AM in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

SubliminallySublime    2

SubliminallySublime

SubliminallySublime    2

  • Tree Puncher
  • SubliminallySublime
  • Members
  • 2
  • 30 posts
Posted Tuesday at 05:32 AM (edited)

Hello. I am getting this crash on right click with a spawn egg:
 

[00:17:29] [Server thread/FATAL] [minecraft/ThreadTaskExecutor]: Error executing task on Server
java.lang.NullPointerException: null
	at net.minecraft.entity.ai.attributes.AttributeModifierManager.getAttributeValue(AttributeModifierManager.java:67) ~[forge:?] {re:classloading}
	at net.minecraft.entity.LivingEntity.getAttributeValue(LivingEntity.java:1849) ~[forge:?] {re:classloading}
	at net.minecraft.entity.LivingEntity.getMaxHealth(LivingEntity.java:1610) ~[forge:?] {re:classloading}
	at net.minecraft.entity.LivingEntity.<init>(LivingEntity.java:209) ~[forge:?] {re:classloading}
	at net.minecraft.entity.MobEntity.<init>(MobEntity.java:108) ~[forge:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.entity.CreatureEntity.<init>(CreatureEntity.java:13) ~[forge:?] {re:classloading}
	at net.minecraft.entity.monster.MonsterEntity.<init>(MonsterEntity.java:29) ~[forge:?] {re:classloading}
	at testmod.entity.testentity.EntityTest.<init>(EntityTest.java:40) ~[?:?] {re:classloading}


From what I can tell, this means it doesn't have custom attributes, namely MaxHealth. I am registering them like so:

In my Mod file:

//in constructor
	FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setupCustomAttributes);



private void setupCustomAttributes(final ParallelDispatchEvent event)
{
    event.enqueueWork(() -> {
        System.out.println("CALLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLLED");
        GlobalEntityTypeAttributes.put(ModEntities.ENTITY_TEST.get(), EntityTest.setCustomAttributes().create());
    });
}


In my Entity class 

public class EntityTest extends MonsterEntity {

  public static AttributeModifierMap.MutableAttribute setCustomAttributes() {
     return MonsterEntity.func_233666_p_()
           .createMutableAttribute(Attributes.MAX_HEALTH, 100.0D)
           .createMutableAttribute(Attributes.MOVEMENT_SPEED, 1D);
  }
}


In my ModEntities class

public class ModEntities
{
	public static final RegistryObject<EntityType<EntityTest>> ENTITY_TEST = registerEntityAndEgg(() -> EntityType.Builder.create(EntityTest::new, EntityClassification.MISC)
			.size(1.5f, 2.25f)
			.build(new ResourceLocation(TestMod.MOD_ID, "test_entity").toString()), "test_entity", EntityTest.COLOR1, EntityTest.COLOR2);
	
	public static final <T extends Entity> RegistryObject<EntityType<T>> registerEntityAndEgg (Supplier<EntityType<T>> entityTypeSupplier, String name, int color, int color2)
	{
		RegistryObject<EntityType<T>> registeryEntity = Registration.ENTITIES.register(name, entityTypeSupplier);
		
		//TODO: STORE?
		RegistryObject<Item> SPAWN_EGG = Registration.ITEMS.register(
				"spawn_egg_" + name,
				() -> new SpawnEggItem(entityTypeSupplier.get(), color, color2, new Item.Properties().group(ItemGroup.MATERIALS)));
	
		return registeryEntity;
	}
}


And finally my registration class:

public class Registration
{
	public static final DeferredRegister<Block> BLOCKS = DeferredRegister.create(ForgeRegistries.BLOCKS, TestMod.MOD_ID);
	public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, TestMod.MOD_ID);
	
	public static final DeferredRegister<EntityType<?>> ENTITIES = DeferredRegister.create(ForgeRegistries.ENTITIES, TheUpsideDownMod.MOD_ID);
	
	public static void register()
	{
		IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();
		
		BLOCKS.register(modEventBus);
		ITEMS.register(modEventBus);
		
		ENTITIES.register(modEventBus);
		
	}
}


The method IS called as determined by breakpoints and my output call. 

I am not sure what is up here. I am not sure how to test any further than my output and breakpoint checks. Should I update to 1.16.5 and try again?
 

Edited Tuesday at 05:33 AM by SubliminallySublime
Code correction
  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7688

diesieben07

diesieben07    7688

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7688
  • 56257 posts
Posted Tuesday at 08:16 AM
2 hours ago, SubliminallySublime said:

private void setupCustomAttributes(final ParallelDispatchEvent event)

This makes zero sense. This means you will receive all subclasses of this event, which makes this event handler meaningless. Use FMLCommonSetupEvent.

 

Additionally: Do not put a DeferredRegister and its registry entries in separate classes. A DeferredRegister field should be private.

  • Like 1
  • Quote

Share this post


Link to post
Share on other sites

SubliminallySublime    2

SubliminallySublime

SubliminallySublime    2

  • Tree Puncher
  • SubliminallySublime
  • Members
  • 2
  • 30 posts
Posted Tuesday at 04:12 PM
7 hours ago, diesieben07 said:

This makes zero sense. This means you will receive all subclasses of this event, which makes this event handler meaningless. Use FMLCommonSetupEvent.

 

Additionally: Do not put a DeferredRegister and its registry entries in separate classes. A DeferredRegister field should be private.

Thank you!  I was not aware FMLCommonSetupEvent had an enque event I could access. I am getting a different crash now but I think I can solve it.

I am also correcting my DeferredRegister design. Thank you.

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Centmap
      Forge Mods Folder

      By Centmap · Posted 51 minutes ago

      so i created a "1.16.5" folder in the folder "mod" as usual but it doesn't use the mods. Can anyone help me ?
    • Skyriis
      [SOLVED][1.16.5] Adding a Button to KeyBindings

      By Skyriis · Posted 1 hour ago

      That worked.   Here is my solution @SubscribeEvent public static void onOpenGui(final GuiScreenEvent.InitGuiEvent.Post event) { if (!(event.getGui() instanceof ControlsScreen)) return; final ControlsScreen controlsScreen = (ControlsScreen) event.getGui(); final KeyBindingList replacement = new KeyBindingListReplacement(controlsScreen, event.getGui().getMinecraft()); final KeyBindingList old = ObfuscationReflectionHelper.getPrivateValue(ControlsScreen.class, controlsScreen, "field_146494_r"); controlsScreen.getEventListeners().remove(old); ObfuscationReflectionHelper.setPrivateValue(ControlsScreen.class, controlsScreen, replacement, "field_146494_r"); try { Method addChildMethod = ObfuscationReflectionHelper.findMethod(Screen.class, "func_230481_d_", IGuiEventListener.class); addChildMethod.setAccessible(true); addChildMethod.invoke(controlsScreen, replacement); addChildMethod.setAccessible(false); } catch (IllegalAccessException | InvocationTargetException e) { e.printStackTrace(); } }  
    • DrCowiber
      Failed To Start Minecraft Server

      By DrCowiber · Posted 1 hour ago

      im using this run.sh file, which contains: java -Xmx6G -Xms6G -jar minecraft_server.1.16.5.jar --nogui Edit: When I first posted about this I was using the serverRun.jar, which the first log file I posted is what the output was
    • Tez
      [1.15.2] Couln't not resolve dependency: net.minecraftforge:forge:1.15.2-31.2.0:userdev

      By Tez · Posted 2 hours ago

      I'm new to mod coding so i've watch tutorial in youtube in setup workspace step i got this error , i've try many solutions to fix but it still not working try update gradle to 6.8.3 but still not working try update java and still not working too here's my stacktrace: Stacktrace
    • diesieben07
      Failed To Start Minecraft Server

      By diesieben07 · Posted 2 hours ago

      Please show how exactly you are starting the server.
  • Topics

    • Centmap
      0
      Forge Mods Folder

      By Centmap
      Started 51 minutes ago

    • Skyriis
      8
      [SOLVED][1.16.5] Adding a Button to KeyBindings

      By Skyriis
      Started 23 hours ago

    • DrCowiber
      8
      Failed To Start Minecraft Server

      By DrCowiber
      Started 21 hours ago

    • Tez
      0
      [1.15.2] Couln't not resolve dependency: net.minecraftforge:forge:1.15.2-31.2.0:userdev

      By Tez
      Started 2 hours ago

    • Mysterious minecrafter
      1
      game keeps crashing while initializings

      By Mysterious minecrafter
      Started 4 hours ago

  • Who's Online (See full list)

    • Zeher_Monkey
    • Uncreative
    • NullDev
    • PyRoTheLifeLess
    • Centmap
    • redlynx
    • GermanBucket
    • smitokyo
    • KingBlake122308
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.16.4] GlobalEntityTypeAttributes problem
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community