Jump to content

[1.16.4] Change Biome RainType through Reflections Casting error


than00ber1

Recommended Posts

I am trying to change all biome's RainType from RAIN to SNOW.

 

Following this (old but most recent) post, I figured I should use reflections but I am having some trouble cast from Biome.Builder to Biome with this casting error:

 

java.lang.ClassCastException: net.minecraft.world.biome.Biome cannot be cast to net.minecraft.world.biome.Biome$Builder

 

Here is my code:

 

        @SubscribeEvent
        public static void onBiomeRegistry(final RegistryEvent.Register<Biome> event) {
            Set<Map.Entry<RegistryKey<Biome>, Biome>> biomes = event.getRegistry().getEntries();

            for (Map.Entry<RegistryKey<Biome>, Biome> biome : biomes) {
                String name = biome.getValue().getRegistryName().getPath();
                String method = String.format("make%sBiome", CaseFormat.LOWER_UNDERSCORE.to(CaseFormat.UPPER_CAMEL, name));
                System.out.println(method);
                Method builder = null;
                Biome.Builder biome$builder = null;

                try {
                    builder = ObfuscationReflectionHelper.findMethod(BiomeMaker.class, method);
                    biome$builder = (Biome.Builder) builder.invoke(BiomeMaker.class);
                }
                catch (Exception e) {
                    LOGGER.error("Could not get biome builder: %s", e);
                }

                if (builder != null && biome$builder != null) {
                    Biome newBiome = biome$builder.precipitation(Biome.RainType.SNOW).build();
                    event.getRegistry().register(newBiome);
                    LOGGER.info("NEW BIOME " + newBiome.getPrecipitation());
                }
            }
        }

 

Link to comment
Share on other sites

Alright, I've made some changes to my code and noticed that the precipitation field in the Biome class is final and had to change its modifiers from public final to just public.

 

        private static Field precipitation;

        @SubscribeEvent
        public static void onBiomeLoad(BiomeLoadingEvent event) {
            try {
                precipitation.set(event.getClimate().precipitation, Biome.RainType.SNOW);
            }
            catch (Exception e) {
                LOGGER.error(e);
            }
        }

        static {
            try {
                precipitation = Biome.Climate.class.getDeclaredField("precipitation");
                Field mf = Field.class.getDeclaredField("modifiers");
                mf.setAccessible(true);
                mf.setInt(precipitation, precipitation.getModifiers() & ~Modifier.FINAL);

                System.out.println(precipitation.getModifiers()); // prints 1 -> public

            }
            catch (Exception e) {
                LOGGER.error(e);
            }
        }

 

 However, an IllegalArgumentException is thrown with message:

 

Can not set net.minecraft.world.biome.Biome$RainType field net.minecraft.world.biome.Biome$Climate.precipitation to net.minecraft.world.biome.Biome$RainType

 

I honestly don't understand why this happens. My code seems to make sense (atleast to me)...

 

Any ideas why that is or how to fix this?

Link to comment
Share on other sites

You don't need to use reflection for this.

Sorry my code wasn't good.

Try this:

        Climate climate = event.getClimate();
        event.setClimate(new Climate(RainType.SNOW, climate.temperature, climate.temperatureModifier, climate.downfall));

 

FYI: you will not see snow in higher temperature biomes

Edited by lupicus
  • Thanks 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.