Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.16.4] Change Biome RainType through Reflections Casting error
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
than00ber1

[1.16.4] Change Biome RainType through Reflections Casting error

By than00ber1, February 23 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

than00ber1    0

than00ber1

than00ber1    0

  • Tree Puncher
  • than00ber1
  • Members
  • 0
  • 4 posts
Posted February 23

I am trying to change all biome's RainType from RAIN to SNOW.

 

Following this (old but most recent) post, I figured I should use reflections but I am having some trouble cast from Biome.Builder to Biome with this casting error:

 

java.lang.ClassCastException: net.minecraft.world.biome.Biome cannot be cast to net.minecraft.world.biome.Biome$Builder

 

Here is my code:

 

        @SubscribeEvent
        public static void onBiomeRegistry(final RegistryEvent.Register<Biome> event) {
            Set<Map.Entry<RegistryKey<Biome>, Biome>> biomes = event.getRegistry().getEntries();

            for (Map.Entry<RegistryKey<Biome>, Biome> biome : biomes) {
                String name = biome.getValue().getRegistryName().getPath();
                String method = String.format("make%sBiome", CaseFormat.LOWER_UNDERSCORE.to(CaseFormat.UPPER_CAMEL, name));
                System.out.println(method);
                Method builder = null;
                Biome.Builder biome$builder = null;

                try {
                    builder = ObfuscationReflectionHelper.findMethod(BiomeMaker.class, method);
                    biome$builder = (Biome.Builder) builder.invoke(BiomeMaker.class);
                }
                catch (Exception e) {
                    LOGGER.error("Could not get biome builder: %s", e);
                }

                if (builder != null && biome$builder != null) {
                    Biome newBiome = biome$builder.precipitation(Biome.RainType.SNOW).build();
                    event.getRegistry().register(newBiome);
                    LOGGER.info("NEW BIOME " + newBiome.getPrecipitation());
                }
            }
        }

 

  • Quote

Share this post


Link to post
Share on other sites

lupicus    3

lupicus

lupicus    3

  • Tree Puncher
  • lupicus
  • Members
  • 3
  • 10 posts
Posted February 23 (edited)

A Biome object and Biome.Builder object can't be cast to the other type.

The easier way to do this is by using the BiomeLoadingEvent, then you can do:

event.getClimate().precipitation = RainType.SNOW;

 

Edited February 23 by lupicus
  • Quote

Share this post


Link to post
Share on other sites

than00ber1    0

than00ber1

than00ber1    0

  • Tree Puncher
  • than00ber1
  • Members
  • 0
  • 4 posts
Posted February 25

Alright, I've made some changes to my code and noticed that the precipitation field in the Biome class is final and had to change its modifiers from public final to just public.

 

        private static Field precipitation;

        @SubscribeEvent
        public static void onBiomeLoad(BiomeLoadingEvent event) {
            try {
                precipitation.set(event.getClimate().precipitation, Biome.RainType.SNOW);
            }
            catch (Exception e) {
                LOGGER.error(e);
            }
        }

        static {
            try {
                precipitation = Biome.Climate.class.getDeclaredField("precipitation");
                Field mf = Field.class.getDeclaredField("modifiers");
                mf.setAccessible(true);
                mf.setInt(precipitation, precipitation.getModifiers() & ~Modifier.FINAL);

                System.out.println(precipitation.getModifiers()); // prints 1 -> public

            }
            catch (Exception e) {
                LOGGER.error(e);
            }
        }

 

 However, an IllegalArgumentException is thrown with message:

 

Can not set net.minecraft.world.biome.Biome$RainType field net.minecraft.world.biome.Biome$Climate.precipitation to net.minecraft.world.biome.Biome$RainType

 

I honestly don't understand why this happens. My code seems to make sense (atleast to me)...

 

Any ideas why that is or how to fix this?

  • Quote

Share this post


Link to post
Share on other sites

lupicus    3

lupicus

lupicus    3

  • Tree Puncher
  • lupicus
  • Members
  • 3
  • 10 posts
Posted February 25 (edited)

You don't need to use reflection for this.

Sorry my code wasn't good.

Try this:

        Climate climate = event.getClimate();
        event.setClimate(new Climate(RainType.SNOW, climate.temperature, climate.temperatureModifier, climate.downfall));

 

FYI: you will not see snow in higher temperature biomes

Edited February 25 by lupicus
  • Thanks 1
  • Quote

Share this post


Link to post
Share on other sites

than00ber1    0

than00ber1

than00ber1    0

  • Tree Puncher
  • than00ber1
  • Members
  • 0
  • 4 posts
Posted Friday at 11:26 AM

Oh wow that really did the trick. Thanks!

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Draco18s
      [1.16.x] Custom block as a shop

      By Draco18s · Posted 43 minutes ago

      So, if your parses throw a NumberFormatException.... what values will price and quantity contain when buyItem is called? You still don't actually need this check. You don't need to do this... signTe.signText is a public ITextComponentString[]...
    • Deadlocked47
      Can't get into forge discord

      By Deadlocked47 · Posted 50 minutes ago

      Bump
    • moyas1009
      Texture for new Layer

      By moyas1009 · Posted 1 hour ago

      Hi, I'm making a layer that goes over the player's head, so far I've gotten the model to render correctly but I don't know what to put in the json so that the texture renders or if I should even make a json in the first place, any help is greatly appreciated
    • ThisIsNotOriginal
      When I try to run my mod after I just added Deferred Registries it crashes

      By ThisIsNotOriginal · Posted 1 hour ago

      when i run it the game gets terminated and doesnt give me a log except the one i provided  
    • ThisIsNotOriginal
      When I try to run my mod after I just added Deferred Registries it crashes

      By ThisIsNotOriginal · Posted 1 hour ago

      idk where that is this si the only file it shows me  
  • Topics

    • Retsal
      5
      [1.16.x] Custom block as a shop

      By Retsal
      Started 14 hours ago

    • Deadlocked47
      2
      Can't get into forge discord

      By Deadlocked47
      Started Saturday at 06:58 PM

    • moyas1009
      0
      Texture for new Layer

      By moyas1009
      Started 1 hour ago

    • ThisIsNotOriginal
      3
      When I try to run my mod after I just added Deferred Registries it crashes

      By ThisIsNotOriginal
      Started 4 hours ago

    • keepercreeper22
      0
      I need help with getting a old world of mine back on a older version of forge(yes i know old forge is not supported, i dont care if admins try to help even if people that are experienced would be great

      By keepercreeper22
      Started 3 hours ago

  • Who's Online (See full list)

    • brok4d
    • ThisIsNotOriginal
    • mcnuggies
    • samjviana
    • DavidM
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.16.4] Change Biome RainType through Reflections Casting error
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community