Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [SOLVED] 1.16.3 How to get the World Name for saving files in the /saves folder
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 0
Zeher_Monkey

[SOLVED] 1.16.3 How to get the World Name for saving files in the /saves folder

By Zeher_Monkey, February 24 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

Zeher_Monkey    3

Zeher_Monkey

Zeher_Monkey    3

  • Creeper Killer
  • Zeher_Monkey
  • Members
  • 3
  • 125 posts
Posted February 24 (edited)

Hi,

 

I am updating some of my mods, and I store config files in the "/saves/WORLDNAME/" folder. I am having trouble getting this folder name at the moment.

 

In 1.12.2 the code to get this was:

FMLCommonHandler.instance().getMinecraftServerInstance().getFolderName()

 

However I'm struggling to find the equivalent in 1.16.

 

Many thanks in advance.

Edited February 26 by Zeher_Monkey
  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7697

diesieben07

diesieben07    7697

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7697
  • 56382 posts
Posted February 24

Forge's config system has this built in using the ModConfig.Type.SERVER config type.

  • Quote

Share this post


Link to post
Share on other sites

Zeher_Monkey    3

Zeher_Monkey

Zeher_Monkey    3

  • Creeper Killer
  • Zeher_Monkey
  • Members
  • 3
  • 125 posts
Posted February 25 (edited)
18 hours ago, diesieben07 said:

Forge's config system has this built in using the ModConfig.Type.SERVER config type.

Okay thanks, can these be changed dynamically with a world? 

 

Basically I am storing a LinkedHashMap with a BlockPos as the Key, and a custom Classfile as the value. When a block is placed down a new instance of the Customfile.class is created and added to the map, with that blocks BlockPos as the key, and the map is stored within the "/saves/WORLDNAME/mymod/" folder. I am assuming that Forge's config system is not the best system to use with my use-case.

Edited February 25 by Zeher_Monkey
  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7697

diesieben07

diesieben07    7697

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7697
  • 56382 posts
Posted February 25

That is not a config file at all. That's a data file. Use WorldSavedData or a world capability.

  • Quote

Share this post


Link to post
Share on other sites

Zeher_Monkey    3

Zeher_Monkey

Zeher_Monkey    3

  • Creeper Killer
  • Zeher_Monkey
  • Members
  • 3
  • 125 posts
Posted February 26
16 hours ago, diesieben07 said:

That is not a config file at all. That's a data file. Use WorldSavedData or a world capability.

 

Many thanks for your help, although the ForgeDocs seem to be outdated, as I could not find reference to:

World#getMapStorage()

Anywhere in the actual code in Forges latest release for 1.16.3.

 

I really do not want to enter the capability rabbit hole, as I have had major trouble getting packets to work in the past. I instead reviewed some other posts, and following your guidance on those posts have resorted to using this code, which works on both the client and server side:

 

Object save = ObfuscationReflectionHelper.getPrivateValue(MinecraftServer.class, server, "field_71310_m");
		
if (save instanceof SaveFormat.LevelSave) {
	String save_name = ((LevelSave) save).getSaveName();
			
	file_path.append(save_name);
			
	System.out.println("File: [" + fileName + "] Accessed for World: [" + save_name + "]");
}

 

I am aware that its not a great way of doing it, but I have a robust system for saving and reading from files, which I have been using for a long while now.

  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7697

diesieben07

diesieben07    7697

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7697
  • 56382 posts
Posted Friday at 08:07 AM
6 hours ago, Zeher_Monkey said:

but I have a robust system for saving and reading from files

L.A. Noire "Doubt" / Press X To Doubt | Know Your Meme

  • Quote

Share this post


Link to post
Share on other sites

Zeher_Monkey    3

Zeher_Monkey

Zeher_Monkey    3

  • Creeper Killer
  • Zeher_Monkey
  • Members
  • 3
  • 125 posts
Posted Friday at 10:31 PM
14 hours ago, diesieben07 said:

L.A. Noire "Doubt" / Press X To Doubt | Know Your Meme

 

That made me laugh! Okay maybe not robust, but it has been reliable for me so far. I use a GSON -> JSON converter with custom TypeAdapters for objects GSON doesn't already know how to convert. Works for my purposes.

Thanks for your help!

  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7697

diesieben07

diesieben07    7697

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7697
  • 56382 posts
Posted Saturday at 09:37 AM

Or, you know, you could just use WorldSavedData which is known to be robust, has a way more compact data format than JSON and doesn't require you to reengineer things whenever a new game update comes out...

  • Quote

Share this post


Link to post
Share on other sites

Zeher_Monkey    3

Zeher_Monkey

Zeher_Monkey    3

  • Creeper Killer
  • Zeher_Monkey
  • Members
  • 3
  • 125 posts
Posted Saturday at 09:14 PM
11 hours ago, diesieben07 said:

Or, you know, you could just use WorldSavedData which is known to be robust, has a way more compact data format than JSON and doesn't require you to reengineer things whenever a new game update comes out...

Very true, but to be honest my code only needed a few lines updated. I want to move to something more native, but am struggling to find references to WorldSavedData. I am not worried about compact data, there is only 1 master file which contains each registered object, and each object is only ~3KB in size. It allows easy debugging, and on servers specifically, tweaks to the data that do not require things like NBTExplorer to use. It works for my purposes.

  • Quote

Share this post


Link to post
Share on other sites

diesieben07    7697

diesieben07

diesieben07    7697

  • Reality Controller
  • diesieben07
  • Forum Team
  • 7697
  • 56382 posts
Posted Sunday at 09:36 AM

Its your own choice, of course. But writing your own database is almost always a terrible idea.

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 0
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Draco18s
      [1.16.x] Custom block as a shop

      By Draco18s · Posted 43 minutes ago

      So, if your parses throw a NumberFormatException.... what values will price and quantity contain when buyItem is called? You still don't actually need this check. You don't need to do this... signTe.signText is a public ITextComponentString[]...
    • Deadlocked47
      Can't get into forge discord

      By Deadlocked47 · Posted 50 minutes ago

      Bump
    • moyas1009
      Texture for new Layer

      By moyas1009 · Posted 1 hour ago

      Hi, I'm making a layer that goes over the player's head, so far I've gotten the model to render correctly but I don't know what to put in the json so that the texture renders or if I should even make a json in the first place, any help is greatly appreciated
    • ThisIsNotOriginal
      When I try to run my mod after I just added Deferred Registries it crashes

      By ThisIsNotOriginal · Posted 1 hour ago

      when i run it the game gets terminated and doesnt give me a log except the one i provided  
    • ThisIsNotOriginal
      When I try to run my mod after I just added Deferred Registries it crashes

      By ThisIsNotOriginal · Posted 1 hour ago

      idk where that is this si the only file it shows me  
  • Topics

    • Retsal
      5
      [1.16.x] Custom block as a shop

      By Retsal
      Started 14 hours ago

    • Deadlocked47
      2
      Can't get into forge discord

      By Deadlocked47
      Started Saturday at 06:58 PM

    • moyas1009
      0
      Texture for new Layer

      By moyas1009
      Started 1 hour ago

    • ThisIsNotOriginal
      3
      When I try to run my mod after I just added Deferred Registries it crashes

      By ThisIsNotOriginal
      Started 4 hours ago

    • keepercreeper22
      0
      I need help with getting a old world of mine back on a older version of forge(yes i know old forge is not supported, i dont care if admins try to help even if people that are experienced would be great

      By keepercreeper22
      Started 3 hours ago

  • Who's Online (See full list)

    • brok4d
    • ThisIsNotOriginal
    • mcnuggies
    • samjviana
    • DavidM
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [SOLVED] 1.16.3 How to get the World Name for saving files in the /saves folder
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community