Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16.5] Help with custom Event


Recommended Posts

I have created a custom event which allows me to change the EnchantmentData list in the enchantingtable.

For this I overwritten the enchanting table and the classes connected to it (container, tileentity, screen, etc.).

I looked at the forge events and created my own event from it (Eventfactory and Event).

when I try to use the event I get an error (EventBus#Mod) or it is not called (EventBus#Forge).

since I'm sure (since it is a mod event so EventBus#Mod!?!) that I have to use the EventBus#Mod I don't know why the event doesn't work or why i got an error.

this is my EventFactory:

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/api/event/ModEventFactory.java

this is my custom event:

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/api/event/events/EnchantmentSetEvent.java

this is the error log when using EventBus#Mod:

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/Error Log from Custom Event

 

1. which is the correct EventBus?

2. what's wrong with my event / or is something missing?

 

Link to post
Share on other sites

 

51 minutes ago, loordgek said:

forge bus

is for when the game starts

I already thought I wasn't sure

 

where is the error then?

this is my enchanting table container (where i sue the event)

https://github.com/Luis-st/Forge-1.16.5-36.0.1-mdk/blob/main/forge-1.16.5-36.0.1-mdk/src/main/java/net/luis/cave/common/inventory/container/ModEnchantingTableContainer.java

Link to post
Share on other sites

The error is caused by registering the event to the wrong bus.

Change the bus, error goes away.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites
17 minutes ago, Draco18s said:

The error is caused by registering the event to the wrong bus.

Change the bus, error goes away.

I've already found out that the bus is wrong

 

5 minutes ago, loordgek said:

you never post the event

what do you mean by that?

do you mean this:

MinecraftForge.EVENT_BUS.post(event)

 

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • For attached capabilities to be saved your ICapabilityProvider needs to implement INBTSerializable (or you can use the combination interface ICapabilitySerializable) and it needs to save any capabilities it provides to NBT.
    • It works fine in-game, but when I re-enter the world, all the fields are set to their default values. Its strange because Ive implemented writeNBT and readNBT methods. Also client and server are synchronized, so its not the problem. Capability code:   public class SoulCap { public int parryTimer = 0; public int CATimer = 0; public boolean justParried = false; public boolean rightClicked = false; public boolean leftClicked = false; public double mana = 0; public double maxMana = 10; public HashMap<String, Integer> usedKeyItems = new HashMap<>(); public boolean trySpendMana(double a) { if (mana >= a){ mana -= a; return true; } return false; } public void addMana(double a){ mana += a; if (mana > maxMana) mana = maxMana; } public CompoundNBT getNbt(){ CompoundNBT tag = new CompoundNBT(); tag.putInt("parryTimer", parryTimer); tag.putInt("CATimer", CATimer); tag.putBoolean("justParried", justParried); tag.putBoolean("rightClicked", rightClicked); tag.putBoolean("leftClicked", leftClicked); tag.putDouble("mana", mana); tag.putDouble("maxMana", maxMana); CompoundNBT keyItems = new CompoundNBT(); for (String s : usedKeyItems.keySet()){ keyItems.putInt(s, usedKeyItems.get(s)); } tag.put("usedKeyItems", keyItems); return tag; } public SoulCap setNbt(CompoundNBT nbt){ parryTimer = nbt.getInt("parryTimer"); CATimer= nbt.getInt("CATimer"); justParried = nbt.getBoolean("justParried"); rightClicked = nbt.getBoolean("rightClicked"); leftClicked = nbt.getBoolean("leftClicked"); mana = nbt.getDouble("mana"); maxMana = nbt.getDouble("maxMana"); CompoundNBT keyItems = nbt.getCompound("usedKeyItems"); for (String s : keyItems.keySet()){ usedKeyItems.put(s, keyItems.getInt(s)); } return this; } public static class SoulProvider implements ICapabilityProvider { @CapabilityInject(SoulCap.class) public static Capability<SoulCap> SOUL_CAP; private final LazyOptional<SoulCap> instance = LazyOptional.of(() -> new SoulCap()); @Override public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap, @Nullable Direction side) { return cap == SOUL_CAP ? instance.cast() : LazyOptional.empty(); } @Override public <T> LazyOptional<T> getCapability(@Nonnull Capability<T> cap) { return cap == SOUL_CAP ? instance.cast() : LazyOptional.empty(); } } public static class SoulStorage implements Capability.IStorage<SoulCap> { @Override public INBT writeNBT(Capability<SoulCap> capability, SoulCap soulCap, Direction side) { return soulCap.getNbt(); } @Override public void readNBT(Capability<SoulCap> capability, SoulCap soulCap, Direction side, INBT nbt) { soulCap.setNbt((CompoundNBT)nbt); } } } Registering:   @Mod("soul") @Mod.EventBusSubscriber(bus=Mod.EventBusSubscriber.Bus.MOD) public class Soul { // //various stuff // @SubscribeEvent public static void setup(final FMLCommonSetupEvent event) { CapabilityManager.INSTANCE.register(SoulCap.class, new SoulCap.SoulStorage(), () -> new SoulCap()); } } Attaching: @Mod.EventBusSubscriber public class CapabilityEvents { @SubscribeEvent static void playerCapability(AttachCapabilitiesEvent<Entity> event){ if (event.getObject() instanceof PlayerEntity) { event.addCapability(new ResourceLocation(Soul.id, "soul"), new SoulCap.SoulProvider()); } } }  
    • https://minecraft.fandom.com/wiki/Tutorials/Creating_a_resource_pack#Animation_Properties
    • you will need: a custom block (your crafting table block) a custom WorkbenchContainer, you need to overwrite the stillValid method and if you want you can change some vanilla logic  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.