Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

JsonReloadListener client/server separation


Recommended Posts

Hello everyone!

 

In one of my mods, I have a JsonReloadListener for a data-driven spell system (Magics.java). These magics are synched via packets to the client. The problem is that on single-player, the logical server and client shares the same Magics instance, which means that the client will overwrite the magics for the server when it receives the synch packet (as well as other potential problems such as race-conditions). Now I want to fix this issue, by having separate Magics instances for the server and client. The problem then is that there are some cases (for instance in the getUseDuration() method here), where I don't have access to a World, and don't know if it is called on the logical client or server, and therefore won't know which Magics instance to access. The Forge documentation on sides mentions that you can use thread groups (here) to determine if we are currently on the logical client or server, but only via an 'educated guess'. I don't know if that is reliable enough. Do you guys have any suggestions?

Edited by vemerion
Link to post
Share on other sites
19 minutes ago, diesieben07 said:

Yeah I don't think there is much you can do but use EffectiveSide.get here.

Alright, thank you! So, I should use the world to determine the side when possible, and in the few cases where I cannot, I have to use EffectiveSide.get(), correct? Should I be worried about the possibility of getting the wrong side from EffectiveSide.get(), or are the risks negligible?

Link to post
Share on other sites

If you are sure you are only on the main server thread or the main client thread it should work fine.

However you basically always have a World. getUseDuration now is the first thing I have come across where it doesn't work.

  • Thanks 1
Link to post
Share on other sites
5 minutes ago, diesieben07 said:

If you are sure you are only on the main server thread or the main client thread it should work fine.

However you basically always have a World. getUseDuration now is the first thing I have come across where it doesn't work.

Alright, thank you again! getUseDuration() has actually been a bit of a thorn in my side for some time. When I wanted to make the cast time of the spells dependent on the equipment of the player, I couldn't, because we don't have access to the player, only the itemstack... Anyway, thank you for your help!

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • That is just the modpack, no logs.
    • I created a modpack for me and my friends but we constantly crash after ~5 minutes of playing , Can some one help me please ? Here are the logs and the modpack : https://www.mediafire.com/file/kqnui7c0wzu8t7k/VladPack4-1.16.5.zip/file
    • I wrote a class that stores the BlockPos and BlockState of a specific block that needs to be changed into another block after a certain amount of time. So far I just coded stone bricks being changed into cracked stone bricks. In every worldtickevent I call a method called onTick in which there is a slight chance (1 in 1000) that this change will occur. The class that does this is called DecayHandler.java   DecayHandler.Java :   public class DecayHandler { public BlockState blockState; public BlockPos blockPos; public World world; private Random random; public int decayChance = 1000; private boolean decayed = false; public DecayHandler(BlockState blockState, BlockPos blockPos, World world){ this.blockState = blockState; this.blockPos = blockPos; this.world = world; random = new Random(); } public DecayHandler OnTick(){ //TODO: Refactor in other methods and implement BlockSwapper if(random.nextInt(decayChance) == 0 && !decayed){ System.out.println(this.blockPos + " Decayed"); if(world.setBlockAndUpdate(blockPos, Blocks.CRACKED_STONE_BRICKS.getBlock().defaultBlockState())){ this.blockState = Blocks.CRACKED_STONE_BRICKS.getBlock().defaultBlockState(); decayed = true; return this; } } //WorldDecayData.get(); return null; } }   This code works fine when I load in to a world and place stone bricks down. The stone bricks stay there for a couple of seconds and then they change into cracked stone bricks. The problem occurs when I save and quit to title and rejoin the same world when I placed stone brick that hadn't decayed yet. The game seems to remember what DecayHandlers were running which I guess is logical because I never closed it. So when the world is reloaded again my code stops without error and no longer functions. I can see in the terminal that the last message that was displayed was that a block decayed so I put a breakpoint on it to see what went wrong. By the way, the game keeps running just fine but my code just stops. The part where it seems to go wrong is in this line:  if(world.setBlockAndUpdate(blockPos, Blocks.CRACKED_STONE_BRICKS.getBlock().defaultBlockState())) When I try to step in to every single detail the callstack becomes insanely large and I'm unable to understand what's going on. The only thing I know is that right at the end they put my thread in to parking or something? I really don't understand what was going on. Can someone explain why this is happening? I don't have a clue of what's going on.
    • Thank you @ChampionAsh5357 for your replies and useful feedback! I'll follow your advice and see where it takes me.
    • This statement is a bit incorrect. The methods still exist, they just use a different mapping set (MCP) than what forge ships with the mdk by default (mojmap). You can use forge-bot on the Forge Discord or Linkie on the Linkie Discord to translate from them. I would probably use a chunk capability instead and tick logic on loaded chunks since you'd have to check every block if it's loaded other than checking the loaded chunks. You could also use a world capability to store the chunks that have an active capability for more efficient usage.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.