Jump to content

[1.15.2] Loading does not end when using a specific Properties


Zemelua

Recommended Posts

public class HalfTimberBlock extends Block {
	public static final EnumProperty<TimberType> TIMBER_NORTH = ExpansionModBlockStateProperties.TIMBER_TYPE_NORTH;
	public static final EnumProperty<TimberType> TIMBER_SOUTH = ExpansionModBlockStateProperties.TIMBER_TYPE_SOUTH;
	public static final EnumProperty<TimberType> TIMBER_WEST = ExpansionModBlockStateProperties.TIMBER_TYPE_WEST;
	public static final EnumProperty<TimberType> TIMBER_EAST = ExpansionModBlockStateProperties.TIMBER_TYPE_EAST;
	public static final EnumProperty<Combination3x3> CT_SHAPE_NORTH = ExpansionModBlockStateProperties.CT_SHAPE_3x3_NORTH;
	public static final EnumProperty<Combination3x3> CT_SHAPE_SOUTH = ExpansionModBlockStateProperties.CT_SHAPE_3x3_SOUTH;
	public static final EnumProperty<Combination3x3> CT_SHAPE_WEST = ExpansionModBlockStateProperties.CT_SHAPE_3x3_WEST;
	public static final EnumProperty<Combination3x3> CT_SHAPE_EAST = ExpansionModBlockStateProperties.CT_SHAPE_3x3_EAST;
	public static final EnumProperty<Combination3x3> CT_LOC_NORTH = ExpansionModBlockStateProperties.CT_LOC_3x3_NORTH;
	public static final EnumProperty<Combination3x3> CT_LOC_SOUTH = ExpansionModBlockStateProperties.CT_LOC_3x3_SOUTH;
	public static final EnumProperty<Combination3x3> CT_LOC_WEST = ExpansionModBlockStateProperties.CT_LOC_3x3_WEST;
	public static final EnumProperty<Combination3x3> CT_LOC_EAST = ExpansionModBlockStateProperties.CT_LOC_3x3_EAST;

	public HalfTimberBlock(Properties properties) {
		super(properties);
		this.setDefaultState(this.stateContainer.getBaseState()
			.with(TIMBER_NORTH, TimberType.CROSS)
			.with(TIMBER_SOUTH, TimberType.NONE)
			.with(TIMBER_WEST, TimberType.LEFT)
			.with(TIMBER_EAST, TimberType.RIGHT)
			.with(CT_SHAPE_NORTH, Combination3x3.COMBINATION1x1)
			.with(CT_SHAPE_SOUTH, Combination3x3.COMBINATION1x1)
			.with(CT_SHAPE_WEST, Combination3x3.COMBINATION1x1)
			.with(CT_SHAPE_EAST, Combination3x3.COMBINATION1x1)
			.with(CT_LOC_NORTH, Combination3x3.COMBINATION1x1)
			.with(CT_LOC_SOUTH, Combination3x3.COMBINATION1x1)
			.with(CT_LOC_WEST, Combination3x3.COMBINATION1x1)
			.with(CT_LOC_EAST, Combination3x3.COMBINATION1x1)

		);
	}

	@Override
	public BlockState getStateForPlacement(BlockItemUseContext context) {
		int rotation = MathHelper.floor((double)(context.getPlacementYaw() * 8.0F / 360.0F) + 0.5D) & 7;
		TimberType[] rotations = new TimberType[4];
		switch (rotation % 2) {
			case 0:
				int index0 = rotation / 2;
				ExpansionMod.LOGGER.debug(rotation);
				ExpansionMod.LOGGER.debug(index0);
				rotations[index0] = TimberType.CROSS;
				index0 ++;
				if (index0 == 4) index0 = 0;
				rotations[index0] = TimberType.RIGHT;
				index0 ++;
				if (index0 == 4) index0 = 0;
				rotations[index0] = TimberType.NONE;
				index0 ++;
				if (index0 == 4) index0 = 0;
				rotations[index0] = TimberType.LEFT;
				break;
			case 1:
				int index1 = (rotation + 1) / 2;
				if (index1 == 4) index1 = 0;
				rotations[index1] = TimberType.LEFT;
				index1 ++;
				if (index1 == 4) index1 = 0;
				rotations[index1] = TimberType.LEFT;
				index1 ++;
				if (index1 == 4) index1 = 0;
				rotations[index1] = TimberType.RIGHT;
				index1 ++;
				if (index1 == 4) index1 = 0;
				rotations[index1] = TimberType.RIGHT;
				break;
		}

		return this.getDefaultState()
			.with(TIMBER_NORTH, rotations[0])
			.with(TIMBER_SOUTH, rotations[2])
			.with(TIMBER_WEST,  rotations[3])
			.with(TIMBER_EAST,  rotations[1]);
	}

	@Override
	protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
		builder.add(
			TIMBER_NORTH,
			TIMBER_SOUTH,
			TIMBER_WEST,
			TIMBER_EAST,
			CT_SHAPE_NORTH,
			CT_SHAPE_SOUTH,
			CT_SHAPE_WEST,
			CT_SHAPE_EAST,
			CT_LOC_NORTH,
			CT_LOC_SOUTH,
			CT_LOC_WEST,
			CT_LOC_EAST
		);
	}
}
public enum TimberType implements IStringSerializable {
	NONE("none"),
	RIGHT("right"),
	LEFT("left"),
	CROSS("cross");

	private final String shapeName;

	TimberType(String shapeName) {
		this.shapeName = shapeName;
	}

	@Override
	public String toString() {
		return this.getString();
	}

	@Override
	public String getString() {
		return this.shapeName;
	}
}
public enum Combination3x3 implements IStringSerializable {
	COMBINATION1x1("1x1"),
	COMBINATION1x2("1x2"),
	COMBINATION1x3("1x3"),
	COMBINATION2x1("2x1"),
	COMBINATION2x2("2x2"),
	COMBINATION2x3("2x3"),
	COMBINATION3x1("3x1"),
	COMBINATION3x2("3x2"),
	COMBINATION3x3("3x3");

	private final String combinationName;

	Combination3x3(String combinationName) { this.combinationName = combinationName; }

	@Override
	public String toString() {
		return this.getString();
	}

	@Override
	public String getString() {
		return this.combinationName;
	}
}

In the above code, when I start Minecraft, it becomes "no response" in the middle of loading, and loading does not end from there.
Removing the Combination3x3 EnumProperty builder.add and setDefaultState (this.stateContainer.getBaseState (). With () works fine, but using the 8 Combination3x3 properties doesn't finish loading. What's in the error log? Was not displayed. What is happening? How can I fix it?

Link to comment
Share on other sites

I can add a TileEntity, but I don't know how to get it with IBakedModel # getQuads. Looking at various vanilla codes, it seems that you can get the TileEntity if you know the coordinates, but I don't know how to get the coordinates.
Or, I want to create a Connecting Texture after all, so I can use IBakedModel # getQuads to get the top, bottom, left, and right blocks without using TileEntity. After all, it's the same as the problem with TileEntity. So how do you get the coordinates with IBakedModel # getQuads?

Link to comment
Share on other sites

In IBakedMode#getQuads, I want to check if there are blocks of the same type on the top, bottom, left and right, and replace the texture of the model accordingly. To do this, I first need to get the coordinates of the block.

Link to comment
Share on other sites

When the north faces of multiple blocks are connected, the shape will be a rectangle of up to 3x3, and the texture will be pasted according to the shape. At this time, since it is necessary to indicate the position of the north surface of one block in the rectangular parallelepiped, there are two types of properties, the size (CT_SHAPE_NORTH) and the position (CT_LOC_NORTH) of the rectangle to which the surface of the block belongs. there is. The same applies to the remaining three sides.

Link to comment
Share on other sites

getQuads receive an IModelData parameter, which is the return value in getModelData.

getModelData has the world, blockstate, and blockpos

you can override it and return the data you need through a ModelDataMap.

 

I'm not sure, however, if you need to store those values in either blockstate or a tile entity. since they're only relevant to the client, and you can calculate them on getModelData (for optimization you could cache the data in the BakedModel, and have a boolean blockstate in the block which tells wether or not you need to update the cached value)

 

EDIT: I just realized that this topic is for 1.15, not 1.16. I'm not sure if the interfaces are the same... but I don't think they should be much different (my bad)

Edited by kiou.23
Link to comment
Share on other sites

1 minute ago, Zemelua said:

Although it is not the purpose, I tried to use the mcmeta file instead of modelJSON by referring to ConnectedTexturesMod to organize the code, but even if I go back to Loader etc., it seems that I am using modelJSON only. Don't know where the code you're reading from mcmeta is ...?

https://github.com/Chisel-Team/ConnectedTexturesMod

I'm not sure I understood what you mean by this... could you elaborate?

Link to comment
Share on other sites

In ConnectedTextureMod, it seems that you can change the texture by texture.png.mcmeta (similar to defining animation). If you dig deeper into the code, it looks like TextureStitchEvent.Pre is reading the metadata, but I'm not sure what's really going on.

Link to comment
Share on other sites

Please sign in to comment

You will be able to leave a comment after signing in



Sign In Now

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I've been having trouble launching forge 1.19.4, i watched YouTube videos but i still don't have a solution.
    • This is my code: private void addCreative(Register<Block> event) { if (event.getTab() == CreativeModeTabs.BUILDING_BLOCKS) event.register(EXAMPLE_BLOCK); } Cannot resolve symbol 'Register'   How do I fix? I have tried the import import net.minecraftforge.registries.Register; but it doesn't work.   I also have these problems on that same code: Cannot resolve method 'getTab()' Cannot resolve method 'register(RegistryObject<Block>)'
    • my arrow wont move at all it would stay mid air and show no collision   my Entity class: package net.jeezedboi.epicraft.entity.custom; import net.jeezedboi.epicraft.init.ModItems; import net.minecraft.entity.EntityType; import net.minecraft.entity.LivingEntity; import net.minecraft.entity.projectile.AbstractArrowEntity; import net.minecraft.item.ItemStack; import net.minecraft.network.IPacket; import net.minecraft.util.math.EntityRayTraceResult; import net.minecraft.world.Explosion; import net.minecraft.world.World; import net.minecraftforge.fml.network.NetworkHooks; public class ExplosiveArrowEntity extends AbstractArrowEntity { // default constructor, required to register the entity public ExplosiveArrowEntity(EntityType<ExplosiveArrowEntity> entityType, World world) { super(entityType, world); } public ExplosiveArrowEntity(EntityType<ExplosiveArrowEntity> entityType, double x, double y, double z, World world) { super(entityType, x, y, z, world); } // the constructor used by the ArrowItem public ExplosiveArrowEntity(EntityType<ExplosiveArrowEntity> entityType, LivingEntity shooter, World world) { super(entityType, shooter, world); } // the item stack to give the player when they walk over your arrow stuck in the ground @Override protected ItemStack getArrowStack() { return new ItemStack(ModItems.EXPLOSIVE_ARROW.get()); } @Override protected void onEntityHit(EntityRayTraceResult result) { super.onEntityHit(result); // this, x, y, z, explosionStrength, setsFires, breakMode (NONE, BREAK, DESTROY) this.world.createExplosion(this, this.getPosX(), this.getPosY(), this.getPosZ(), 4.0f, true, Explosion.Mode.BREAK); } // called each tick while in the ground @Override public void tick() { if (this.timeInGround > 60){ this.world.createExplosion(this, this.getPosX(), this.getPosY(), this.getPosZ(), 4.0f, true, Explosion.Mode.BREAK); this.remove(); } } // syncs to the client @Override public IPacket<?> createSpawnPacket() { return NetworkHooks.getEntitySpawningPacket(this); } } my item class :   package net.jeezedboi.epicraft.item.custom; import net.jeezedboi.epicraft.entity.custom.ExplosiveArrowEntity; import net.jeezedboi.epicraft.init.ModEntityTypes; import net.minecraft.entity.LivingEntity; import net.minecraft.entity.projectile.AbstractArrowEntity; import net.minecraft.item.ArrowItem; import net.minecraft.item.ItemStack; import net.minecraft.world.World; public class ExplosiveArrowItem extends ArrowItem { public ExplosiveArrowItem(Properties props) { super(props); } @Override public AbstractArrowEntity createArrow(World world, ItemStack ammoStack, LivingEntity shooter) { ExplosiveArrowEntity explosiveArrowEntity = new ExplosiveArrowEntity(ModEntityTypes.EXPLOSIVE_ARROW.get(), shooter, world); return explosiveArrowEntity; } } other stuffs: public static final RegistryObject<Item> EXPLOSIVE_ARROW = ITEMS.register("explosive_arrow", () -> new ExplosiveArrowItem(new Item.Properties().group(ModItemGroup.Epic_Items))); public static final RegistryObject<EntityType<ExplosiveArrowEntity>> EXPLOSIVE_ARROW = ENTITY_TYPES.register("explosive_arrow", () -> EntityType.Builder.create((EntityType.IFactory<ExplosiveArrowEntity>) ExplosiveArrowEntity::new, EntityClassification.MISC) .size(0.5F, 0.5F).build("explosive_arrow")); mappings channel: 'snapshot', version: '20210309-1.16.5'
    • may i ask what it was that fixed it, I'm having the same problem and its frustrating because I'm making an origin.
    • I need to accesses byPath field of net.minecraft.client.renderer.texture.TextureManager. As I found out I need to use accesstransformer.cfg file and make the field public via it. In this file field names look like f_<numbers>. And I was unable to figure out, how to get those. It seems like it is connected to something called mappings (thing left after Minecraft decompile process). How can I get such a name for a class field?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.