Jump to content

[1.15.2] Loading does not end when using a specific Properties


Zemelua

Recommended Posts

public class HalfTimberBlock extends Block {
	public static final EnumProperty<TimberType> TIMBER_NORTH = ExpansionModBlockStateProperties.TIMBER_TYPE_NORTH;
	public static final EnumProperty<TimberType> TIMBER_SOUTH = ExpansionModBlockStateProperties.TIMBER_TYPE_SOUTH;
	public static final EnumProperty<TimberType> TIMBER_WEST = ExpansionModBlockStateProperties.TIMBER_TYPE_WEST;
	public static final EnumProperty<TimberType> TIMBER_EAST = ExpansionModBlockStateProperties.TIMBER_TYPE_EAST;
	public static final EnumProperty<Combination3x3> CT_SHAPE_NORTH = ExpansionModBlockStateProperties.CT_SHAPE_3x3_NORTH;
	public static final EnumProperty<Combination3x3> CT_SHAPE_SOUTH = ExpansionModBlockStateProperties.CT_SHAPE_3x3_SOUTH;
	public static final EnumProperty<Combination3x3> CT_SHAPE_WEST = ExpansionModBlockStateProperties.CT_SHAPE_3x3_WEST;
	public static final EnumProperty<Combination3x3> CT_SHAPE_EAST = ExpansionModBlockStateProperties.CT_SHAPE_3x3_EAST;
	public static final EnumProperty<Combination3x3> CT_LOC_NORTH = ExpansionModBlockStateProperties.CT_LOC_3x3_NORTH;
	public static final EnumProperty<Combination3x3> CT_LOC_SOUTH = ExpansionModBlockStateProperties.CT_LOC_3x3_SOUTH;
	public static final EnumProperty<Combination3x3> CT_LOC_WEST = ExpansionModBlockStateProperties.CT_LOC_3x3_WEST;
	public static final EnumProperty<Combination3x3> CT_LOC_EAST = ExpansionModBlockStateProperties.CT_LOC_3x3_EAST;

	public HalfTimberBlock(Properties properties) {
		super(properties);
		this.setDefaultState(this.stateContainer.getBaseState()
			.with(TIMBER_NORTH, TimberType.CROSS)
			.with(TIMBER_SOUTH, TimberType.NONE)
			.with(TIMBER_WEST, TimberType.LEFT)
			.with(TIMBER_EAST, TimberType.RIGHT)
			.with(CT_SHAPE_NORTH, Combination3x3.COMBINATION1x1)
			.with(CT_SHAPE_SOUTH, Combination3x3.COMBINATION1x1)
			.with(CT_SHAPE_WEST, Combination3x3.COMBINATION1x1)
			.with(CT_SHAPE_EAST, Combination3x3.COMBINATION1x1)
			.with(CT_LOC_NORTH, Combination3x3.COMBINATION1x1)
			.with(CT_LOC_SOUTH, Combination3x3.COMBINATION1x1)
			.with(CT_LOC_WEST, Combination3x3.COMBINATION1x1)
			.with(CT_LOC_EAST, Combination3x3.COMBINATION1x1)

		);
	}

	@Override
	public BlockState getStateForPlacement(BlockItemUseContext context) {
		int rotation = MathHelper.floor((double)(context.getPlacementYaw() * 8.0F / 360.0F) + 0.5D) & 7;
		TimberType[] rotations = new TimberType[4];
		switch (rotation % 2) {
			case 0:
				int index0 = rotation / 2;
				ExpansionMod.LOGGER.debug(rotation);
				ExpansionMod.LOGGER.debug(index0);
				rotations[index0] = TimberType.CROSS;
				index0 ++;
				if (index0 == 4) index0 = 0;
				rotations[index0] = TimberType.RIGHT;
				index0 ++;
				if (index0 == 4) index0 = 0;
				rotations[index0] = TimberType.NONE;
				index0 ++;
				if (index0 == 4) index0 = 0;
				rotations[index0] = TimberType.LEFT;
				break;
			case 1:
				int index1 = (rotation + 1) / 2;
				if (index1 == 4) index1 = 0;
				rotations[index1] = TimberType.LEFT;
				index1 ++;
				if (index1 == 4) index1 = 0;
				rotations[index1] = TimberType.LEFT;
				index1 ++;
				if (index1 == 4) index1 = 0;
				rotations[index1] = TimberType.RIGHT;
				index1 ++;
				if (index1 == 4) index1 = 0;
				rotations[index1] = TimberType.RIGHT;
				break;
		}

		return this.getDefaultState()
			.with(TIMBER_NORTH, rotations[0])
			.with(TIMBER_SOUTH, rotations[2])
			.with(TIMBER_WEST,  rotations[3])
			.with(TIMBER_EAST,  rotations[1]);
	}

	@Override
	protected void fillStateContainer(StateContainer.Builder<Block, BlockState> builder) {
		builder.add(
			TIMBER_NORTH,
			TIMBER_SOUTH,
			TIMBER_WEST,
			TIMBER_EAST,
			CT_SHAPE_NORTH,
			CT_SHAPE_SOUTH,
			CT_SHAPE_WEST,
			CT_SHAPE_EAST,
			CT_LOC_NORTH,
			CT_LOC_SOUTH,
			CT_LOC_WEST,
			CT_LOC_EAST
		);
	}
}
public enum TimberType implements IStringSerializable {
	NONE("none"),
	RIGHT("right"),
	LEFT("left"),
	CROSS("cross");

	private final String shapeName;

	TimberType(String shapeName) {
		this.shapeName = shapeName;
	}

	@Override
	public String toString() {
		return this.getString();
	}

	@Override
	public String getString() {
		return this.shapeName;
	}
}
public enum Combination3x3 implements IStringSerializable {
	COMBINATION1x1("1x1"),
	COMBINATION1x2("1x2"),
	COMBINATION1x3("1x3"),
	COMBINATION2x1("2x1"),
	COMBINATION2x2("2x2"),
	COMBINATION2x3("2x3"),
	COMBINATION3x1("3x1"),
	COMBINATION3x2("3x2"),
	COMBINATION3x3("3x3");

	private final String combinationName;

	Combination3x3(String combinationName) { this.combinationName = combinationName; }

	@Override
	public String toString() {
		return this.getString();
	}

	@Override
	public String getString() {
		return this.combinationName;
	}
}

In the above code, when I start Minecraft, it becomes "no response" in the middle of loading, and loading does not end from there.
Removing the Combination3x3 EnumProperty builder.add and setDefaultState (this.stateContainer.getBaseState (). With () works fine, but using the 8 Combination3x3 properties doesn't finish loading. What's in the error log? Was not displayed. What is happening? How can I fix it?

Link to comment
Share on other sites

I can add a TileEntity, but I don't know how to get it with IBakedModel # getQuads. Looking at various vanilla codes, it seems that you can get the TileEntity if you know the coordinates, but I don't know how to get the coordinates.
Or, I want to create a Connecting Texture after all, so I can use IBakedModel # getQuads to get the top, bottom, left, and right blocks without using TileEntity. After all, it's the same as the problem with TileEntity. So how do you get the coordinates with IBakedModel # getQuads?

Link to comment
Share on other sites

When the north faces of multiple blocks are connected, the shape will be a rectangle of up to 3x3, and the texture will be pasted according to the shape. At this time, since it is necessary to indicate the position of the north surface of one block in the rectangular parallelepiped, there are two types of properties, the size (CT_SHAPE_NORTH) and the position (CT_LOC_NORTH) of the rectangle to which the surface of the block belongs. there is. The same applies to the remaining three sides.

Link to comment
Share on other sites

getQuads receive an IModelData parameter, which is the return value in getModelData.

getModelData has the world, blockstate, and blockpos

you can override it and return the data you need through a ModelDataMap.

 

I'm not sure, however, if you need to store those values in either blockstate or a tile entity. since they're only relevant to the client, and you can calculate them on getModelData (for optimization you could cache the data in the BakedModel, and have a boolean blockstate in the block which tells wether or not you need to update the cached value)

 

EDIT: I just realized that this topic is for 1.15, not 1.16. I'm not sure if the interfaces are the same... but I don't think they should be much different (my bad)

Edited by kiou.23
Link to comment
Share on other sites

1 minute ago, Zemelua said:

Although it is not the purpose, I tried to use the mcmeta file instead of modelJSON by referring to ConnectedTexturesMod to organize the code, but even if I go back to Loader etc., it seems that I am using modelJSON only. Don't know where the code you're reading from mcmeta is ...?

https://github.com/Chisel-Team/ConnectedTexturesMod

I'm not sure I understood what you mean by this... could you elaborate?

Link to comment
Share on other sites

In ConnectedTextureMod, it seems that you can change the texture by texture.png.mcmeta (similar to defining animation). If you dig deeper into the code, it looks like TextureStitchEvent.Pre is reading the metadata, but I'm not sure what's really going on.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.