Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[Solved] 1.16 Storing ArrayList<BlockPos> to NBT


Recommended Posts

I am currently stuck at storing (and reading) an ArrayList of BlockPos to NBT. I found a thread where they tell you to use a NBTTagList. This does not seem to exist in 1.16 anymore. I know there is the NBTUtil methods for BlockPos which is returning me a new CompoundNBT. The idea I have is to use the NBTCompound#put(String key, INBT value) method and just add a incremental number to my key for every object in my ArrayList. But that sounds dirty to me. Is there a better way?

Edited by Titmar
Problem solved
Link to post
Share on other sites

To serialize:

Store the length of the array.

Push all serialized BlockPos values.

To deserialize:

Read the length of the array.

Deserialize that many BlockPos values.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to post
Share on other sites

So basically the idea i had. I just tested it and I have no idea why it wont work.

 

	@Override
	public CompoundNBT write(CompoundNBT compound) {
		super.write(compound);
		compound.putInt("containerArray", containers.size());
		int i = 0;
		for (BlockPos bp : containers) {
			compound.put("pos" + i, NBTUtil.writeBlockPos(bp));
			i++;
		}
		return compound;
	}

	@Override
	public void read(BlockState state, CompoundNBT nbt) {
		super.read(state, nbt);
		int size = nbt.getInt("containerArray");
		for (int i = 0; i <= size; i++) {
			BlockPos bp = NBTUtil.readBlockPos((CompoundNBT) nbt.get("pos" + i));
			containers.add(bp);
		}
	}

 

Link to post
Share on other sites
for (int i = 0; i <= size; i++)

size is the amount of items in the list. but the list is 0-indexed, meaning the items indexes goes from 0 to size - 1

you're trying to get an element at an index which doesn't exist

Link to post
Share on other sites

You are making this way too complicated... ListNBT is a thing.

Pseudocode:

// serialize:
nbt = new ListNBT()
for (pos : positions) {
   nbt.add(NBTUtil.writeBlockPos(pos))
}

// deserialize:
list = new ArrayList()
for (i = 0; i < nbt.size(); i++) {
  list.add(NBTUtil.readBlockPos(nbt.getCompound(i)))
}
   

 

Link to post
Share on other sites

This is actually what i was looking for - a sucessor of the NBTTagList. Thank you sieben. Makes it look way cleaner.

It still does not work though.

 

	@Override
	public CompoundNBT write(CompoundNBT compound) {
		super.write(compound);
		ListNBT nbt = new ListNBT();
		for(BlockPos pos : containers) {
			nbt.add(NBTUtil.writeBlockPos(pos));
		}
		compound.put("containerArray", nbt);
		return compound;
	}

	@Override
	public void read(BlockState state, CompoundNBT compound) {
		super.read(state, compound);
		ArrayList<BlockPos> list = new ArrayList<BlockPos>();
		ListNBT nbt = (ListNBT) compound.get("containerArray");
		for(int i = 0; i < nbt.size(); i++) {
			list.add(NBTUtil.readBlockPos(nbt.getCompound(i)));
		}
		this.containers = list;
	}

Or would i use the compound#getList(name, type) method instead? And if so, what do i put as type?

Link to post
Share on other sites
10 minutes ago, Titmar said:

Or would i use the compound#getList(name, type) method instead?

Yes.

 

10 minutes ago, Titmar said:

And if so, what do i put as type?

One of Constants.NBT. It describes what type of tag is in the list (a COMPOUND in this case).

 

10 minutes ago, Titmar said:

It still does not work though.

Elaborate.

Link to post
Share on other sites
11 minutes ago, diesieben07 said:

Elaborate.

When im accessing the NBT data from a different point (right clicking  the block and outputting into the logger) it shows me an empty NBTList while the private list of the TE has content. After reloading the world all data is lost. Since i dont know how to trigger a read/write i cant tell where the mistake is. Adding a debug message right into the read/write methods does not work either. I dont get any Logger output at all. Seems weird that both functions arent triggered at all...  Will upload to git so you have a full overview.

 

https://github.com/titmar/Caravans/blob/main/src/main/java/io/github/titmar/caravans/common/tile/MarketTileEntity.java

Link to post
Share on other sites

 

Link to post
Share on other sites
  • Ahh, it has been the markDirty part. I knew i missed some crucial part that calls the read/write.
  • As for the HashSet, this is subject to change anyway. In the future i will need to store way more data alongside the position. For now I just wanted to get a proof of concept which I can expand on.
  • I guess I was using the wrong nethod there, it should be getTileData(). The idea was to check if anything has been writen onto the NBTTag. Because if anything has been writen in there and it still didnt work the problem would have been in the read method. As we know now neither was the case.

Thank you for your help!

Link to post
Share on other sites
  • Titmar changed the title to [Solved] 1.16 Storing ArrayList<BlockPos> to NBT
1 hour ago, Titmar said:

I guess I was using the wrong nethod there, it should be getTileData().

No, getTileData is something else.

You should just check the ArrayList<BlockPos>.

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.