Brewing Recipe not working

[eggpasta]

I have a custom brewing recipe that isn't working, the ingredients go in but nothing is coming in the result box

here is my code:

public class brewrecipe implements IBrewingRecipe{
	private static final Logger LOGGER = LogManager.getLogger();
	    private static final ItemStack INGREDIENT = new ItemStack(ModEventSubscriber.CRYOEXTRACT.get());
	    private static final ItemStack OUTPUT = new ItemStack(ModEventSubscriber.CRYOCOCKTAIL.get());

	    brewrecipe() {
	    }

	    @Override
	    public boolean isInput(@Nonnull ItemStack stack) {
	    	LOGGER.info("IBrewingRecipe#isInput: return " + PotionUtils.getPotion(stack) + " == " + Potions.WATER);
	        return PotionUtils.getPotion(stack) == Potions.WATER;
	    }

	    @Override
	    public boolean isIngredient(@Nonnull ItemStack ingredient) {
	    	  LOGGER.info("IBrewingRecipe#isIngredient: return " + INGREDIENT.getItem() + " == " + ModEventSubscriber.CRYOEXTRACT.get());
	        return INGREDIENT.getItem() == ModEventSubscriber.CRYOEXTRACT.get();
	    }

	    @Nonnull
	    @Override
	    public ItemStack getOutput(@Nonnull ItemStack input, @Nonnull ItemStack ingredient) {
	    	LOGGER.info("IBrewingRecipe#getOutput: isInput(input) = " + isInput(input)
            + " isIngredient(ingredient) = " + isIngredient(ingredient)
            + " -> return " + ((isInput(input) && isIngredient(ingredient))
            ? "OUTPUT (=" + OUTPUT + ")" : "ItemStack.EMPTY"));
    LOGGER.info("Target output: " + OUTPUT);
	        if (isInput(input) && isIngredient(ingredient)) {
	        	LOGGER.info("Passed");
	            return new ItemStack(ModEventSubscriber.CRYOCOCKTAIL.get());
	        }
	        LOGGER.info("Failed");
	        return ItemStack.EMPTY;
	    }
	}

and my logs look like this:
 

[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#isInput: return net.minecraft.potion.Potion@644296ef == net.minecraft.potion.Potion@644296ef
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#isIngredient: return cryo_extract == cryo_extract
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#isInput: return net.minecraft.potion.Potion@644296ef == net.minecraft.potion.Potion@644296ef
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#isIngredient: return cryo_extract == cryo_extract
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#getOutput: isInput(input) = true isIngredient(ingredient) = true -> return OUTPUT (=1 cryo_cocktail)
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: Target output: 1 cryo_cocktail
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#isInput: return net.minecraft.potion.Potion@644296ef == net.minecraft.potion.Potion@644296ef
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#isIngredient: return cryo_extract == cryo_extract
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: Passed

why is it not working?

[kiou.23]

please use PascalCase when naming classes

also, what are you doing? there's no need to extend the BrewingRecipe, you can just instantiate a new one

 

[eggpasta]

On 4/12/2021 at 11:02 PM, kiou.23 said:

please use PascalCase when naming classes

also, what are you doing? there's no need to extend the BrewingRecipe, you can just instantiate a new one

 

But how does this solve my issue?

I just need to know why even though it's returning the itemstack nothing is changing in the brewing stand

[diesieben07]

Post a Git repo of your mod.

[eggpasta]

4 hours ago, diesieben07 said:

Post a Git repo of your mod.

BananaSquares/ForgeMod (github.com) I uploaded the src folder

It's the file in the Main package called brewrecipe

Edited April 15, 2021 by eggpasta
Forgot link

[Luis_ST]

41 minutes ago, eggpasta said:

BananaSquares/ForgeMod (github.com) I uploaded the src folder

It's the file in the Main package called brewrecipe

to find the problem we need more than just the "src" folder
short: your repo is incomplete

[diesieben07]

The MDK comes with a properly configured .gitignore for a reason.

[kiou.23]

48 minutes ago, eggpasta said:

BananaSquares/ForgeMod (github.com) I uploaded the src folder

It's the file in the Main package called brewrecipe

the forge mdk already provides a .gitignore that's on the root were you should create yout git repo

also, delete the exampleMod package if you're not using it

also, please use any for mof proper file structure on your mod files, why the heck are your RegistryObjects under ModEventSubscribers??? that class has literally 0 event  subscribers

also, don't create an ItemBase, that's an antipattern and is explained why it's bad code practice in the pinned thread on this subforum

also, please use proper casing, why do you have a class that's all uppercase and another that's all lowercase?? classes should be PascalCased

also, again, there's no need to extend IBrewingRecipe

also, you should be using the proper RegistryEvent to register your brewing recipes, not through deferred work in the setup

[eggpasta]

25 minutes ago, kiou.23 said:

the forge mdk already provides a .gitignore that's on the root were you should create yout git repo

also, delete the exampleMod package if you're not using it

also, please use any for mof proper file structure on your mod files, why the heck are your RegistryObjects under ModEventSubscribers??? that class has literally 0 event  subscribers

also, don't create an ItemBase, that's an antipattern and is explained why it's bad code practice in the pinned thread on this subforum

also, please use proper casing, why do you have a class that's all uppercase and another that's all lowercase?? classes should be PascalCased

also, again, there's no need to extend IBrewingRecipe

also, you should be using the proper RegistryEvent to register your brewing recipes, not through deferred work in the setup

What is the proper registry event?

[eggpasta]

36 minutes ago, Luis_ST said:

to find the problem we need more than just the "src" folder
short: your repo is incomplete

What else do i need to add?

[kiou.23]

4 minutes ago, eggpasta said:

What is the proper registry event?

actually, disregard the RegistryEvent thingy

[Luis_ST]

3 minutes ago, eggpasta said:

What else do i need to add?

used a git client, and created your repo with it, then it contains all the files that are needed

[kiou.23]

5 minutes ago, eggpasta said:

What else do i need to add?

intialize the repo in the directory which contains the build.gradle
that directory should also have a .gitignore which will make sure you don't push anything you shouldn't to github

[eggpasta]

28 minutes ago, kiou.23 said:

intialize the repo in the directory which contains the build.gradle
that directory should also have a .gitignore which will make sure you don't push anything you shouldn't to github

How?

I have git bash instaleld but whenever i do git init and then git add . i get 

error: 'Downloads/forge-1.16.5-36.1.4-mdk/' does not have a commit checked out
fatal: adding files failed

 

[kiou.23]

6 minutes ago, eggpasta said:

How?

I have git bash instaleld but whenever i do git init and then git add . i get 

error: 'Downloads/forge-1.16.5-36.1.4-mdk/' does not have a commit checked out
fatal: adding files failed

 

remove the .git directory that you should have created before in your src/main/java (I assume)
then try again

[eggpasta]

50 minutes ago, kiou.23 said:

remove the .git directory that you should have created before in your src/main/java (I assume)
then try again

Problem solved, the updated repo is here : BananaSquares/Forge-Mod (github.com)

[diesieben07]

It works just fine:

[eggpasta]

5 minutes ago, diesieben07 said:

It works just fine:

That's strange , it does not work for me

[eggpasta]

Never mind i think i fixed it

[kiou.23]

3 hours ago, eggpasta said:

Never mind i think i fixed it

it'd be helpful both for you and other people, if you told how

[eggpasta]

17 minutes ago, kiou.23 said:

it'd be helpful both for you and other people, if you told how

It turns out i just forgot blaze powder 

[eggpasta]

53 minutes ago, kiou.23 said:

it'd be helpful both for you and other people, if you told how

But that brings another question, is it possible to use something else instead of blaze powder

[kiou.23]

4 minutes ago, eggpasta said:

But that brings another question, is it possible to use something else instead of blaze powder

The BrewingStand har checks if the fuel is the Blaze Powder item, you can see it in the BrewingStandTileEntity class
so I assume the only way to get around this would be to replace the vanilla brewing stand