MALfunction84

My pull request is still open, but it's not showing up in the list of All Requests. What does that mean? Is it stale? Does it conflict now with the all the recent 1.4 changes?

Hmm, no movement on this front in a few weeks. I recently updated the pull request with a minor improvement. Here's hoping it gets some attention soon. I don't want to be a pest about it, though. I know Lex is extremely busy.

This has been rewritten as an event. The pull request is here. Thanks to ScottKillen for putting up with this git n00b.

I couldn't find a link to the sources jar for asm-all anywhere, so I downloaded the source code and made my own: http://dl.dropbox.com/u/34550296/asm-all-4.0-source.jar Dropping both this .jar and the one in my previous post into MCP/lib worked great for me.

You can get guava-12.0.1-sources.jar from here. Just stick it in MCP/lib. Still trying to find an alternate source for asm-all-4.0-source.jar.

Do I need to rewrite this as an Event?

Thanks!

We're coming up on a month now with no official word from anyone. Can I put a bounty on this pull request? As in, $x via PayPal to the maintainer who reviews and pulls it? Seems sketchy, so I'm half-joking.

Pull request submitted here.

ScottKillen, I've got a client-side block activation hook available here. It's ready for you to implement the server-side. Thanks again for all your help!

Thanks for responding. There are still references to inject_version.bat in build.bat, so I guess I shouldn't be using build.bat at all? Actually, I've replaced the contents of build.bat with the following, and it seems to work: @echo off ..\runtime\bin\python\python_mcp build.py %* build.sh and setup.sh should probably be similarly altered to invoke their corresponding python scripts, but all this is outside the scope of the feature I'm trying to add.

Thanks! I have my repo set up now with ScottKillen as a collaborator. Right now, it's just an unmodified fork. I'd like to test my changes before I commit them, but when I run build.bat, I get errors... =================================== Build Start ================================= src_work -> src 1872 File(s) copied forge_client -> minecraft [snip] 17 File(s) copied forge_server -> minecraft_server [snip] 3 File(s) copied forge_common -> minecraft [snip] 57 File(s) copied forge_common -> minecraft_server [snip] 57 File(s) copied 'inject_version.bat' is not recognized as an internal or external command, operable program or batch file. 'inject_version.bat' is not recognized as an internal or external command, operable program or batch file. == MCP 6.2 (data: 6.2, client: 1.2.5, server: 1.2.5) == # found jad, ff, jad patches, ff patches, osx patches, srgs, name csvs, doc csvs, param csvs, astyle, astyle config == Recompiling client == > Cleaning bin > Recompiling '"C:\Program Files\Java\jdk1.6.0_33\bin\javac" -Xlint:-options -deprecation -g -source 1.6 -target 1....' failed : 1 == ERRORS FOUND == src\minecraft\net\minecraft\src\forge\ForgeHooks.java:392: warning: [deprecation] net.minecraft.src.forge.ISpecialMobSpawnHandler in net.minecraft.src.forge has been deprecated static LinkedList<ISpecialMobSpawnHandler> specialMobSpawnHandlers = new LinkedList<ISpecialMobSpawnHandler>(); ^ src\minecraft\net\minecraft\src\forge\MinecraftForge.java:181: warning: [deprecation] net.minecraft.src.forge.ISpecialMobSpawnHandler in net.minecraft.src.forge has been deprecated public static void registerSpecialMobSpawnHandler(ISpecialMobSpawnHandler handler) ^ src\minecraft\net\minecraft\src\forge\ModCompatibilityClient.java:8: cannot find symbol symbol : class CodecIBXM location: package paulscode.sound.codecs import paulscode.sound.codecs.CodecIBXM; ^ src\minecraft\net\minecraft\src\forge\ModCompatibilityClient.java:130: cannot find symbol symbol : class CodecIBXM location: class net.minecraft.src.forge.ModCompatibilityClient SoundSystemConfig.setCodec("xm", CodecIBXM.class); ^ src\minecraft\net\minecraft\src\forge\ModCompatibilityClient.java:131: cannot find symbol symbol : class CodecIBXM location: class net.minecraft.src.forge.ModCompatibilityClient SoundSystemConfig.setCodec("s3m", CodecIBXM.class); ^ src\minecraft\net\minecraft\src\forge\ModCompatibilityClient.java:132: cannot find symbol symbol : class CodecIBXM location: class net.minecraft.src.forge.ModCompatibilityClient SoundSystemConfig.setCodec("mod", CodecIBXM.class); ^ 4 errors 2 warnings ================== == Recompiling server == > Cleaning bin > Recompiling - Done in 5.47 seconds =================================== Build Finished 0 ================================= The file inject_version.bat is not present in the repo anywhere. It was removed on April 6, 2012. I have no idea why CodecIBXM.class is not found. Actually, that's not true. In build.bat, it only copies the forge_client\src\net path, which omits forge_client\src\paulscode and forgeclient\src\ibxm... xcopy /Y /E forge\forge_client\src\net\* src\minecraft\net My only thought is that I must have set up my workspace incorrectly or I'm calling the wrong scripts to test. Any pointers?

So I think I have a client-side hooks that works, but I'm a bit lost on how to share it.

I'd love to make that happen someday, but I have very little time to devote to new development. It's mostly maintenance these days. Edit: Official modding support is supposedly coming in 1.4. I'm eager to see how far that will take me as far as preserving compatibility.

Thanks on both counts! I opted to use TortoiseGit since I'm on Windows, and msysgit is still building...