
StitchNChill
Members-
Posts
18 -
Joined
-
Last visited
Everything posted by StitchNChill
-
Make sure you're downloading the java JRE. Get it here https://www.oracle.com/technetwork/java/javase/downloads/jre8-downloads-2133155.html Make sure you download the correct one. For example if you're using a 64-bit computer, get the "x64" file
-
[1.14.4] addEnchantment() result only visible on reopen inventory
StitchNChill replied to OsHeaven's topic in Modder Support
Third time's the charm ? There's some older threads about it floating around. For example, googling something like "force craft synchronization server client forge" I was able to find this. I haven't read it yet, and it looks like it has to do with TileEntitys, so take that with a grain of salt - but maybe it'll help get you on the right path. -
try reinstalling the java JRE https://www.oracle.com/technetwork/java/javase/downloads/jre8-downloads-2133155.html if it asks you if you want to remove old versions of java, say Yes. Remember to get the version appropriate for your computer. (if you run a 64-bit computer, get the x64 file) if you're trying to create mods, you'll also download the java JDK https://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html
-
You can download it on the install page https://files.minecraftforge.net/ You want the MDK if you plan on making mods. You want the installer (NOT the windows installer, because you are on a Mac!) if you plan on using mods.
-
[1.14.4] addEnchantment() result only visible on reopen inventory
StitchNChill replied to OsHeaven's topic in Modder Support
Hm.. try outputting each of the values individually and see what happens. See if any of them output as false whenever you execute the method. If you need help on system.out.println, you can read up on it a little first: https://docs.oracle.com/javase/tutorial/essential/io/formatting.html float moonPhaseFactor = Dimension.MOON_PHASE_FACTORS[world.dimension.getMoonPhase(world.dimension.getWorldTime())]; System.out.println("is overworld? " + (world.getDimension().getType() == DimensionType.OVERWORLD)); System.out.println("is moonphasefactor? " + (moonPhaseFactor == 1.0f)); System.out.println("is daytime? " + world.isDaytime()); if (world.getDimension().getType() == DimensionType.OVERWORLD && moonPhaseFactor == 1.0f && world.isDaytime()) { stack.addEnchantment(Enchantments.BINDING_CURSE, 1); } -
https://www.minecraftforum.net/forums/minecraft-java-edition/discussion/2937717-minecrafts-multicore-singlecore-argument yeah, it looks like MC likes strong single-core, maybe strong 2-core, and although it "uses" multiple cores the term should be loose. In this case, 2.6GHz may not be enough to prevent the lag you guys are seeing.
-
If it's only while he's online, it's probably that his CPU is getting overtaxed, especially if you've got a lot of intense mods (as diesieben07 already pointed out). The 6700hq is 2.6GHz base, 3.5GHz turbo... it's also 4 double-cores, so possibly an issue trying to run on a single thread and not using the extra cores. I don't know, I'm not an expert on how MC runs (though I vaguely remember it being optimized for 2 cores.. if i'm wrong, feel free to correct me ) https://ark.intel.com/content/www/us/en/ark/products/88967/intel-core-i7-6700hq-processor-6m-cache-up-to-3-50-ghz.html
-
[1.14.4] addEnchantment() result only visible on reopen inventory
StitchNChill replied to OsHeaven's topic in Modder Support
Which is why I'm suggesting you add parentheses to see if it fixes the error. It could be a compiler issue within intellij. I can't help you unless you try. -
[1.14.4] addEnchantment() result only visible on reopen inventory
StitchNChill replied to OsHeaven's topic in Modder Support
This is on the moonPhaseFactor, which was originally the working method, correct? So by what your code says here , because world.isDaytime() returns FALSE, it should never get to the stack.addEnchantment(...) line: I would insert parentheses to deterministically decclare the order of operations. While your code seems to look fine, there may be something I'm not catching. Just a quick change, maybe it'll solve your issues. ((world.getDimension().getType() == DimensionType.OVERWORLD) && (moonPhaseFactor == 1.0f) && (world.isDaytime())) EDIT: there could be a compiler bug that doesn't appropriately perform the order of operations. here is how precedence should occur (https://introcs.cs.princeton.edu/java/11precedence/) but maybe your compiler doesn't want to play nice. -
[1.14.4] addEnchantment() result only visible on reopen inventory
StitchNChill replied to OsHeaven's topic in Modder Support
Correct. OP is saying that he has multiple methods in his code, and that some work as expected while others don't. I'm suggesting he takes the working method, inserts it in place of the misbehaving method, and checks the output. If the output is still incorrect even with the working method, the issue is not with the method(s), rather something else with the code. If the output is correct using the working method, the issue is indeed with the original misbehaving method. However, the 'misbehaving' method looks spot-on to me, which is why I'm making this suggestion. -
[1.14.4] addEnchantment() result only visible on reopen inventory
StitchNChill replied to OsHeaven's topic in Modder Support
Hm... if it were me, I would start by commenting out the code on the BlockPos method, and replacing it with an exact copy of the moonPhaseFactor method. That way, you can narrow it down a bit. Either 1) the error will still exist when creating the moonPhaseFactor item, in which case you know it has to do with how the method is called, or 2) the error will not exist, in which case the error is definitely with your BlockPos method, though I can't see why that would be giving you issues, as it is. Keep us updated. -
[1.14.4] addEnchantment() result only visible on reopen inventory
StitchNChill replied to OsHeaven's topic in Modder Support
What event are you using to call these methods? Is it possible that in the 2nd method, the item is being created before the event has had time to resolve, resulting in a race-condition between item creation and displaying the item's enchantments? -
Try reinstalling java (https://www.oracle.com/technetwork/java/javase/downloads/jre8-downloads-2133155.html) note: this is the JRE, used for running mods. If you want to create mods you will also need to find and download the java JDK. Make sure you are downloading the appropriate java for your system (x64 if you run a 64-bit computer). If it asks "do you want to remove older versions of java," say yes.
-
Does the Forge Documentation list all possible Events?
StitchNChill posted a topic in Modder Support
The event documentation (https://mcforge.readthedocs.io/en/1.13.x/events/intro/) does not seem to have a list of all possible events. Where is this list located? EDIT: found this question was answered previously -
Are you downloading forge to use mods, or to create mods? To build mods, you want the MDK. To use mods, you use the installer. https://files.minecraftforge.net/
-
Can I view source code without the source?
StitchNChill replied to StitchNChill's topic in General Discussion
Perfect, thanks so much -
Can I view source code without the source?
StitchNChill replied to StitchNChill's topic in General Discussion
BTW if we could only pull even just the textures, that'd be a huge plus -
Friend of mine gave me his mod distributable (client side) and we've been playing on a mod he made. His hard drive went bad and lost all data, so he lost the source code. I was wondering if there was a way using just the client side distributable that I could recreate the source from it. If so, could you link an explanation on how to? Inb4 "why no repository"