JimiIT92

Well... that's unfortunate I guess the only way then is to catch the crafting result event and modify the output

I have a new type of chiseled bookshelf made out of spruce wood, and I want to craft it like regular chiseled bookshelf but with spruce planks and slabs instead. So I've created the crafting recipe like so { "type": "minecraft:crafting_shaped", "category": "building", "key": { "#": { "item": "minecraft:spruce_planks" }, "X": { "item": "minecraft:spruce_slab" } }, "pattern": [ "###", "XXX", "###" ], "result": { "item": "mineworld:spruce_chiseled_bookshelf" }, "show_notification": true } hovewer when I try the crafting the regular chiseled bookshelf is crafted instead. Looking at the assemble method from the recipe the crafting is matching the recipe that takes the planks and slabs tags instead, thus the result. Now, I don't want to completely override the recipe, as it is bad practice. The generic recipe should still work for mod compatibility, I just want to craft anotehr item when using some more specific planks and slabs. So how can I force the game to use this more specific recipe instead? EDIT: I should point out that in the mods.toml file the Forge dependecy ordering is set to AFTER, as pointed out in another similar thread

In my mod I'm dealing with some custom chests and, for the item rendering, I came across the BlockEntityWithoutLevelRenderer to render the item model of the chest inside the inventory. Now, everything works, but I've noticed that I have to call an instance of this class in the custom chest item, like so @Override public void initializeClient(final @NotNull Consumer<IClientItemExtensions> consumer) { consumer.accept(new IClientItemExtensions() { @Override public BlockEntityWithoutLevelRenderer getCustomRenderer() { return MineWorld.getItemsRenderer(); } }); } where the MineWorld.getItemsRenderer is a method that returns a new instance of my custom BEWLR class, or an existing one if it has been already initialized. What got my attention is that if I want to add another item with a custom model I have to add this same method in that item class as well. Is this the optimal approach or there's a better, centralized one? Maybe one that would also prevent me from registering a custom item for the chest, and instead checks for the actual chest block item?

Ironically I've just did that without noticing your comment 😅 I've edited my previous answer, and again feel so dumb for not thinking about that before 😅 Closing this, thank you for the help as always

Yeah I've tried doing a custom block that extends LecternBlock and creates a custom LecternBlockEntity, but unfortunately the LecternBlockEntity hardwires the BlockEntityType.LECTERN into the constructor If I do that I can surely solve the issue, as I can link the custom block entity to the LecternRederer class using BlockEntityRenderers, is just that I'm wondering if I can avoid duplicating the class, since it would be harder to mantain in future due to changes. As for the book I've already hooked it up on the RightClickBlock event and using the static tryPlaceBook method on the block class itself, so that's not really an issue EDIT: Ok, I got it, and I feel so dumb to not thought about this earlier. Turns out that all I needed to do is to override the getType method inside the custom block entity public class MWLecternBlockEntity extends LecternBlockEntity { public MWLecternBlockEntity(final BlockPos blockPos, final BlockState blockState) { super(blockPos, blockState); } @Override public @NotNull BlockEntityType<?> getType() { return MWBlockEntityTypes.SPRUCE_LECTERN.get(); } } And inside the custom block I now instantiate this block entity instead @Override public BlockEntity newBlockEntity(BlockPos blockPos, BlockState blockState) { return new MWLecternBlockEntity(blockPos, blockState); } This way I don't need to copy the vanilla class and can hook up my custom block entity type to the vanilla render

I'm trying to create some lectern blocks, and so far the block itself works. However the rendering of the book doesn't, and by looking at the debugger it seems that the renderer class doesn't get linked to the custom block, even thou I'm not using a custom block class. So I've tried to instead create my own lectern block entity, however the LecternBlockEntity constructor doesn't allow to change the blockentitytype (is hardcoded into the constructor itself), so if I had to do this I'd have to basically clone the entire class, which is something I want to avoid. This is how I register the block public static final RegistryObject<Block> SPRUCE_LECTERN = RegisterHelper.registerBlock("spruce_lectern", () -> new LecternBlock(PropertyHelper.copyFromBlock(Blocks.LECTERN))); You can see the full implementation here to check what the helper methods does: https://github.com/JimiIT92/MineWorld/blob/master/src/main/java/org/mineworld/core/MWBlocks.java#L1183 I've also already created the block entity and the rendering like so public static final RegistryObject<BlockEntityType<LecternBlockEntity>> SPRUCE_LECTERN = RegisterHelper.registerBlockEntity("spruce_lectern", LecternBlockEntity::new, MWBlocks.SPRUCE_LECTERN); //rendering BlockEntityRenderers.register(SPRUCE_LECTERN.get(), LecternRenderer::new); You can also see this here: https://github.com/JimiIT92/MineWorld/blob/master/src/main/java/org/mineworld/core/MWBlockEntityTypes.java#L19 So how can I attach the vanilla block entity to my custom block? Or at least make so that the custom lectern block will use the custom block entity type, but without copy/pasting the entire class, if is even possible?

If you mean the CreativeModeTabEvent.Register event, to register your own tab, you need to create a listener on the mod bus @Mod.EventBusSubscriber(modid = "your_mod_id", bus = Mod.EventBusSubscriber.Bus.MOD) public class CreativeTabEvents { @SubscribeEvent public static void onRegisterCreativeTabs(final CreativeModeTabEvent.Register event) { event.registerCreativeModeTab(new ResourceLocation("your_mod_id", "tab_name"), builder -> builder .icon(() -> new ItemStack(MyModItems.MyItem)) .title(Component.translatable("itemGroup." + "your_mod_id" + "." + name)) //you are not forced to this syntax, but it's pretty common .build()); } } Assuming that MyModItems.MyItem is an item in a class of your mod that has all the items (of course you can set it to whatever item or block you want, even vanilla ones). If, instead, you want to add items to your creative tab, you need to listen to the CreativeModeTabEvent.BuildContents event, in a similar way. In here you want to check which tab is being populated (event.getTab()) and, if is your tab, add as many item stacks as you want using event.acceptAll(itemStacks) method @SubscribeEvent public static void onTabBuildContents(final CreativeModeTabEvent.BuildContents event) { final CreativeModeTab tab = event.getTab(); if(tab.equals(MY_CREATIVE_TAB)) { event.acceptAll(List.of( new ItemStack(MyModItems.MyItem), new ItemStack(MyModItems.MySecondItem) ... )); } } Of course you need to have reference to your tab, so when you register it during the CreativeModeTabEvent.Register event make sure to store the registered tab into a variable so you can use it later on to add items to it. You can see how I handle my tabs here to get an idea: https://github.com/JimiIT92/MineWorld/blob/master/src/main/java/org/mineworld/core/MWTabs.java

Understood, so I guess it's fine till it works. 😅 Of course if it was a custom block in the first place there wasn't even the need for the event

In my mod I'm making so that if the player tries to place some glass panes while sneaking it will be placed another block (a horizontal glass pane). To do so I'm listening to the block place game event and so far everything works. However for a split fraction you can see the vanilla glass pane before it gets replaced by the mod block. Is there any way to prevent this and instead just straight forward place the mod block without placing the vanilla block and then the modded one? You can see how I replace the block here: https://github.com/JimiIT92/MineWorld/blob/master/src/main/java/org/mineworld/event/GameEventListener.java#L40 By the way I've also tried listening to the BlockEvent.EntityPlaceEvent, cancelling and then set my own block, but that didn't worked at all (and not cancelling the event would produce the same result where you can see the placed block before is replaced)

I think I figured out what the problem is: the leash knot entity type has the noSave() attribute set public static final EntityType<LeashFenceKnotEntity> LEASH_KNOT = register("leash_knot", EntityType.Builder.<LeashFenceKnotEntity>of(LeashFenceKnotEntity::new, MobCategory.MISC).noSave().sized(0.375F, 0.5F).clientTrackingRange(10).updateInterval(Integer.MAX_VALUE)); What I've tried is to create a custom entity that extends the LeashFenceKnotEntity class and when registering it I removed the noSave attribute, and sure enough it worked: the leash stayed through world reloads. But that raises another question: can I remove this attribute from the vanilla entity? Since having to create a custom entity imply that I have to replace all vanilla leash knots with custom ones when they are added (which is not optimal I guess)

That was the first method I've looked into, but doesn't seem to be called on world reload. Also the leash knot entity overrides the base method by simply checking the block is "knotted" to is a fence block, which in this case it is

First thing first: don't be rude to others just because they just told you a basic simple rule, that is even written in the top section of every page: **1.12, and every version prior to 1.18, is no longer supported**. That means that is very unlikely that some would come to help, simply because the version is too old and many things has changed, so to give a correct answer someone should remember how things works in 1.12.2, which is something typically none would do. Second: use the appropriate formatting tools when writing posts. Third: if you really want to get some help you need to provide more context/source to your answer. And for the code part use something like GitHub so it's way easier to look at your code and identify the actual problem. You've also mentioned a video, so it would also be helpful to link the video you mentioned to see if it is even correct in the first place. All that being said, you should have an error in the debugger console pointing out why your block isn't loading (maybe there's an error in some of the files? The mod id is wrong?). Post that error (using the spoiler tag) so we can actually see what the error is (I'm not going to setup a 1.12.2 dev env just for this...)

I want to make the player be able to attach a leash to a fence without a mob leashed to it. So essentially have a fence persisting like this However when I realod the world the leash knot is gone, and I don't understand why (I know it's a vanilla feature, but even looking at the entity code I can't find out why it breaks so I can override it). What I've tried so far is to intercept the EntityLeaveLevelEvent, but that seems to not be firing when reloading the world and removing the entity. So what is actually been fired when the lead disappear, so I can prevent it? Where should I look into?

The only place I can think of is the Forge discord (or any other modding discord servers). But beside Forge and Kaupenjoe I don't know other Forge discord servers

1.8.9 is no longer supported as it is really really old https://forums.minecraftforge.net/topic/91712-supported-version-directory/ That being said, unfortunately I don't know how to help in this case, but since this version is unsupported I don't know if some will eventually come (hopefully it will, but it's unlikely)

I was already thinking about duping the model, also since the ItemBlockRenderTypes#setRenderLayer is marked as deprecated. Was wondering if there was a way to don't dupe the model. Thank you anyway

I'm making some stained glass slabs, and by doing so, in the blockstates file, I reference the minecraft full block model for the double slab variant { "variants": { "type=bottom": { "model": "mineworld:block/pink_stained_glass_slab" }, "type=double": { "model": "minecraft:block/pink_stained_glass" }, "type=top": { "model": "mineworld:block/pink_stained_glass_slab_top" } } } however the double slab renders as a solid cube in game (while the bottom and top slabs renders correctly since I added the render_type: translucent inside the model JSON file For reference this is how I create the slab block (nothing too crazy) new SlabBlock(BlockBehaviour.Properties.copy(Blocks.PINK_STAINED_GLASS)).requiresCorrectToolForDrops()) You can also see the full source here: https://github.com/JimiIT92/MineWorld/blob/master/src/main/java/org/mineworld/core/MWBlocks.java#L1039 So what am I missing here that causes this incorrect rendering?

I got this when trying to launch my mod in IntelliJ. Looks like the gradle plugin has temporarly (I hope) gone org.gradle.api.plugins.UnknownPluginException: Plugin [id: 'net.minecraftforge.gradle', version: '5.1.+'] was not found EDIT: From the Forge discord Our maven server (https://maven.minecraftforge.net/) which hosts all project files and downloads, is currently experiencing a fault leading to a Gateway Timeout. We are aware of the issue, and are currently working to fix it. Please stand by. In the meantime, you can enable Gradle Offline mode (https://www.baeldung.com/gradle-offline-mode) to use artifacts cached without hitting the maven. These messages were sent around 2 hours ago, so I guess we'll just wait or work in offline mode if you really need

That was exactly what I was looking into, but can't seem to make it work properly at all. Even trying to register a Feature Flag using a different "universe" than main completely brokes the game. So yeah, I guess config file is the way to go

Really? I was reading about a limit of 64... I think is a really missed opportunity, but can't complain too much. I guess the closest I can get is to have a config setting and then disable the crafting recipes or the use of blocks/items based on that config

I'm wondering if it is possible (or is planned for 1.20) for a mod to create their own custom feature flags. I know that config files are a thing and should probably be used, but it would also be cool if you can have some features of your mod under a feature flag, allowing the player to choose which ones to have inside a world (just like vanilla feature flags). I've tried using the vanilla implementation public static final FeatureFlag MY_FEATURE_FLAG = new FeatureFlagRegistry.Builder("main").create(new ResourceLocation("modid", "my_feature_flag")); and providing the feature flag to the block properties inside the requiredFeatures method, but unfortunately the game crashes as soon as it loads up with the following error Exception caught during firing event: Mismatched feature universe, expected 'main', but got 'main' Full crash report here: https://pastebin.com/1NtaAeeM And you can see where I create a Feature Flag here: https://github.com/JimiIT92/MineWorld/blob/master/src/main/java/org/mineworld/core/MWFeatureFlags.java So I don't know if I'm actually doing something wrong or is just something that is currently impossible to do

Understand, well I guess is fine then to do my own custom weathering interface and replicate the blocks as I need. May I ask why the PR went stale? Was it discarded by Forge or it required more work and eventually got forgotten?

I'm trying to make some copper block variants and I want them to act like regular blocks, so over time they oxidize, they can be waxed with honeycomb and can be scraped with an axe. Now, doing the blocks and making them work this way isn't really a problem (you can see a WIP implementation here: https://github.com/JimiIT92/MineWorld/blob/master/src/main/java/org/mineworld/block/IMWWeatheringBlock.java), however as you might guess I've duplicated the WeatheringCopper interface from vanilla Minecraft and added my own logic to make it work with my custom block. That's because what I've originally tried is to add values to the NEXT_BY_BLOCK map inside the FMLCommonSetupEvent, however that is an Immutable Map, and as such I can't add values to it (I get an UnsupportedOperationException if I try to do that). In a similar way I've also tried to add the waxed variants to the HoneycombItem#WAXABLES map, but again that is immutable. So, is there a way to actually modify these maps so you don't have to rewrite the same logic?

In Blocks.java you can see that the Iron door has the requireCorrectToolForDrops() property set public static final Block IRON_DOOR = register("iron_door", new DoorBlock(BlockBehaviour.Properties.of(Material.METAL, MaterialColor.METAL).requiresCorrectToolForDrops().strength(5.0F).noOcclusion(), BlockSetType.IRON)); By the way I've also tried to manually set the property myself, so doing like this BlockBehaviour.Properties.copy(Blocks.IRON_DOOR).requiresCorrectToolForDrops() but doesn't work as well. The only difference is that vanilla doors doesn't have a tier set, but that doesn't explain why if you add them or a block with the same properties under that requirement it gets ignored

What do you mean about bushes generation? You can always look at vanilla files to see how they works, one thing that comes to my mind when talking about bushes is regarding the jungle patches of leaves that you can find in jungle biomes. You can look at the files for these and copy/edit them to suit your needs