Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.16.5] Giving potion effect based on the light level of the block player is standing on


Sinu
 Share

Recommended Posts

Posted (edited)

I am trying to give a blinding effect to players who are in light level of 0 but I can't seem to get it to work.

@SubscribeEvent
    public static void onPlayerTick(TickEvent.PlayerTickEvent event)
    {
		PlayerEntity player = event.player;
		World world = event.player.level;
		BlockPos blockpos = player.blockPosition();
		BlockState block = world.getBlockState(blockpos);
		
		if (block.getLightValue(world, blockpos) == 0 && block != null)
		{
			((LivingEntity)event.player).addEffect(new EffectInstance(Effects.BLINDNESS, 20, 3));
		}
    }

Am I using getLightValue correctly? Also I am correctly feeding in the correct block position?

Edited by Sinu
Link to comment
Share on other sites

I see. What is the second int parameter in World#getRawBrightness for? I looked at the reference and it just seems to subtract it? Not sure why..
Also I believe I tried using World#getBrightness with LightType.BLOCK but I don't think it detected the light level properly. I am trying to give the Blindness effect to players who walk into caves with light levels of 0.

Link to comment
Share on other sites

6 minutes ago, Sinu said:

I see. What is the second int parameter in World#getRawBrightness for? I looked at the reference and it just seems to subtract it? Not sure why..

It's subtracted from the sky light only, not the block light. It is used for mob spawning rules (sky light gets 10 units subtracted during thundering, block light doesn't).

7 minutes ago, Sinu said:

Also I believe I tried using World#getBrightness with LightType.BLOCK but I don't think it detected the light level properly. I am trying to give the Blindness effect to players who walk into caves with light levels of 0.

Block light is 0 almost everywhere, except when you place light emitting blocks like torches. You probably want getRawBrightness instead (or actually getMaxLocalRawBrightness, which checks that the position is correct first).

Link to comment
Share on other sites

Sweet, that seems to have worked!
The one issue is that, I had to check if the instance was client or server because for some reason the server kept thinking the light level of the player is always 0 (is it client-side only?). So my code looks like this now:

PlayerEntity player = event.player;
		World world = event.player.level;
		BlockPos blockpos = player.blockPosition();
		BlockState block = world.getBlockState(blockpos);
		
		if (world.isClientSide)
		{
			System.out.print(world.getMaxLocalRawBrightness(blockpos) + System.lineSeparator());
			if (world.getMaxLocalRawBrightness(blockpos) == 0)
			{
				((LivingEntity)event.player).addEffect(new EffectInstance(Effects.BLINDNESS, 20, 3));	
			}
		}

But now once I walk out of the light level of 0, it still says that I have the Blindness effect even though I can see clearly. I am assuming that since I checked if the instance is client-side or not, it didn't actually give the potion effect according to the server (which makes sense) but I don't understand why Blindness goes away even after I walk into the light?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • What you posted looks like the latest.log, not debug.log. It also does not show any error, but a successful join of a single player world. Please answer this question.
    • [29Nov2021 13:35:13.629] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher running: args [--username, Alsefri1423, --version, 1.17.1-forge-37.0.126, --gameDir, C:\Users\Gaming\AppData\Roaming\.minecraft, --assetsDir, C:\Users\Gaming\AppData\Roaming\.minecraft\assets, --assetIndex, 1.17, --uuid, a889dee5cd184fe7b91ede11d2acd85f, --accessToken, ????????, --userType, msa, --versionType, release, --launchTarget, forgeclient, --fml.forgeVersion, 37.0.126, --fml.mcVersion, 1.17.1, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20210706.113038] [29Nov2021 13:35:13.633] [main/INFO] [cpw.mods.modlauncher.Launcher/MODLAUNCHER]: ModLauncher 9.0.7+91+master.8569cdf starting: java version 16.0.1 by Microsoft [29Nov2021 13:35:13.746] [main/INFO] [mixin/]: SpongePowered MIXIN Subsystem Version=0.8.4 Source=union:/C:/Users/Gaming/AppData/Roaming/.minecraft/libraries/org/spongepowered/mixin/0.8.4/mixin-0.8.4.jar%2318! Service=ModLauncher Env=CLIENT [29Nov2021 13:35:15.296] [main/INFO] [cpw.mods.modlauncher.LaunchServiceHandler/MODLAUNCHER]: Launching target 'forgeclient' with arguments [--version, 1.17.1-forge-37.0.126, --gameDir, C:\Users\Gaming\AppData\Roaming\.minecraft, --assetsDir, C:\Users\Gaming\AppData\Roaming\.minecraft\assets, --uuid, a889dee5cd184fe7b91ede11d2acd85f, --username, Alsefri1423, --assetIndex, 1.17, --accessToken, ????????, --userType, msa, --versionType, release] [13:35:21] [Render thread/WARN]: Assets URL 'union:/C:/Users/Gaming/AppData/Roaming/.minecraft/libraries/net/minecraft/client/1.17.1-20210706.113038/client-1.17.1-20210706.113038-srg.jar%2353!/assets/.mcassetsroot' uses unexpected schema [13:35:21] [Render thread/WARN]: Assets URL 'union:/C:/Users/Gaming/AppData/Roaming/.minecraft/libraries/net/minecraft/client/1.17.1-20210706.113038/client-1.17.1-20210706.113038-srg.jar%2353!/data/.mcassetsroot' uses unexpected schema [29Nov2021 13:35:21.370] [Render thread/INFO] [com.mojang.authlib.yggdrasil.YggdrasilAuthenticationService/]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD' [13:35:22] [Render thread/INFO]: Setting user: Alsefri1423 [13:35:22] [Render thread/INFO]: Backend library: LWJGL version 3.2.2 SNAPSHOT [13:35:24] [modloading-worker-2/INFO]: Forge mod loading, version 37.0.126, for MC 1.17.1 with MCP 20210706.113038 [13:35:24] [modloading-worker-2/INFO]: MinecraftForge v37.0.126 Initialized [13:35:24] [Render thread/WARN]: Removed resource pack Fabric Mods from options because it doesn't seem to exist anymore [29Nov2021 13:35:26.011] [Render thread/INFO] [com.mojang.text2speech.NarratorWindows/]: Narrator library for x64 successfully loaded [13:35:26] [Render thread/INFO]: Reloading ResourceManager: Default, Mod Resources [13:35:26] [modloading-worker-2/WARN]: Configuration file C:\Users\Gaming\AppData\Roaming\.minecraft\config\forge-client.toml is not correct. Correcting [13:35:26] [modloading-worker-2/WARN]: Incorrect key client.forceSystemNanoTime was corrected from null to its default, false.  [13:35:26] [modloading-worker-2/WARN]: Incorrect key client.disableStairSlabCulling was corrected from false to its default, null.  [13:35:26] [modloading-worker-2/WARN]: Incorrect key client.zoomInMissingModelTextInGui was corrected from false to its default, null.  [13:35:26] [modloading-worker-2/WARN]: Incorrect key client.forgeLightPipelineEnabled was corrected from true to its default, null.  [13:35:26] [modloading-worker-2/WARN]: Incorrect key client.forgeCloudsEnabled was corrected from true to its default, null.  [29Nov2021 13:35:26.669] [Forge Version Check/INFO] [net.minecraftforge.fml.VersionChecker/]: [forge] Starting version check at https://files.minecraftforge.net/net/minecraftforge/forge/promotions_slim.json [13:35:38] [Render thread/INFO]: OpenAL initialized. [13:35:38] [Render thread/INFO]: Sound engine started [13:35:38] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas [13:35:38] [Render thread/INFO]: Created: 256x128x4 minecraft:textures/atlas/signs.png-atlas [13:35:38] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas [13:35:38] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas [13:35:38] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas [13:35:38] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas [13:35:38] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas [29Nov2021 13:35:38.817] [Forge Version Check/INFO] [net.minecraftforge.fml.VersionChecker/]: [forge] Found status: BETA Current: 37.0.126 Target: 37.0.126 [13:35:40] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/particles.png-atlas [13:35:40] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas [13:35:40] [Render thread/INFO]: Created: 128x128x0 minecraft:textures/atlas/mob_effects.png-atlas [13:35:51] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0] [13:35:51] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0] [13:35:51] [Render thread/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498] [13:35:51] [Render thread/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498] [13:35:51] [Render thread/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0] [13:35:51] [Render thread/INFO]: Reloading ResourceManager: Default, forge-1.17.1-37.0.126-universal.jar [13:35:54] [Render thread/INFO]: Loaded 7 recipes [13:35:55] [Render thread/INFO]: Loaded 1137 advancements [13:35:55] [Render thread/INFO]: Injecting existing registry data into this CLIENT instance [13:35:56] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0] [13:35:56] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0] [13:35:56] [Render thread/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498] [13:35:56] [Render thread/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498] [13:35:56] [Render thread/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0] [13:35:56] [Render thread/INFO]: Reloading ResourceManager: Default, forge-1.17.1-37.0.126-universal.jar [13:35:58] [Render thread/INFO]: Loaded 7 recipes [13:35:59] [Render thread/INFO]: Loaded 1137 advancements [13:36:00] [Render thread/INFO]: Injecting existing registry data into this CLIENT instance [29Nov2021 13:36:00.780] [Render thread/INFO] [com.mojang.authlib.yggdrasil.YggdrasilAuthenticationService/]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD' [13:36:00] [Server thread/INFO]: Starting integrated minecraft server version 1.17.1 [13:36:00] [Server thread/INFO]: Generating keypair [13:36:01] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld [13:36:01] [Render thread/INFO]: Preparing spawn area: 0% [13:36:05] [Render thread/INFO]: Preparing spawn area: 0% [13:36:05] [Render thread/INFO]: Preparing spawn area: 0% [13:36:05] [Render thread/INFO]: Preparing spawn area: 0% [13:36:05] [Render thread/INFO]: Preparing spawn area: 0% [13:36:05] [Render thread/INFO]: Preparing spawn area: 0% [13:36:05] [Render thread/INFO]: Preparing spawn area: 0% [13:36:05] [Render thread/INFO]: Preparing spawn area: 0% [13:36:05] [Render thread/INFO]: Preparing spawn area: 0% [13:36:06] [Render thread/INFO]: Preparing spawn area: 56% [13:36:06] [Render thread/INFO]: Preparing spawn area: 76% [13:36:06] [Render thread/INFO]: Preparing spawn area: 88% [13:36:06] [Render thread/INFO]: Time elapsed: 5638 ms [13:36:06] [Server thread/INFO]: Changing view distance to 31, from 10 [13:36:08] [Netty Local Client IO #0/INFO]: Connected to a modded server. [13:36:08] [Server thread/INFO]: Using new advancement loading for net.minecraft.server.PlayerAdvancements@334a2b19 [13:36:08] [Server thread/INFO]: Alsefri1423[local:E:9ebcee60] logged in with entity id 113 at (-1414.803438468965, 64.0, 25.132433578510874) [13:36:08] [Server thread/INFO]: Alsefri1423 joined the game [13:36:09] [Server thread/INFO]: Saving and pausing game... [13:36:09] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld [13:36:09] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether [13:36:09] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end [13:36:09] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 2136ms or 42 ticks behind [13:36:10] [Render thread/INFO]: Loaded 174 advancements   My OS is Windows 10
    • Hello, I know I've been quite active here lately and I promise I'll get out of your hair once i can work out this final thing. Essentially I'm looking for a way to get the player's Position on a specific axis and use its value in an if statement. I've experimented with classes vec3 and vec3i as the method getY() seemed promising, but i didn't know how to use it with the player and I had issues with the method being non-static. Any help would be appreciated. 
    • This is why the MDK comes with a properly configured .gitignore file. Did you run genEclipseRuns? I don't use Eclipse, but your Repository works fine in IntelliJ.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.