Search the Forums BEFORE making a new post.

[1.16.5] How to determine the location of a PlaySoundAtEntityEvent?

Posted December 29, 20213 yr

I've been working on adding hearing target selection logic to zombies. I see that ServerWorld#playSound fires a forge PlaySoundAtEntityEvent, but this event doesn't necessarily contain a location.

The PlayerEntity passed into ServerWorld#playSound as the first parameter can be (and, in fact, usually is) null because some sounds are not created by a player. The only data encapsulated by PlaySoundAtEntityEvent are the (nullable) PlayerEntity that is the sound source, the MC SoundEvent, the SoundCategory, and two floats corresponding to volume and pitch. This means that when a sound event is not player-generated, it is not possible to determine the sound location.

Is there a workaround for this? I'm currently using a mixin to inject code into ServerWorld#playSound but modifying bytecode just to intercept sound events feels kinda hacky.

Quote

December 30, 20213 yr

Author

For anyone else that finds this thread, I submitted a PR request and the discussion has moved there: https://github.com/MinecraftForge/MinecraftForge/pull/8334

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/107117-1165-how-to-determine-the-location-of-a-playsoundatentityevent/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

[SOLVED] Guys, please help me get through this horrible NoClassDefFound exception.

Well, needing help for this didn't last nearly as long as I expected, lol. I figured out the solution, and it's a real face palmer. Basically, the function Type.getInternalName(Class<?> clazz) does NOT work for classes that are obfuscated. This means that it won't work for basically every minecraft class. So running it with the argument EntityTrackerEntry.class won't work, but running it with CustomHandler.class will work! Annoying, but a still bit interesting. So I just replaced my call for Type.getInternalName(EntityTrackerEntry.class) with just "os", as that is the name of the actual class for EntityTrackerEntry at runtime. Hope this solution helps somebody. In the meantime, I'm going to mark this thread as solved.

By Jackson Perr · Monday at 09:57 PM1 day
[1.20.1] Custom Effect Help

Can you send the code pertaining to your custom mod effect? I don't see anything wrong with how you "assemble" the food properties, btw.

By Jackson Perr · Monday at 07:56 PM1 day
(IntelliJ) Gradle doesn't import enums from net.minecraft.core properly

crazy

By Jonathing · Monday at 07:50 PM1 day
(IntelliJ) Gradle doesn't import enums from net.minecraft.core properly

For anyone who is running into this issue in the future: The fix for me was updating Intellij. I was using the 2022 version, which apparently had some issues with Java 21 (particularly around enums, which Direction is one).

By CravenCraft · Monday at 07:40 PM1 day
How do you add a mob to spawn around a existing vanilla structure?

Hey dawg!

I think I might be able to help you out with your issue here. I say might because I don't know about 1.16.x or any later version, but I know how to do this kind of thing for 1.12.2 forge. Basically, in the pre-init or init (I don't really remember which one) you just gotta'

Okay, ykw, I just downloaded the 1.14.4 1.20.1 minecraft mdk. I think I actually can help you here. So, the 1.12.2 method actually doesn't work with 1.20.1 minecraft or later. Probably not too far before either. I see two options here for ya':

First, it's important to note that the game stores its spawn data for structures in, well, the Structures class. Here, the game initializes an instance of each Structure class and registers them with the BootstrapContext using its bootstrap function. Each instance of a Structure class is registered with a StructureSettings class as an argument. One of the arguments, the one that you're probably going to be particularly interested in here, would be the spawnOverrides argument. For this argument, the game uses a Map between MOB_CATEGORIES and StructureSpawnOverride. StructureSpawnOverride is essentially the juice of it here. It contains almost everything you would need to control how your custom mob spawns in Pillager Outposts. Now, if you want to change how the Structure class for the pillager outposts is registered with the BootstrapContext in the bootstrap function, you're going to want to change where the function's caller gets the function and replace it with your own custom version of this function. How might you do this? This is where it gets a little tricky. The bootstrap function for the structures class is referenced in VanillaRegistries.BUILDER. However, unfortunately, this field is private and final, so you can't directly change it with reflections, but you can still access it with reflections. Now the VanillaRegistries.BUILDER field is of the type RegistrySetBuilder, which uses a private final field "entires", which is set as a List<RegistrySetBuilder.RegistryStub<?>> type. So here, you could use reflections to access this list field and remove the entry for the structures bootstrap. Then you might be able to create your own structures class and add change the bootstrap function to reflect the changes you wish. Then finally, simply re-add the Structure entry that you made to the list, and you should be completely done! Keep in mind, I haven't actually tested this, so I'm not sure if it would actually work, and even if it did work it's really unorthodox, so I would recommend trying this next idea.

When the game is deciding whether or not to spawn an entity, if the entity is registered with the SpawnPlacements class, is uses the function you specify in the entity class to determine whether or not the entity can spawn in a certain spot. For example, the guardian cannot spawn on a block that is exposed to light from underwater because of this function. So what you could do is make a checkSelfSpawnRules function for your mob and register it with the SpawnPlacements function. Then, you could have your checkSelfSpawnRules function take into account if the block it's trying to spawn on is near a Pillager Outpost. Finally, you can get the coordinates to the chunk of your block and iterate through the ServerLevels in your MinecraftServer class and get their chunk sources and test if the chunk source has the chunk of your block position. If it does, you can then get the StructureManager from the ServerLevel. In there should be some very helpful functions for you to use. Although this is a bit more orthodox, it might be a bit laggy.

It's really up to you which of these options you choose. If you need some additional clarification then please let me know, I would be happy to help you out! Also let me know if any of these options hit your goals for what your looking for here or not. If not then just let me know; I could probably find another method you could try.

By Jackson Perr · Monday at 06:27 PM1 day

Ugdhar

Sign In

[1.16.5] How to determine the location of a PlaySoundAtEntityEvent?

Featured Replies

Join the conversation

Posts

[SOLVED] Guys, please help me get through this horrible NoClassDefFound exception.

[1.20.1] Custom Effect Help

(IntelliJ) Gradle doesn't import enums from net.minecraft.core properly

(IntelliJ) Gradle doesn't import enums from net.minecraft.core properly

How do you add a mob to spawn around a existing vanilla structure?

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)