Jump to content

Recommended Posts

Posted (edited)

I have a stationary plant mob that shoots projectiles at distant targets and lashes out at nearby ones. And it works pretty well.

However, art of the model is grass that's supposed to look like part of the environment, so it's not just a vine coming out of the solid ground.

I want that grass part to have NO rotation whatsoever, as if it's an actual grass block on the terrain. But for some reason it still wants to rotate with the rest of the mob.

Can someone tell me what I'm doing wrong?

Model class:

Spoiler
public class ModelDekuBaba extends EntityModel<EntityDekuBaba>
{	
  // I don't know why these are named so weirdly - blame BlockBench
	private final ModelRenderer vine;
	private final ModelRenderer thorn3_r1;
	private final ModelRenderer thorn2_r1;
	private final ModelRenderer thorn1_r1;
	private final ModelRenderer vine4_r1;
	private final ModelRenderer vine3_r1;
	private final ModelRenderer vine2_r1;
  
	private final ModelRenderer head;
	private final ModelRenderer tongue3_r1;
	private final ModelRenderer tongue2_r1;
	private final ModelRenderer tongue1_r1;
	private final ModelRenderer lowerteeth_r1;
	private final ModelRenderer neckjoint_r1;
	private final ModelRenderer upperteeth_r1;
	private final ModelRenderer upperjaw3_r1;
  
  // This is what I don't want to rotate, ever
	private final ModelRenderer grass;
	private final ModelRenderer grass2_r1;
	private final ModelRenderer grass1_r1;

	public ModelDekuBaba()
	{
		texWidth = 128;
		texHeight = 128;

		vine = new ModelRenderer(this);
		vine.setPos(0.0F, 24.0F, 0.0F);
		vine.texOffs(28, 22).addBox(-1.0F, -5.0F, -1.0F, 2.0F, 7.0F, 2.0F, 0.0F, false);

		thorn3_r1 = new ModelRenderer(this);
		thorn3_r1.setPos(0.0F, -20.0F, 2.5F);
		vine.addChild(thorn3_r1);
		setRotationAngle(thorn3_r1, 0.5236F, 0.0F, 0.0F);
		thorn3_r1.texOffs(33, 15).addBox(-0.5F, -1.0F, -0.5F, 1.0F, 1.0F, 3.0F, 0.0F, false);

		thorn2_r1 = new ModelRenderer(this);
		thorn2_r1.setPos(0.0F, -14.0F, 4.5F);
		vine.addChild(thorn2_r1);
		setRotationAngle(thorn2_r1, 0.0F, 0.0F, -0.2618F);
		thorn2_r1.texOffs(0, 29).addBox(0.5F, -1.0F, -1.0F, 2.0F, 1.0F, 1.0F, 0.0F, false);

		thorn1_r1 = new ModelRenderer(this);
		thorn1_r1.setPos(0.0F, -6.5F, 1.5F);
		vine.addChild(thorn1_r1);
		setRotationAngle(thorn1_r1, 0.0F, 0.0F, 0.2618F);
		thorn1_r1.texOffs(37, 0).addBox(-2.0F, -0.5F, -0.5F, 2.0F, 1.0F, 1.0F, 0.0F, false);

		vine4_r1 = new ModelRenderer(this);
		vine4_r1.setPos(0.0F, -19.5F, 2.0F);
		vine.addChild(vine4_r1);
		setRotationAngle(vine4_r1, 1.0036F, 0.0F, 0.0F);
		vine4_r1.texOffs(19, 22).addBox(-1.25F, -6.0866F, -0.5922F, 2.0F, 7.0F, 2.0F, 0.0F, false);

		vine3_r1 = new ModelRenderer(this);
		vine3_r1.setPos(0.5F, -13.5F, 3.75F);
		vine.addChild(vine3_r1);
		setRotationAngle(vine3_r1, 0.3054F, 0.0F, 0.0F);
		vine3_r1.texOffs(0, 0).addBox(-1.5F, -6.0866F, -0.3422F, 2.0F, 8.0F, 2.0F, 0.0F, false);

		vine2_r1 = new ModelRenderer(this);
		vine2_r1.setPos(0.0F, -3.0F, 0.0F);
		vine.addChild(vine2_r1);
		setRotationAngle(vine2_r1, -0.6109F, 0.0F, 0.0F);
		vine2_r1.texOffs(19, 57).addBox(-0.75F, -11.0F, -2.25F, 2.0F, 10.0F, 2.0F, 0.0F, false);

		head = new ModelRenderer(this);
		head.setPos(0.0F, -22.5F, -2.0F);
		vine.addChild(head);
		setRotationAngle(head, 0.3491F, 0.0F, 0.0F);

		tongue3_r1 = new ModelRenderer(this);
		tongue3_r1.setPos(0.0F, 0.0F, 0.0F);
		head.addChild(tongue3_r1);
		setRotationAngle(tongue3_r1, 1.0908F, 0.0F, 0.0F);
		tongue3_r1.texOffs(8, 26).addBox(-0.5F, -9.0F, -6.25F, 1.0F, 1.0F, 3.0F, 0.0F, false);

		tongue2_r1 = new ModelRenderer(this);
		tongue2_r1.setPos(0.0F, 0.0F, 0.0F);
		head.addChild(tongue2_r1);
		setRotationAngle(tongue2_r1, 0.3927F, 0.0F, 0.0F);
		tongue2_r1.texOffs(0, 24).addBox(-1.0F, -4.75F, -8.25F, 2.0F, 1.0F, 3.0F, 0.0F, false);

		tongue1_r1 = new ModelRenderer(this);
		tongue1_r1.setPos(0.0F, 0.0F, 0.0F);
		head.addChild(tongue1_r1);
		setRotationAngle(tongue1_r1, -0.1309F, 0.0F, 0.0F);
		tongue1_r1.texOffs(51, 56).addBox(-1.5F, -1.5F, -7.0F, 3.0F, 1.0F, 6.0F, 0.0F, false);

		lowerteeth_r1 = new ModelRenderer(this);
		lowerteeth_r1.setPos(0.0F, 0.0F, 0.0F);
		head.addChild(lowerteeth_r1);
		setRotationAngle(lowerteeth_r1, 0.0873F, 0.0F, 0.0F);
		lowerteeth_r1.texOffs(48, 47).addBox(-2.5F, -2.0F, -7.5F, 5.0F, 1.0F, 7.0F, 0.0F, false);
		lowerteeth_r1.texOffs(19, 15).addBox(-2.0F, 1.0F, -6.0F, 4.0F, 1.0F, 5.0F, 0.0F, false);
		lowerteeth_r1.texOffs(38, 29).addBox(-3.0F, -1.0F, -8.0F, 6.0F, 2.0F, 8.0F, 0.0F, false);

		neckjoint_r1 = new ModelRenderer(this);
		neckjoint_r1.setPos(0.0F, 0.0F, 0.0F);
		head.addChild(neckjoint_r1);
		setRotationAngle(neckjoint_r1, -0.3054F, 0.0F, 0.0F);
		neckjoint_r1.texOffs(0, 15).addBox(-2.0F, -2.5F, -3.0F, 4.0F, 4.0F, 4.0F, 0.0F, false);

		upperteeth_r1 = new ModelRenderer(this);
		upperteeth_r1.setPos(0.0F, 0.0F, 0.0F);
		head.addChild(upperteeth_r1);
		setRotationAngle(upperteeth_r1, -0.6545F, 0.0F, 0.0F);
		upperteeth_r1.texOffs(0, 40).addBox(-2.5F, -2.5F, -9.5F, 5.0F, 3.0F, 8.0F, 0.0F, false);
		upperteeth_r1.texOffs(56, 40).addBox(-2.0F, -5.5F, -8.0F, 4.0F, 1.0F, 5.0F, 0.0F, false);
		upperteeth_r1.texOffs(19, 47).addBox(-3.0F, -4.5F, -9.0F, 6.0F, 1.0F, 8.0F, 0.0F, false);
		upperteeth_r1.texOffs(38, 15).addBox(-3.0F, -3.5F, -10.0F, 6.0F, 3.0F, 10.0F, 0.0F, false);

		upperjaw3_r1 = new ModelRenderer(this);
		upperjaw3_r1.setPos(0.0F, 0.0F, 0.0F);
		head.addChild(upperjaw3_r1);
		setRotationAngle(upperjaw3_r1, -0.829F, 0.0F, 0.0F);
		upperjaw3_r1.texOffs(0, 52).addBox(-4.0F, -2.0F, -8.5F, 1.0F, 3.0F, 8.0F, 0.0F, false);
		upperjaw3_r1.texOffs(40, 56).addBox(3.0F, -2.0F, -8.5F, 1.0F, 3.0F, 8.0F, 0.0F, false);

		grass = new ModelRenderer(this);
		grass.setPos(0.0F, 24.0F, 0.0F);
		grass.texOffs(0, 0).addBox(-6.0F, -1.0F, -6.0F, 12.0F, 2.0F, 12.0F, 0.0F, false);
		grass.texOffs(37, 0).addBox(-4.0F, -2.0F, -4.0F, 8.0F, 1.0F, 8.0F, 0.0F, false);

		grass2_r1 = new ModelRenderer(this);
		grass2_r1.setPos(0.0F, 0.0F, 0.0F);
		grass.addChild(grass2_r1);
		setRotationAngle(grass2_r1, 0.0F, -2.3562F, 0.0F);
		grass2_r1.texOffs(0, 15).addBox(0.0F, -5.0F, -9.0F, 0.0F, 6.0F, 18.0F, 0.0F, false);

		grass1_r1 = new ModelRenderer(this);
		grass1_r1.setPos(0.0F, 0.0F, 0.0F);
		grass.addChild(grass1_r1);
		setRotationAngle(grass1_r1, 0.0F, -0.7854F, 0.0F);
		grass1_r1.texOffs(19, 22).addBox(0.0F, -5.0F, -9.0F, 0.0F, 6.0F, 18.0F, 0.0F, false);
	}

	@Override
	public void setupAnim(EntityDekuBaba entity, float limbSwing, float limbSwingAmount, float ageInTicks, float netHeadYaw, float headPitch)
	{
      // Spinning melee attack
		if (attackTime > 0) 
		{
			vine.yRot += 6;
			vine.xRot += 0.05f;
		}
      // Move vine and head, with slight 'breathing' animation if not attacking
		else
		{
			float vineoffset = Math.abs(entity.breathingticks) * 0.001f;

			vine.yRot = 0;
			vine.xRot = vineoffset;
			vine.zRot = vineoffset / 2;

			head.yRot = headPitch * ((float) Math.PI / 180F);
			head.xRot = headPitch * ((float) Math.PI / 180F) + vineoffset;
		}

      // This I assumed would stop the grass from rotating, but apparently it doesn't.
		grass.xRot = 0;
		grass.yRot = 0;
		grass.zRot = 0;
	}

	@Override
	public void renderToBuffer(MatrixStack matrixStack, IVertexBuilder buffer, int packedLight, int packedOverlay, float red, float green, float blue, float alpha)
	{
      // If I try to set the grass rotations here instead, there's still no effect.
		vine.render(matrixStack, buffer, packedLight, packedOverlay);
		grass.render(matrixStack, buffer, packedLight, packedOverlay);
	}

	public void setRotationAngle(ModelRenderer modelRenderer, float x, float y, float z)
	{
		modelRenderer.xRot = x;
		modelRenderer.yRot = y;
		modelRenderer.zRot = z;
	}
}

 

 

Edited by SapphireSky
Posted

I haven't done anything with entity renderers in a very long time, but it might be because your whole model is being rotated. If this is the case, you probably have the vine rotating further/faster than the grass.

One thing that might fix your issue would be to rotate the grass in the opposite direction (so the whole model rotates, but the grass is rotated back the other way so it is in the same orientation).

Posted
31 minutes ago, Alpvax said:

I haven't done anything with entity renderers in a very long time, but it might be because your whole model is being rotated. If this is the case, you probably have the vine rotating further/faster than the grass.

One thing that might fix your issue would be to rotate the grass in the opposite direction (so the whole model rotates, but the grass is rotated back the other way so it is in the same orientation).

But the whole model ISN'T being rotated... All grass rotations are specifically being set to 0 at the end of the animation. Only the head/vine are rotated.

If I rotate it the opposite direction, there's absolutely no change. Even if I subtract the entity's rotation from the model rotation there's still absolutely no change.

Like somehow vine accepts rotations, head accepts rotations, but even though grass is set up the same exact way and rotated the same exact way, it's just not accepting any changes to rotation.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.