[1.18.2] Custom TickableSoundInstance not playing

[SlimingHD]

Hello friends,

I recently started to experiment with TickableSoundInstance and bumped into a problem. My tickable sound instance is not playing. Tick doesn't work either. My guess is that I probably need to register it somehow, but I have no idea how. I have worked with MinecartSoundInstance before and they work fine and are never registered.

Anyway, here is my code:

package core.client;

import core.entity.VehicleBaseEntity;
import net.minecraft.client.resources.sounds.AbstractTickableSoundInstance;
import net.minecraft.sounds.SoundEvent;
import net.minecraft.sounds.SoundSource;

public class VehicleDrivingSoundInstance extends AbstractTickableSoundInstance{

	public VehicleBaseEntity entity;
	
	public VehicleDrivingSoundInstance(VehicleBaseEntity entity, SoundEvent sound) {
		super(sound, SoundSource.MASTER);
		x = entity.getX();
		y = entity.getY();
		z = entity.getZ();
		looping = true;
		delay = 0;
		volume = 0f;
		pitch = 0f;
		this.entity = entity;
	}
	
	public boolean canPlaySound() {
		return true;
	}
	
	public boolean canStartSilent() {
		return true;
	}
	
	public void tick() {
		x = entity.getX();
		y = entity.getY();
		z = entity.getZ();
		if(entity.isRemoved()) {
			stop();
		}
		if(entity.isDrivingForward()) {
			volume = 2 * entity.getSpeed() / entity.getMaxSpeed();
			pitch = 0.25f + entity.getSpeed() / entity.getMaxSpeed();
		}
		else if(entity.isDrivingBackward()) {
			volume = 2 * entity.getSpeed() / entity.getMaxBackwardSpeed();
			pitch = 0.25f + entity.getSpeed() / entity.getMaxBackwardSpeed();
		}
		else {
			volume = 0f;
			pitch = 0f;
		}
	}
}

This is the line I use to play the sound inside the client constructor of my entity:

Minecraft.getInstance().getSoundManager().play(new VehicleDrivingSoundInstance(this, SoundEvents.MINECART_RIDING));

This works fine for custom minecarts, but does not work in this case. I might be stupid and this is not the way to do it at all, but if it is and you know an answer or know where I should look, please tell me.

Thanks in advance!

[SlimingHD]

Thank you very much! That is indeed the solution.

[SlimingHD]

I hope this is not too much to ask for, but how would I feed in my own SoundEvent? The Soundmanager in AbstractSoundInstance looks for an already existing Sound in the minecraft registry. 

Thank you in advance!

[SlimingHD]

I in fact already registered my SoundEvent. But in this case I need a Sound, not a Soundevent. I looked through all the vanilla code I could find but did not manage to find how to do it. I seem to be the only person having this problem or it might just not be possible at all. Writing a custom Soundmanager is the only idea I still have.

[SlimingHD]

Here is the code of AbstractSoundInstance that is relevant:

   protected AbstractSoundInstance(SoundEvent p_119584_, SoundSource p_119585_) {
      this(p_119584_.getLocation(), p_119585_);
   }

   protected AbstractSoundInstance(ResourceLocation p_119587_, SoundSource p_119588_) {
      this.location = p_119587_;
      this.source = p_119588_;
   }

   public ResourceLocation getLocation() {
      return this.location;
   }

   public WeighedSoundEvents resolve(SoundManager p_119591_) {
      WeighedSoundEvents weighedsoundevents = p_119591_.getSoundEvent(this.location);
      if (weighedsoundevents == null) {
         this.sound = SoundManager.EMPTY_SOUND;
      } else {
         this.sound = weighedsoundevents.getSound();
      }

      return weighedsoundevents;
   }

The first constructor is the one I call. And sound is an Instance of Sound. My problem, as far as I am aware, is resolve, because this.sound indeed returns an EMPTY_SOUND. I have tried overriding it and simply setting it to whatever I want, but that did not work. I simply can't get a grip on what I need to do. I am very sorry if I am annoying.

[SlimingHD]

Oh god I am so sorry and stupid, I messed up my Registry name -_-! And here I was thinking everything was more complex than it is!