Jump to content

[Solved][Noob mistake]Eclipse saving NBT Tags between debug sessions


Recommended Posts

Posted

While playing around with NBT Stack Tag information I noticed the stack tag doesn't seem to save between debuggin sessions.

 

The simple item I made just counts how many times the player right clicks while it is equipped. It saves the information to the NBTTagCompound.setInteger function. It seems to work, and was a good learning experience. Now if I run the debug in Eclipse, Minecraft runs fine and the item does as it is suppose to.

 

If I "Save and Quit to Title" but don't end the session the item remembers the amount of clicks if I load the world again. But if I quit the debug all together the amount of clicks is forgotten, and starts from one when starting a new session of the debug.

 

So my question is, is that normal? Or did I save the NBT information incorrectly? Does Eclipse only save world information and not NBT info? I think it is saving client side. Should it be server side? Or does that matter?

 

Thanks.

Posted

Well I tried putting in a if(World.isRemote) line to see if it was a server issue. Doesn't seem to be. Here is the original code that works, except for the whole saving thing.

 

int ClickId;

@Override
public ItemStack onItemRightClick(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer)
    {
	if(par1ItemStack.stackTagCompound == null)
	{
		par1ItemStack.stackTagCompound = new NBTTagCompound();
	}


	if(!par2World.isRemote)
	{
		par1ItemStack.stackTagCompound.setInteger("ClickCount", this.ClickId);
	        this.ClickId++;
	        par3EntityPlayer.addChatMessage("The count of right clicks is " + this.ClickId);
	}
        return par1ItemStack;
    }

 

If it's a eclipse issue that is really troubling. I'll have to re-obf just to test any further changes. :'(

Posted

 

Thanks a bunch. Cause of your post I realized the mistake. It was a noob JAVA mistake. I was inadvertently resetting the count to 0 with each session. Here's the revised code for other noobs to learn from.

 

@Override
public ItemStack onItemRightClick(ItemStack par1, World par2World, EntityPlayer par3EntityPlayer)
    {
	if(par1.stackTagCompound == null)
	{
		par1.stackTagCompound = new NBTTagCompound();
	}

	if(!par2World.isRemote)
	{
		int ClickId = par1.stackTagCompound.getInteger("ClickCount");
		ClickId++;
		par1.stackTagCompound.setInteger("ClickCount", ClickId);
		par3EntityPlayer.addChatMessage("The count of right clicks is " + ClickId);
	}
        return par1;
    }

 

Thanks again for the patience with a java noob.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Make a test with another Launcher like the Curseforge Launcher, MultiMC or AT Launcher
    • can anyone help me i am opening forge and add modpacks and then it says unable to update native luancher and i redownlaod java and the luancher it self?
    • The problem occurs also in 1.20.1 Forge, but with an "Error executing task on client" instead. I have "Sinytra Connector" installed. On 1.21.5 Fabric, there is no problem. When this happens, the chat message before the death screen appears gets sent, with an extra dash added.
    • Well, as usual, it was user error. Naming mismatch in sounds.json.  Please delete this post if you find it necessary. 
    • Hello Forge community.  I'm running into an issue with a mod I'm working on.  To preface, I can call /playsound modId:name music @a and I can hear the sound I registered being played in game. Great!  However, I cannot get it to trigger via my mod code.    Registration: public static final RegistryObject<SoundEvent> A_WORLD_OF_MADNESS = SOUND_EVENTS.register("a_world_of_madness", () -> new SoundEvent(new ResourceLocation("tetheredsouls", "a_world_of_madness")));   Playback: Minecraft mc = Minecraft.getInstance(); if (!(mc.player instanceof LocalPlayer) || mc.level == null) return; LocalPlayer player = (LocalPlayer) mc.player; BlockPos pos = player.blockPosition(); SoundEvent track = ModSounds.A_WORLD_OF_MADNESS.get(); System.out.println(track); System.out.println(pos); System.out.println(player); // play exactly like the tutorial: client-only, at the player's position try { mc.level.playLocalSound( player.getX(), player.getY(), player.getZ(), track, SoundSource.MUSIC, // Or MASTER if needed 1f, 1f, false ); System.out.println("[DEBUG] playSound success: " + track.getLocation()); } catch (Exception e) { System.err.println("[ERROR] Failed to play sound: " + track.getLocation()); e.printStackTrace(); } Sounds.json:   { "theme_of_laura": { "category": "music", "sounds": [ { "name": "tetheredsouls:a_world_of_madness", "stream": true } ] } } Things I have tried: - multiple .ogg files. Short .ogg files (5 seconds, <100KB).  - default minecraft sounds imported from import net.minecraft.sounds.SoundEvents; These work given my code. No idea why these are different.  - playSound() method, as well as several others in past iterations that did not work   I would be forever grateful if somebody could point me in the right direction. I've looked at several mod github repositories and found extremely similar code to what I'm doing. I've also found several threads in this forum that did not solve my issue. I just cannot figure out what I'm doing differently, and why I'm able to queue sounds manually with playsound but the code won't play it (despite confirming the code is being run with the debug statements.)
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.