Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

So i have a BlockEntity that's has a container and stores items inside of it, when you click on it, item will render and stored inside of block.

But there's a problem, when i click on it using item like swords or tridents, it doesn't save item tags like durability, enchantments, or names.

I know there's a NBT tags, but i didn't saw vanilla code using this on Item Frame etc. And i think there's some other ways to do that.

 

Here's some code ->

@Override
    public InteractionResult use(BlockState state, Level level, BlockPos pos, Player player, InteractionHand hand, BlockHitResult result) {
        if(!level.isClientSide){
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (level.getBlockState(pos.below()).is(ModTags.Blocks.SPECIAL_CAULDRON_EXPLODES)) {
                    level.explode(null, DamageSource.MAGIC, null, pos.getX(), pos.getY(), pos.getZ(), 3.5f, false, Explosion.BlockInteraction.DESTROY);
                }
            }
        }

        if (level.isClientSide) {
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (entity.getItem(0).is(ItemStack.EMPTY.getItem()) && !player.getMainHandItem().is(ItemStack.EMPTY.getItem())) {
                    ItemStack item = player.getItemInHand(hand).copy();
                    level.playLocalSound(pos.getX(), pos.getY(), pos.getZ(), SoundEvents.END_PORTAL_FRAME_FILL, SoundSource.BLOCKS, 1.0f, 1.0f, true);
                    entity.setItem(0, item);
                    player.getMainHandItem().shrink(1);
                } else {
                    if (!entity.getItem(0).is(ItemStack.EMPTY.getItem())) {
                        player.addItem(entity.getItem(0).getItem().getDefaultInstance());
                        level.playLocalSound(pos.getX(), pos.getY(), pos.getZ(), SoundEvents.ITEM_PICKUP, SoundSource.BLOCKS, 0.75f, 1f, true);
                        entity.setItem(0, ItemStack.EMPTY);
                    }
                }
            }
        }
        return InteractionResult.SUCCESS;
    }

 

  • Author

(It started working by itself idk why). But i still interested how to do it properly.

And i also got another problem, when i'm clicking my block with sword, it work's but when i'm trying to break it, it doesn't.

Probably because of my block thinks that i have a sword in my hand (because you cant break block with hand) but it's not.

 

Updated Code ->

@Override
    public InteractionResult use(BlockState state, Level level, BlockPos pos, Player player, InteractionHand hand, BlockHitResult result) {
        if(!level.isClientSide){
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (level.getBlockState(pos.below()).is(ModTags.Blocks.SPECIAL_CAULDRON_EXPLODES)) {
                    level.explode(null, DamageSource.MAGIC, null, pos.getX(), pos.getY(), pos.getZ(), 3.5f, false, Explosion.BlockInteraction.DESTROY);
                }
            }
        }

        if (level.isClientSide) {
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (entity.getItem(0).is(ItemStack.EMPTY.getItem()) && !player.getMainHandItem().is(ItemStack.EMPTY.getItem())) {
                    ItemStack item = player.getItemInHand(hand).copy();
                    level.playLocalSound(pos.getX(), pos.getY(), pos.getZ(), SoundEvents.END_PORTAL_FRAME_FILL, SoundSource.BLOCKS, 1.0f, 1.0f, true);
                    entity.setItem(0, item);
                    player.getMainHandItem().shrink(1);
                } else {
                    if (!entity.getItem(0).is(ItemStack.EMPTY.getItem())) {
                        player.addItem(entity.getItem(0));
                        level.playLocalSound(pos.getX(), pos.getY(), pos.getZ(), SoundEvents.ITEM_PICKUP, SoundSource.BLOCKS, 0.75f, 1f, true);
                        entity.setItem(0, ItemStack.EMPTY);
                    }
                }
            }
        }
        return InteractionResult.SUCCESS;
    }

 

Edited by Sq3xd
Change post

  • Author

I got it, it happened because it was executed on wrong side, block container works fine, but how do i render items?

  • Author

Nevermind, fixed this.

Updated code ->

@Override
    public InteractionResult use(BlockState state, Level level, BlockPos pos, Player player, InteractionHand hand, BlockHitResult result) {
        // Explode if placed on not correct block


        if (!level.isClientSide){
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (level.getBlockState(pos.below()).is(ModTags.Blocks.SPECIAL_CAULDRON_EXPLODES)) {
                    level.explode(null, DamageSource.MAGIC, null, pos.getX(), pos.getY(), pos.getZ(), 3.5f, false, Explosion.BlockInteraction.DESTROY);
                }
            }
        }

        // Interaction - Server Side
        if (!level.isClientSide) {
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (entity.getItem(0).is(ItemStack.EMPTY.getItem()) && !player.getMainHandItem().is(ItemStack.EMPTY.getItem())) {
                    ItemStack item = player.getItemInHand(hand).copy();
                    entity.setItem(0, item);
                    player.getMainHandItem().shrink(1); // TODO Make normal shrink
                } else {
                    if (!entity.getItem(0).is(ItemStack.EMPTY.getItem())) {
                        player.addItem(entity.getItem(0));
                        entity.setItem(0, ItemStack.EMPTY);
                    }
                }
            }
        }

        // Interaction - Client Side
        if (level.isClientSide) {
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (entity.getItem(0).is(ItemStack.EMPTY.getItem()) && !player.getMainHandItem().is(ItemStack.EMPTY.getItem())) {
                    ItemStack item = player.getItemInHand(hand).copy();
                    level.playLocalSound(pos.getX(), pos.getY(), pos.getZ(), SoundEvents.END_PORTAL_FRAME_FILL, SoundSource.BLOCKS, 1.0f, 1.0f, true);
                    entity.setItem(0, item);
                } else {
                    if (!entity.getItem(0).is(ItemStack.EMPTY.getItem())) {
                        level.playLocalSound(pos.getX(), pos.getY(), pos.getZ(), SoundEvents.ITEM_PICKUP, SoundSource.BLOCKS, 0.75f, 1f, true);
                        entity.setItem(0, ItemStack.EMPTY);
                    }
                }
            }
        }
        return InteractionResult.SUCCESS;
    }

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.