Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Help saving item data

Sq3xd

By Sq3xd
in Modder Support

 Share

Recommended Posts

Sq3xd Tree Puncher

Sq3xd

Posted
Posted

So i have a BlockEntity that's has a container and stores items inside of it, when you click on it, item will render and stored inside of block.

But there's a problem, when i click on it using item like swords or tridents, it doesn't save item tags like durability, enchantments, or names.

I know there's a NBT tags, but i didn't saw vanilla code using this on Item Frame etc. And i think there's some other ways to do that.

 

Here's some code -> 

@Override
    public InteractionResult use(BlockState state, Level level, BlockPos pos, Player player, InteractionHand hand, BlockHitResult result) {
        if(!level.isClientSide){
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (level.getBlockState(pos.below()).is(ModTags.Blocks.SPECIAL_CAULDRON_EXPLODES)) {
                    level.explode(null, DamageSource.MAGIC, null, pos.getX(), pos.getY(), pos.getZ(), 3.5f, false, Explosion.BlockInteraction.DESTROY);
                }
            }
        }

        if (level.isClientSide) {
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (entity.getItem(0).is(ItemStack.EMPTY.getItem()) && !player.getMainHandItem().is(ItemStack.EMPTY.getItem())) {
                    ItemStack item = player.getItemInHand(hand).copy();
                    level.playLocalSound(pos.getX(), pos.getY(), pos.getZ(), SoundEvents.END_PORTAL_FRAME_FILL, SoundSource.BLOCKS, 1.0f, 1.0f, true);
                    entity.setItem(0, item);
                    player.getMainHandItem().shrink(1);
                } else {
                    if (!entity.getItem(0).is(ItemStack.EMPTY.getItem())) {
                        player.addItem(entity.getItem(0).getItem().getDefaultInstance());
                        level.playLocalSound(pos.getX(), pos.getY(), pos.getZ(), SoundEvents.ITEM_PICKUP, SoundSource.BLOCKS, 0.75f, 1f, true);
                        entity.setItem(0, ItemStack.EMPTY);
                    }
                }
            }
        }
        return InteractionResult.SUCCESS;
    }

 

Sq3xd Tree Puncher

Sq3xd

Posted
  • Author
Posted (edited)

(It started working by itself idk why). But i still interested how to do it properly.

And i also got another problem, when i'm clicking my block with sword, it work's but when i'm trying to break it, it doesn't.

Probably because of my block thinks that i have a sword in my hand (because you cant break block with hand) but it's not.

 

Updated Code -> 

@Override
    public InteractionResult use(BlockState state, Level level, BlockPos pos, Player player, InteractionHand hand, BlockHitResult result) {
        if(!level.isClientSide){
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (level.getBlockState(pos.below()).is(ModTags.Blocks.SPECIAL_CAULDRON_EXPLODES)) {
                    level.explode(null, DamageSource.MAGIC, null, pos.getX(), pos.getY(), pos.getZ(), 3.5f, false, Explosion.BlockInteraction.DESTROY);
                }
            }
        }

        if (level.isClientSide) {
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (entity.getItem(0).is(ItemStack.EMPTY.getItem()) && !player.getMainHandItem().is(ItemStack.EMPTY.getItem())) {
                    ItemStack item = player.getItemInHand(hand).copy();
                    level.playLocalSound(pos.getX(), pos.getY(), pos.getZ(), SoundEvents.END_PORTAL_FRAME_FILL, SoundSource.BLOCKS, 1.0f, 1.0f, true);
                    entity.setItem(0, item);
                    player.getMainHandItem().shrink(1);
                } else {
                    if (!entity.getItem(0).is(ItemStack.EMPTY.getItem())) {
                        player.addItem(entity.getItem(0));
                        level.playLocalSound(pos.getX(), pos.getY(), pos.getZ(), SoundEvents.ITEM_PICKUP, SoundSource.BLOCKS, 0.75f, 1f, true);
                        entity.setItem(0, ItemStack.EMPTY);
                    }
                }
            }
        }
        return InteractionResult.SUCCESS;
    }

 

Edited by Sq3xd
Change post
Sq3xd Tree Puncher

Sq3xd

Posted
  • Author
Posted

Nevermind, fixed this.

Updated code -> 

@Override
    public InteractionResult use(BlockState state, Level level, BlockPos pos, Player player, InteractionHand hand, BlockHitResult result) {
        // Explode if placed on not correct block


        if (!level.isClientSide){
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (level.getBlockState(pos.below()).is(ModTags.Blocks.SPECIAL_CAULDRON_EXPLODES)) {
                    level.explode(null, DamageSource.MAGIC, null, pos.getX(), pos.getY(), pos.getZ(), 3.5f, false, Explosion.BlockInteraction.DESTROY);
                }
            }
        }

        // Interaction - Server Side
        if (!level.isClientSide) {
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (entity.getItem(0).is(ItemStack.EMPTY.getItem()) && !player.getMainHandItem().is(ItemStack.EMPTY.getItem())) {
                    ItemStack item = player.getItemInHand(hand).copy();
                    entity.setItem(0, item);
                    player.getMainHandItem().shrink(1); // TODO Make normal shrink
                } else {
                    if (!entity.getItem(0).is(ItemStack.EMPTY.getItem())) {
                        player.addItem(entity.getItem(0));
                        entity.setItem(0, ItemStack.EMPTY);
                    }
                }
            }
        }

        // Interaction - Client Side
        if (level.isClientSide) {
            if (level.getBlockEntity(pos) instanceof SpecialCauldronBlockEntity entity) {
                if (entity.getItem(0).is(ItemStack.EMPTY.getItem()) && !player.getMainHandItem().is(ItemStack.EMPTY.getItem())) {
                    ItemStack item = player.getItemInHand(hand).copy();
                    level.playLocalSound(pos.getX(), pos.getY(), pos.getZ(), SoundEvents.END_PORTAL_FRAME_FILL, SoundSource.BLOCKS, 1.0f, 1.0f, true);
                    entity.setItem(0, item);
                } else {
                    if (!entity.getItem(0).is(ItemStack.EMPTY.getItem())) {
                        level.playLocalSound(pos.getX(), pos.getY(), pos.getZ(), SoundEvents.ITEM_PICKUP, SoundSource.BLOCKS, 0.75f, 1f, true);
                        entity.setItem(0, ItemStack.EMPTY);
                    }
                }
            }
        }
        return InteractionResult.SUCCESS;
    }

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

脳   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

脳   Your link has been automatically embedded.   Display as a link instead

脳   Your previous content has been restored.   Clear editor

脳   You cannot paste images directly. Upload or insert images from URL.

脳
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Brigtato02
      Weird crash logs happening for no reason.

      By Brigtato02 路 Posted

      Hey, first time being on this site since I've had crashes I can't figure out. Keeps happening for seemingly no reason as earlier today I was playing MC just fine. And before the logs were either fml.txt or client.text ... but now are server.text ? (I'm only playing single player, never once used any server stuff or been on a server.) Hopefully someone can make heads of this mess.. 馃 Links to logs I got: https://paste.ee/p/kn7W3q2l https://paste.ee/p/15f47bG2
    • Ugdhar
      Help me with registries

      By Ugdhar 路 Posted

      When you name a method like that, with no return value, it is a constructor. The constructor must have the same name as the class it constructs, in this case, ModItems. I would strongly advise reading up on some basic Java tutorials, because you will definitely be running into a lot more issues as you go along without the basics. *I should also add that the Forge documentation is a reference, not a tutorial. Even following tutorials, you should know Java basics, otherwise the smallest of mistakes will trip you up as you copy someone elses code.
    • quase
      Help me with registries

      By quase 路 Posted

      so, I'm starting modding and I'm following the official documantation for forge: https://docs.minecraftforge.net, but in the registries part it is not working as it is in the docs:   public class ModItems { private static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, DarkStarvation.MOD_ID); public static final RegistryObject<Item> TEST_ITEM = ITEMS.register("test_item", () -> new Item(new Item.Properties())); public DarkStarvation(FMLJavaModLoadingContext context) { ITEMS.register(context.getModEventBus()); } } in 'public DarkStarvation(...' the DarkStarvation has this error: Invalid method declaration; return type required and the getModEventBus(): Cannot resolve method 'getModEventBus' in 'FMLJavaModLoadingContext' please help, I asked gpt but it is saying that I'm using an old method, but I'm following the latest version of Forge Docs???
    • Ugdhar
      Reply to my question please

      By Ugdhar 路 Posted

      I merged your second post with the original , there is no need to post a new thread asking for an answer. If someone sees your post and can help, they will reply. If you are seeking a quicker response, you could try asking in the Minecraft Forge diacord.
    • TileEntity
      Cobblemon modpack keeps crashing idk why

      By TileEntity 路 Posted

      Create a new instance and start with cobblemon - if this works, add the rest of your mods in groups   Maybe another mod is conflicting - like Sodium/Iris or Radical Cobblemon Trainers

  • Topics

脳
脳
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept