ashtonr12 Posted September 8, 2013 Posted September 8, 2013 what does this mean? AL lib: (EE) alc_cleanup: 1 device not closed i assume it means i have forgotten a return or a } somewhere and the error shows me where but i don't know how to fix it. Please explain. i want to try and fix it on my own because with what i am trying to do this error keeps popping up, otherwise i will post the current version of this error later. Quote Use examples, i have aspergers. Examples make sense to me.
larsgerrits Posted September 8, 2013 Posted September 8, 2013 I think it means, that something in your code, probably a severe thingy, closed minecraft. Correct me if i'm wrong. Quote Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support. 1.12 -> 1.13 primer by williewillus. 1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support. http://www.howoldisminecraft1710.today/
ashtonr12 Posted September 8, 2013 Author Posted September 8, 2013 http://ragefac.es/you-dont-say Quote Use examples, i have aspergers. Examples make sense to me.
ashtonr12 Posted September 8, 2013 Author Posted September 8, 2013 ok here is the current error nd code; package CriticalStrike.common; import net.minecraft.entity.Entity; import net.minecraft.entity.monster.EntityZombie; import net.minecraft.entity.player.EntityPlayer; import net.minecraft.item.ItemStack; import net.minecraft.util.EntityDamageSource; import net.minecraftforge.event.ForgeSubscribe; import net.minecraftforge.event.entity.living.LivingHurtEvent; public class MobDrops { int Zombie = 0; int Skele = 0; int Pigman = 0; int Ghast = 0; int Blaze = 0; int Slime = 0; int Creeper = 0; int Spider = 0; int CaveSpider = 0; int EnderMan = 0; int MagmaCube = 0; int SilverFish = 0; int Witch = 0; @ForgeSubscribe public void onEntityAttacked(LivingHurtEvent event) { EntityDamageSource dmgSource = (EntityDamageSource) event.source; Entity ent = dmgSource.getEntity(); EntityPlayer player = (EntityPlayer) ent; ItemStack weapon = player.getCurrentEquippedItem(); if (!(ent instanceof EntityPlayer)) {return;} if (event.source.getDamageType().equals("player")) { if (!(weapon == null)){ if (weapon.getItem() instanceof ImmortalAdaptingBlade){ if (event.entityLiving instanceof EntityZombie) { Zombie =+ 1; event.ammount += Zombie;}} } }}} 2013-09-08 16:33:25 [iNFO] [sTDOUT] A detailed walkthrough of the error, its code path and all known details is as follows: 2013-09-08 16:33:25 [iNFO] [sTDOUT] --------------------------------------------------------------------------------------- 2013-09-08 16:33:25 [iNFO] [sTDOUT] 2013-09-08 16:33:25 [iNFO] [sTDOUT] -- Head -- 2013-09-08 16:33:25 [iNFO] [sTDOUT] Stacktrace: 2013-09-08 16:33:25 [iNFO] [sTDOUT] at CriticalStrike.common.MobDrops.onEntityAttacked(MobDrops.java:31) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraftforge.event.ASMEventHandler_4_MobDrops_onEntityAttacked_LivingHurtEvent.invoke(.dynamic) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraftforge.event.ASMEventHandler.invoke(ASMEventHandler.java:39) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraftforge.event.EventBus.post(EventBus.java:108) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraftforge.common.ForgeHooks.onLivingHurt(ForgeHooks.java:335) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.entity.EntityLivingBase.damageEntity(EntityLivingBase.java:1254) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.entity.EntityLivingBase.attackEntityFrom(EntityLivingBase.java:879) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.entity.passive.EntityBat.attackEntityFrom(EntityBat.java:236) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.entity.Entity.setOnFireFromLava(Entity.java:585) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.entity.Entity.onEntityUpdate(Entity.java:552) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.entity.EntityLivingBase.onEntityUpdate(EntityLivingBase.java:266) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.entity.EntityLiving.onEntityUpdate(EntityLiving.java:195) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.entity.Entity.onUpdate(Entity.java:434) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.entity.EntityLivingBase.onUpdate(EntityLivingBase.java:1772) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.entity.EntityLiving.onUpdate(EntityLiving.java:253) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.entity.passive.EntityBat.onUpdate(EntityBat.java:124) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.world.World.updateEntityWithOptionalForce(World.java:2345) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.world.WorldServer.updateEntityWithOptionalForce(WorldServer.java:717) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.world.World.updateEntity(World.java:2306) 2013-09-08 16:33:25 [iNFO] [sTDOUT] 2013-09-08 16:33:25 [iNFO] [sTDOUT] -- Entity being ticked -- 2013-09-08 16:33:25 [iNFO] [sTDOUT] Details: 2013-09-08 16:33:25 [iNFO] [sTDOUT] Entity Type: Bat (net.minecraft.entity.passive.EntityBat) 2013-09-08 16:33:25 [iNFO] [sTDOUT] Entity ID: 253 2013-09-08 16:33:25 [iNFO] [sTDOUT] Entity Name: Bat 2013-09-08 16:33:25 [iNFO] [sTDOUT] Entity's Exact location: -181.43, 12.46, 186.91 2013-09-08 16:33:25 [iNFO] [sTDOUT] Entity's Block location: World: (-182,12,186), Chunk: (at 10,0,10 in -12,11; contains blocks -192,0,176 to -177,255,191), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,0,0 to -1,255,511) 2013-09-08 16:33:25 [iNFO] [sTDOUT] Entity's Momentum: -0.03, 0.04, 0.23 2013-09-08 16:33:25 [iNFO] [sTDOUT] Stacktrace: 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.world.World.updateEntities(World.java:2152) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.world.WorldServer.updateEntities(WorldServer.java:548) 2013-09-08 16:33:25 [iNFO] [sTDOUT] 2013-09-08 16:33:25 [iNFO] [sTDOUT] -- Affected level -- 2013-09-08 16:33:25 [iNFO] [sTDOUT] Details: 2013-09-08 16:33:25 [iNFO] [sTDOUT] Level name: New World 2013-09-08 16:33:25 [iNFO] [sTDOUT] All players: 0 total; [] 2013-09-08 16:33:25 [iNFO] [sTDOUT] Chunk stats: ServerChunkCache: 625 Drop: 0 2013-09-08 16:33:25 [iNFO] [sTDOUT] Level seed: 7449326189954406979 2013-09-08 16:33:25 [iNFO] [sTDOUT] Level generator: ID 00 - default, ver 1. Features enabled: true 2013-09-08 16:33:25 [iNFO] [sTDOUT] Level generator options: 2013-09-08 16:33:25 [iNFO] [sTDOUT] Level spawn location: World: (-216,64,236), Chunk: (at 8,4,12 in -14,14; contains blocks -224,0,224 to -209,255,239), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,0,0 to -1,255,511) 2013-09-08 16:33:25 [iNFO] [sTDOUT] Level time: 153481 game time, 153481 day time 2013-09-08 16:33:25 [iNFO] [sTDOUT] Level dimension: 0 2013-09-08 16:33:25 [iNFO] [sTDOUT] Level storage version: 0x04ABD - Anvil 2013-09-08 16:33:25 [iNFO] [sTDOUT] Level weather: Rain time: 10640 (now: true), thunder time: 2922 (now: true) 2013-09-08 16:33:25 [iNFO] [sTDOUT] Level game mode: Game mode: creative (ID 1). Hardcore: false. Cheats: true 2013-09-08 16:33:25 [iNFO] [sTDOUT] Stacktrace: 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:666) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:585) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:129) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482) 2013-09-08 16:33:25 [iNFO] [sTDOUT] at net.minecraft.server.ThreadMinecraftServer.run(ThreadMinecraftServer.java:16) 2013-09-08 16:33:25 [iNFO] [sTDOUT] 2013-09-08 16:33:25 [iNFO] [sTDOUT] -- System Details -- 2013-09-08 16:33:25 [iNFO] [sTDOUT] Details: 2013-09-08 16:33:25 [iNFO] [sTDOUT] Minecraft Version: 1.6.2 2013-09-08 16:33:25 [iNFO] [sTDOUT] Operating System: Windows 7 (x86) version 6.1 2013-09-08 16:33:25 [iNFO] [sTDOUT] Java Version: 1.7.0_07, Oracle Corporation 2013-09-08 16:33:25 [iNFO] [sTDOUT] Java VM Version: Java HotSpot(TM) Client VM (mixed mode), Oracle Corporation 2013-09-08 16:33:25 [iNFO] [sTDOUT] Memory: 839812488 bytes (800 MB) / 1046937600 bytes (998 MB) up to 1046937600 bytes (998 MB) 2013-09-08 16:33:25 [iNFO] [sTDOUT] JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M 2013-09-08 16:33:25 [iNFO] [sTDOUT] AABB Pool Size: 2724 (152544 bytes; 0 MB) allocated, 2724 (152544 bytes; 0 MB) used 2013-09-08 16:33:25 [iNFO] [sTDOUT] Suspicious classes: FML and Forge are installed 2013-09-08 16:33:25 [iNFO] [sTDOUT] IntCache: cache: 0, tcache: 1, allocated: 5, tallocated: 59 2013-09-08 16:33:25 [iNFO] [sTDOUT] FML: MCP v8.04 FML v6.2.35.804 Minecraft Forge 9.10.0.804 4 mods loaded, 4 mods active 2013-09-08 16:33:25 [iNFO] [sTDOUT] mcp{8.04} [Minecraft Coder Pack] (minecraft.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available 2013-09-08 16:33:25 [iNFO] [sTDOUT] FML{6.2.35.804} [Forge Mod Loader] (coremods) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available 2013-09-08 16:33:25 [iNFO] [sTDOUT] Forge{9.10.0.804} [Minecraft Forge] (coremods) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available 2013-09-08 16:33:25 [iNFO] [sTDOUT] criticalstrikemod{1.00} [Critical$trike] (bin) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available 2013-09-08 16:33:25 [iNFO] [sTDOUT] Profiler Position: N/A (disabled) 2013-09-08 16:33:25 [iNFO] [sTDOUT] Vec3 Pool Size: 690 (38640 bytes; 0 MB) allocated, 690 (38640 bytes; 0 MB) used 2013-09-08 16:33:25 [iNFO] [sTDOUT] Player Count: 0 / 8; [] 2013-09-08 16:33:25 [iNFO] [sTDOUT] Type: Integrated Server (map_client.txt) 2013-09-08 16:33:25 [iNFO] [sTDOUT] Is Modded: Definitely; Client brand changed to 'fml,forge' 2013-09-08 16:33:25 [iNFO] [sTDOUT] #@!@# Game crashed! Crash report saved to: #@!@# C:\Users\owner\Documents\Rob's Crap\Minecraft\CriticalStrikeModEclipse 1.62\forge\mcp\jars\.\crash-reports\crash-2013-09-08_16.33.25-server.txt 2013-09-08 16:33:25 [iNFO] [Minecraft-Server] Stopping server 2013-09-08 16:33:25 [iNFO] [Minecraft-Server] Saving players 2013-09-08 16:33:25 [iNFO] [Minecraft-Server] Saving worlds 2013-09-08 16:33:25 [iNFO] [Minecraft-Server] Saving chunks for level 'New World'/Overworld AL lib: (EE) alc_cleanup: 1 device not closed i am trying to make it so that when a specific mob is hit it add damage the more that mob is hit, you can see i have just started with the zombie. Another thing i dont understand is why entity bat is being called none of my code references it? Quote Use examples, i have aspergers. Examples make sense to me.
larsgerrits Posted September 8, 2013 Posted September 8, 2013 It crashes on this line: EntityDamageSource dmgSource = (EntityDamageSource) event.source; Maybe the source isn't a EntitiDamageSource? (never worked with damage etc.) Quote Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support. 1.12 -> 1.13 primer by williewillus. 1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support. http://www.howoldisminecraft1710.today/
ashtonr12 Posted September 8, 2013 Author Posted September 8, 2013 yes i had figured out which line was the problem already i just don't know why Quote Use examples, i have aspergers. Examples make sense to me.
ashtonr12 Posted September 8, 2013 Author Posted September 8, 2013 annoyingly you were right on the mark i missed chekcing if it was actually a damagesource before telling what to do with the damage source. added this and i now works if (!(event.source instanceof EntityDamageSource)) {return;} Quote Use examples, i have aspergers. Examples make sense to me.
ashtonr12 Posted September 8, 2013 Author Posted September 8, 2013 ok mr genius now can you tell me why it isnt doing what i think it should @ForgeSubscribe public void onEntityAttacked(LivingHurtEvent event) { if (!(event.source instanceof EntityDamageSource)) {return;} EntityDamageSource dmgSource = (EntityDamageSource) event.source; Entity ent = dmgSource.getEntity(); EntityPlayer player = (EntityPlayer) ent; ItemStack weapon = player.getCurrentEquippedItem(); if (!(ent instanceof EntityPlayer)) {return;} if (event.source.getDamageType().equals("player")) { if (!(weapon == null)){ if (weapon.getItem() instanceof ImmortalAdaptingBlade){ if (event.entityLiving instanceof EntityZombie) { Zombie =+ 1; event.ammount =+ Zombie; }}}} } what i think is/want to happen; 1. is it a damagesource? Yes 2. is the dmg not from the player? Yes 3.is dmg is from player? Yes 4. the player doesnt not have a weapon? Yes 5. is it ImmortalAdaptingBlade? Yes 6.is the entity being hit a zombie? Yes 7. add 1 dmg this is what i think is happening, but its not, the dmg should be stacking each tie a zombie is hit? so each time the criteria is met the int zombie gets +1. Quote Use examples, i have aspergers. Examples make sense to me.
larsgerrits Posted September 8, 2013 Posted September 8, 2013 Thanks for calling me mr genius, but now back to the topic Did you register the class with the LivingHurtEntity event like so: MinecraftForge.EVENT_BUS.register(new YOUR_CLASS_WITH_LIVING_HURT_ENTITY_EVENT Quote Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support. 1.12 -> 1.13 primer by williewillus. 1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support. http://www.howoldisminecraft1710.today/
ashtonr12 Posted September 8, 2013 Author Posted September 8, 2013 you mean like... MinecraftForge.EVENT_BUS.register(new MobDrops());{} Quote Use examples, i have aspergers. Examples make sense to me.
larsgerrits Posted September 8, 2013 Posted September 8, 2013 Yeah that's it. If you don't have that, add that and test if it works. If it doesn't maybe you could put everything after the first if statement in a else statement. Quote Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support. 1.12 -> 1.13 primer by williewillus. 1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support. http://www.howoldisminecraft1710.today/
GotoLink Posted September 8, 2013 Posted September 8, 2013 Entity ent = dmgSource.getEntity(); EntityPlayer player = (EntityPlayer) ent; ItemStack weapon = player.getCurrentEquippedItem(); if (!(ent instanceof EntityPlayer)) {return;} if (event.source.getDamageType().equals("player")) Again, you are casting to EntityPlayer before checking it is safe to do. And the last check seems useless. Quote
ashtonr12 Posted September 8, 2013 Author Posted September 8, 2013 wait what other check do i need to add? Quote Use examples, i have aspergers. Examples make sense to me.
ashtonr12 Posted September 8, 2013 Author Posted September 8, 2013 ok so i think i did what you said; package CriticalStrike.common; import net.minecraft.entity.Entity; import net.minecraft.entity.monster.EntityZombie; import net.minecraft.entity.player.EntityPlayer; import net.minecraft.item.ItemStack; import net.minecraft.util.EntityDamageSource; import net.minecraftforge.event.ForgeSubscribe; import net.minecraftforge.event.entity.living.LivingHurtEvent; public class MobDrops { int Zombie = 0; int Skele = 0; int Pigman = 0; int Ghast = 0; int Blaze = 0; int Slime = 0; int Creeper = 0; int Spider = 0; int CaveSpider = 0; int EnderMan = 0; int MagmaCube = 0; int SilverFish = 0; int Witch = 0; @ForgeSubscribe public void onEntityAttacked(LivingHurtEvent event) { if (!(event.source instanceof EntityDamageSource)) {return;} EntityDamageSource dmgSource = (EntityDamageSource) event.source; Entity ent = dmgSource.getEntity(); if (!(ent instanceof EntityPlayer)) {return;} EntityPlayer player = (EntityPlayer) ent; ItemStack weapon = player.getCurrentEquippedItem(); if (event.source.getDamageType().equals("player")) { if (!(weapon == null)){ if (weapon.getItem() instanceof ImmortalAdaptingBlade){ if (event.entityLiving instanceof EntityZombie) { Zombie =+ 1; event.ammount =+ Zombie; }}}} } } no errors but it takes 22 hits with sword to kill a zombie which means the int is not staking mearly staying at 1, how do i get it to stack? one for every attack and keep stacking (everytime i hit a zombie) until set back to zero? Quote Use examples, i have aspergers. Examples make sense to me.
GotoLink Posted September 8, 2013 Posted September 8, 2013 Store the "Zombie" value inside the item, with the ItemStack NBT. Quote
ashtonr12 Posted September 8, 2013 Author Posted September 8, 2013 i have never used NBT's before? can you tell me how or direct me to a tutorial? i was going to look into this actually after i have finished what i am working on as i heard you can spawn entities with cool stuff like specific armours and weapons and such. Quote Use examples, i have aspergers. Examples make sense to me.
ashtonr12 Posted September 9, 2013 Author Posted September 9, 2013 anyone know how to do this? "Store the "Zombie" value inside the item, with the ItemStack NBT" Quote Use examples, i have aspergers. Examples make sense to me.
GotoLink Posted September 9, 2013 Posted September 9, 2013 The ItemStack NBT is called stackTagCompound. There are methods for it in ItemStack. Quote
ashtonr12 Posted September 9, 2013 Author Posted September 9, 2013 kk will take a look asap Quote Use examples, i have aspergers. Examples make sense to me.
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.