[SOLVED] Help with a custom macerator-like tile entity machine

[myoKun345]

I am trying to add a machine that functions similarly to the macerator found in Industrial-Craft 2. I have done most of the work myself so far, but my updateTick logic is buggy and messy, leading to the following problems:

 

• Removing the stack from the input slot causes a crash when the recipe time ticks down to zero.
  
• Removing the stack from the output slot causes a "ghost item" to appear in the output slot when the recipe time ticks down again, and the player can remove it but attempting to combine it with another stack of the same kind just makes the game realize it doesn't actually exist. Also, throwing the ghost on the ground will crash the game.
  
• The output stack's size does not increase correctly. (Increasing it with a constant just results in it not increasing at all, increasing it with the recipe value doubles the size for no apparent reason (I am adding, not multiplying them.))
  
• Attempting to place an item in the input slot that is not in a registered recipe as a valid input item will delete the item.
  

 

Obviously I could just copy the vanilla furnace's updateTick and modify it, but I would rather figure it out mostly on my own.

 

Related code files:

https://github.com/myoKun345/ElementalExperimentation/blob/master/elex_common/elex/tileentity/TileEntityGrinder.java

https://github.com/myoKun345/ElementalExperimentation/blob/master/elex_common/elex/block/BlockGrinder.java

https://github.com/myoKun345/ElementalExperimentation/blob/master/elex_common/elex/api/GrinderRecipe.java

https://github.com/myoKun345/ElementalExperimentation/blob/master/elex_common/elex/core/CraftingRecipes.java

 

The rest of the code is in the repository, of course.

 

Thanks in advance for any help.

[myoKun345]

Bump?

[myoKun345]

I fixed the first bullet there by checking for a null stack, but the other bugs still remain and I still don't know how to fix them.

[GotoLink]

@Override
    public World getWorld() {
        return null;
    }

What are you doing ?

[myoKun345]

That was an automatically generated method when I implemented the power interfaces. I don't think it has affected my problems though.

By the way, I figured the rest of the issues out by myself so thanks anyway. The problem was that I was setting the stack to the recipe's stack. I added .copy() to the end and it works fine. At the moment I am finishing it up so it doesn't consume input when the output stacks are full.

 

EDIT: I forgot about the item disappearing if it isn't in a recipe. That still isn't fixed. I could either forget trying to limit it to recipe items or take the extra time to fix that.

[fhntv24]

code file: https://github.com/myoKun345/ElementalExperimentation/blob/master/elex_common/elex/tileentity/TileEntityGrinder.java

line: 122

if (GrinderRecipe.canBeDone(getStackInSlot(0)) && this.grinding == false) {
                        
                        recipe = GrinderRecipe.grinderRecipes.get(getStackInSlot(0).getUnlocalizedName());
                        
                        this.grinderGrindTime = recipe.time;
                        this.grinding = true;
                        
                    }

try change to

if (GrinderRecipe.canBeDone(getStackInSlot(0)) && this.grinding == false) {
                        
                        recipe = GrinderRecipe.grinderRecipes.get(getStackInSlot(0).getUnlocalizedName());
                        
                        this.grinderGrindTime = recipe.time;
                        this.grinding = true;
                        
                    } else if (this.grinding == false) return;

 

edit: p.s. if that will not work,somting wrong in you RecipeGrinder

[myoKun345]

I don't see what that has to do with the item being deleted if it's not in a recipe.

The item still is deleted after adding that.

[fhntv24]

Then somting wrong with you GrinderRecipe(didnt see it first time)

edit:maybe you will try what i send? and if you want to make free-bug macerator watch furnace code and just edit it,its the best way.

[myoKun345]

I'll try that, if you don't mind sending it.

 

EDIT: If anyone else has any ideas, they are still appreciated.

[myoKun345]

At the moment I have just set it to allow any item. If anyone else knows of a solution, great, but for now I am marking this solved.

 

Thanks!